{"thread":{"id":"25130","subject":"[PATCH] remote-helpers: build in platform independent directory","startedAt":"2010-09-17T16:17:56Z","lastAt":"2010-09-17T18:41:02Z","messageCount":3,"participants":["Michael J Gruber","Sverre Rabbelier","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"150888","messageId":"36e03068ded278b5145fdf82658c3270a25c2762.1284740217.git.git@drmicha.warpmail.net","threadId":"25130","inReplyTo":null,"subject":"[PATCH] remote-helpers: build in platform independent directory","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2010-09-17T16:17:56Z","receivedAt":"2010-09-17T16:17:56Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"The build directory which is used by distutils depends on the platform\n(e.g. build/lib on Fedora 13, build/lib.linux-i686-2.6 on Ubuntu 9.04).\nBut test-lib.sh expects to find the build in build/lib which can cause\nt5800-remote-helpers.sh to fail early.\n\nOverride distutils' choice so that the build is always in build/lib.\n\nSigned-off-by: Michael J Gruber <git@drmicha.warpmail.net>\n---\n git_remote_helpers/Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile\nindex 74b05dc..e8172d3 100644\n--- a/git_remote_helpers/Makefile\n+++ b/git_remote_helpers/Makefile\n@@ -26,7 +26,7 @@ PYLIBDIR=$(shell $(PYTHON_PATH) -c \\\n \t print 'lib/python%i.%i/site-packages' % sys.version_info[:2]\")\n \n all: $(pysetupfile)\n-\t$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) build\n+\t$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) build --build-purelib=build/lib --build-platlib=build/lib\n \n install: $(pysetupfile)\n \t$(PYTHON_PATH) $(pysetupfile) install --prefix $(DESTDIR_SQ)$(prefix)\n-- \n1.7.3.rc2.221.gbf93f\n"},{"id":"150890","messageId":"AANLkTimzM+HQ6mvrkCL2mKK9jfOKe0FA6rv=AOfgwJF_@mail.gmail.com","threadId":"25130","inReplyTo":"36e03068ded278b5145fdf82658c3270a25c2762.1284740217.git.git@drmicha.warpmail.net","subject":"Re: [PATCH] remote-helpers: build in platform independent directory","fromName":"Sverre Rabbelier","fromEmail":"srabbelier@gmail.com","sentAt":"2010-09-17T16:31:53Z","receivedAt":"2010-09-17T16:31:53Z","isPatch":true,"sender":{"key":"srabbelier@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3098?v=4"},"body":"Heya,\n\n[+Jonathan]\n\nOn Fri, Sep 17, 2010 at 18:17, Michael J Gruber\n<git@drmicha.warpmail.net> wrote:\n> The build directory which is used by distutils depends on the platform\n> (e.g. build/lib on Fedora 13, build/lib.linux-i686-2.6 on Ubuntu 9.04).\n> But test-lib.sh expects to find the build in build/lib which can cause\n> t5800-remote-helpers.sh to fail early.\n>\n> Override distutils' choice so that the build is always in build/lib.\n>\n> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>\n> ---\n>  git_remote_helpers/Makefile |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile\n> index 74b05dc..e8172d3 100644\n> --- a/git_remote_helpers/Makefile\n> +++ b/git_remote_helpers/Makefile\n> @@ -26,7 +26,7 @@ PYLIBDIR=$(shell $(PYTHON_PATH) -c \\\n>         print 'lib/python%i.%i/site-packages' % sys.version_info[:2]\")\n>\n>  all: $(pysetupfile)\n> -       $(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) build\n> +       $(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) build --build-purelib=build/lib --build-platlib=build/lib\n>\n>  install: $(pysetupfile)\n>        $(PYTHON_PATH) $(pysetupfile) install --prefix $(DESTDIR_SQ)$(prefix)\n\nI don't know if this works on all platforms etc, Jonathan?\n\n-- \nCheers,\n\nSverre Rabbelier\n"},{"id":"150902","messageId":"7vocbw2oxt.fsf@alter.siamese.dyndns.org","threadId":"25130","inReplyTo":"36e03068ded278b5145fdf82658c3270a25c2762.1284740217.git.git@drmicha.warpmail.net","subject":"Re: [PATCH] remote-helpers: build in platform independent directory","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-09-17T18:41:02Z","receivedAt":"2010-09-17T18:41:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Michael J Gruber <git@drmicha.warpmail.net> writes:\n\n> The build directory which is used by distutils depends on the platform\n> (e.g. build/lib on Fedora 13, build/lib.linux-i686-2.6 on Ubuntu 9.04).\n> But test-lib.sh expects to find the build in build/lib which can cause\n> t5800-remote-helpers.sh to fail early.\n>\n> Override distutils' choice so that the build is always in build/lib.\n>\n> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>\n> ---\n>  git_remote_helpers/Makefile |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile\n> index 74b05dc..e8172d3 100644\n> --- a/git_remote_helpers/Makefile\n> +++ b/git_remote_helpers/Makefile\n> @@ -26,7 +26,7 @@ PYLIBDIR=$(shell $(PYTHON_PATH) -c \\\n>  \t print 'lib/python%i.%i/site-packages' % sys.version_info[:2]\")\n>  \n>  all: $(pysetupfile)\n> -\t$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) build\n> +\t$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) build --build-purelib=build/lib --build-platlib=build/lib\n>  \n>  install: $(pysetupfile)\n>  \t$(PYTHON_PATH) $(pysetupfile) install --prefix $(DESTDIR_SQ)$(prefix)\n\nHmm, wouldn't this interfere with the install target if you do not tell\nthe \"setup.py install\" where your built stuff lives?\n"}]}