{"thread":{"id":"251","subject":"(unknown)","startedAt":"2005-04-22T22:19:54Z","lastAt":"2005-04-22T23:16:15Z","messageCount":2,"participants":["atani","Martin Schlemmer"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"1332","messageId":"1114208394.7623@tsunami.he.net","threadId":"251","inReplyTo":null,"subject":"(unknown)","fromName":"atani","fromEmail":"atani@atani-software.net","sentAt":"2005-04-22T22:19:54Z","receivedAt":"2005-04-22T22:19:54Z","isPatch":false,"sender":{"key":"atani@atani-software.net","avatar":null},"body":"In my tests of using git (both Linus and pasky versions) I had a \nproblem with doing \"gitadd.sh *\" where * expands to include \ndirectories. This simple patch allows update-cache.c to more \ngracefully handle a directory being passed into the add_file_to_cache \nmethod.  Without this patch update-cache exits prematurely with an \nerror similar to: \n------------- \nfatal: Unable to add plx to database \n------------- \n \nNow it spits out: \n------------- \n'plx' is a directory, ignoring \n------------- \n \nWhich from an end user stand point is better. \n \nBTW, so far my tests of using git are positive for my small Dreamcast \nsoftware projects...  I was previously using subversion but find it to \nbe a bit of overkill for these small projects. \n \nMartin Schlemmer,  I ran \"emerge sync\" today and found git has been \nadded to portage, version 0.5.  Also note that there are now two \"git\" \nentries within portage app-misc/git and dev-util/git.  app-misc/git is \nGNU Interactive Tools \n \nMike \n \nSigned-off-by: Mike Dunston (atani@atani-software.net) \n \nIndex: update-cache.c \n=================================================================== \n--- 690494557d393ca78f69a8569880ed4a3aeda276/update-cache.c  \n(mode:100644  \nsha1:4353b80890ba2afbe22248a4dc25060aa4a429b2) \n+++ uncommitted/update-cache.c  (mode:100644) \n@@ -104,6 +104,11 @@ \n                close(fd); \n                return -1; \n        } \n+       if(S_ISDIR(st.st_mode)) { \n+               printf(\"'%s' is a directory, ignoring\\n\", path); \n+               close(fd); \n+               return 0; \n+       } \n        namelen = strlen(path); \n        size = cache_entry_size(namelen); \n        ce = malloc(size); \n"},{"id":"1351","messageId":"1114211775.27940.6.camel@nosferatu.lan","threadId":"251","inReplyTo":"1114208394.7623@tsunami.he.net","subject":"Re:","fromName":"Martin Schlemmer","fromEmail":"azarah@nosferatu.za.org","sentAt":"2005-04-22T23:16:15Z","receivedAt":"2005-04-22T23:16:15Z","isPatch":false,"sender":{"key":"azarah@nosferatu.za.org","avatar":null},"body":"On Fri, 2005-04-22 at 15:19 -0700, atani wrote:\n\n<snip>\n\n> Martin Schlemmer,  I ran \"emerge sync\" today and found git has been \n> added to portage, version 0.5.  Also note that there are now two \"git\" \n> entries within portage app-misc/git and dev-util/git.  app-misc/git is \n> GNU Interactive Tools \n>  \n\nYeah, I know - that is actually why I complained to r3pek, as most of\nthe guys interested in doing patches, etc will prob pull and build\nthemselfs, but the user that just want to get the latest kernel, will\nrather want cogito (or git-pasky).  So basically the git I mentioned\nthat I wanted added (or maybe replace the current one in the tree\ndepending on what r3pek do), was Petr's stuff ...\n\n\nThanks,\n\n-- \nMartin Schlemmer\n\n"}]}