{"thread":{"id":"25075","subject":"gitweb: please show tags file history browsing","startedAt":"2010-09-11T14:37:56Z","lastAt":"2010-09-13T05:42:12Z","messageCount":9,"participants":["Tjernlund","Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"150497","messageId":"000001cb51be$ed214dd0$c763e970$@se","threadId":"25075","inReplyTo":null,"subject":"gitweb: please show tags file history browsing","fromName":"Tjernlund","fromEmail":"tjernlund@tjernlund.se","sentAt":"2010-09-11T14:37:56Z","receivedAt":"2010-09-11T14:37:56Z","isPatch":false,"sender":{"key":"tjernlund@tjernlund.se","avatar":null},"body":"I would really like to see where the tags are when browsing\nfile or directory history in gitweb. Would that be possible?\n\n Jocke\n"},{"id":"150508","messageId":"m3r5h0kwn5.fsf@localhost.localdomain","threadId":"25075","inReplyTo":"000001cb51be$ed214dd0$c763e970$@se","subject":"Re: gitweb: please show tags file history browsing","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-09-11T17:40:00Z","receivedAt":"2010-09-11T17:40:00Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"\"Tjernlund\" writes:\n\n> I would really like to see where the tags are when browsing\n> file or directory history in gitweb. Would that be possible?\n\nHmmm... that is second such request...\n\nWhile it probably be possible to show tags in 'history' view, it would\nbe not easy. The problem is that 'history' view shows only commits\nthat touch specified file or directory, and tagged commits usually do\nnot touch those files (at least if one is using \"bump version number\"\ncommits to tag them).\n\nSo you would have: \n1. Design where to show those tags - they would be between shown\n commits.\n2. Create code which shows some/all tags that are between commits in\n the presence of nonlinear history, without affecting performance\n too badly.\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"150524","messageId":"000d01cb525c$c6c2b8b0$54482a10$@se","threadId":"25075","inReplyTo":"m3r5h0kwn5.fsf@localhost.localdomain","subject":"RE: gitweb: please show tags file history browsing","fromName":"Tjernlund","fromEmail":"tjernlund@tjernlund.se","sentAt":"2010-09-12T09:27:52Z","receivedAt":"2010-09-12T09:27:52Z","isPatch":false,"sender":{"key":"tjernlund@tjernlund.se","avatar":null},"body":"> -----Original Message-----\n> From: Jakub Narebski [mailto:jnareb@gmail.com]\n> \n> \"Tjernlund\" writes:\n> \n> > I would really like to see where the tags are when browsing\n> > file or directory history in gitweb. Would that be possible?\n> \n> Hmmm... that is second such request...\n\n:)\n\n> \n> While it probably be possible to show tags in 'history' view, it would\n> be not easy. The problem is that 'history' view shows only commits\n> that touch specified file or directory, and tagged commits usually do\n> not touch those files (at least if one is using \"bump version number\"\n> commits to tag them).\n> \n> So you would have:\n> 1. Design where to show those tags - they would be between shown\n> commits.\n> 2. Create code which shows some/all tags that are between commits in\n> the presence of nonlinear history, without affecting performance\n> too badly.\n\nAh, that is too bad because I think it would really useful.\nImage browsing a drivers history in the linux kernel. Then it would be\nreally nice to see what changes/bug fixes went into what release.\n\n Jocke\n"},{"id":"150530","messageId":"201009121219.58191.jnareb@gmail.com","threadId":"25075","inReplyTo":"000d01cb525c$c6c2b8b0$54482a10$@se","subject":"Re: gitweb: please show tags file history browsing","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-09-12T10:19:57Z","receivedAt":"2010-09-12T10:19:57Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Sun, 12 Sep 2010, Tjernlund wrote:\n> > -----Original Message-----\n> > From: Jakub Narebski [mailto:jnareb@gmail.com]\n> > \n> > \"Tjernlund\" writes:\n> > \n> > > I would really like to see where the tags are when browsing\n> > > file or directory history in gitweb. Would that be possible?\n\n> > While it probably be possible to show tags in 'history' view, it would\n> > be not easy. The problem is that 'history' view shows only commits\n> > that touch specified file or directory, and tagged commits usually do\n> > not touch those files (at least if one is using \"bump version number\"\n> > commits to tag them).\n> > \n> > So you would have:\n> > 1. Design where to show those tags - they would be between shown\n> > commits.\n> > 2. Create code which shows some/all tags that are between commits in\n> > the presence of nonlinear history, without affecting performance\n> > too badly.\n> \n> Ah, that is too bad because I think it would really useful.\n> Image browsing a drivers history in the linux kernel. Then it would be\n> really nice to see what changes/bug fixes went into what release.\n\nFirst, you can help with the first issue even if you can't help with\nthe coding itself.\n\nSecond, with single 'git name-rev --tags --stdin' or with '--decorate'\nor '%d' in format we could (I think) either display at least some tags,\nor name-rev decorations, i.e. something like:\n\n (v1.7.3-rc0~38) gitweb: Don't die_error in git_tag after already printing headers\n (v1.7.3-rc0~44) Merge branch 'maint'\n (v1.7.2.3~15) Typos in code comments, an error message, documentation\n (v1.7.3-rc0~85) Merge branch 'jn/maint-gitweb-dynconf'\n (v1.7.3-rc0~92) Merge branch 'maint'\n (v1.7.2.2~12) gitweb: clarify search results page when no matching commit found\n [...]\n\nIf we want to display all tags we would have IIUC extend git-log to\ngenerate such information.\n\n-- \nJakub Narebski\nPoland\n"},{"id":"150535","messageId":"001101cb527c$041a0eb0$0c4e2c10$@se","threadId":"25075","inReplyTo":"201009121219.58191.jnareb@gmail.com","subject":"RE: gitweb: please show tags file history browsing","fromName":"Tjernlund","fromEmail":"tjernlund@tjernlund.se","sentAt":"2010-09-12T13:11:30Z","receivedAt":"2010-09-12T13:11:30Z","isPatch":false,"sender":{"key":"tjernlund@tjernlund.se","avatar":null},"body":"Jocke\n\n> -----Original Message-----\n> From: Jakub Narebski [mailto:jnareb@gmail.com]\n> On Sun, 12 Sep 2010, Tjernlund wrote:\n> > > -----Original Message-----\n> > > From: Jakub Narebski [mailto:jnareb@gmail.com]\n> > >\n> > > \"Tjernlund\" writes:\n> > >\n> > > > I would really like to see where the tags are when browsing\n> > > > file or directory history in gitweb. Would that be possible?\n> \n> > > While it probably be possible to show tags in 'history' view, it would\n> > > be not easy. The problem is that 'history' view shows only commits\n> > > that touch specified file or directory, and tagged commits usually do\n> > > not touch those files (at least if one is using \"bump version number\"\n> > > commits to tag them).\n> > >\n> > > So you would have:\n> > > 1. Design where to show those tags - they would be between shown\n> > > commits.\n> > > 2. Create code which shows some/all tags that are between commits in\n> > > the presence of nonlinear history, without affecting performance\n> > > too badly.\n> >\n> > Ah, that is too bad because I think it would really useful.\n> > Image browsing a drivers history in the linux kernel. Then it would be\n> > really nice to see what changes/bug fixes went into what release.\n> \n> First, you can help with the first issue even if you can't help with\n> the coding itself.\n\nI like the gitk way of showing tags, won't that work in gitweb too?\n\n> \n> Second, with single 'git name-rev --tags --stdin' or with '--decorate'\n> or '%d' in format we could (I think) either display at least some tags,\n> or name-rev decorations, i.e. something like:\n> \n> (v1.7.3-rc0~38) gitweb: Don't die_error in git_tag after already printing headers\n> (v1.7.3-rc0~44) Merge branch 'maint'\n> (v1.7.2.3~15) Typos in code comments, an error message, documentation\n> (v1.7.3-rc0~85) Merge branch 'jn/maint-gitweb-dynconf'\n> (v1.7.3-rc0~92) Merge branch 'maint'\n> (v1.7.2.2~12) gitweb: clarify search results page when no matching commit found\n> [...]\n> \n> If we want to display all tags we would have IIUC extend git-log to\n> generate such information.\n\nif displaying tags is a too expensive operation one could have a knob\nin gitweb to get at the tags.\n"},{"id":"150537","messageId":"201009121719.32390.jnareb@gmail.com","threadId":"25075","inReplyTo":"001101cb527c$041a0eb0$0c4e2c10$@se","subject":"Re: gitweb: please show tags file history browsing","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-09-12T15:19:31Z","receivedAt":"2010-09-12T15:19:31Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Sun, 12 Sep 2010, Tjernlund wrote:\n>> -----Original Message-----\n>> From: Jakub Narebski [mailto:jnareb@gmail.com]\n>> On Sun, 12 Sep 2010, Tjernlund wrote:\n>>>> -----Original Message-----\n>>>> From: Jakub Narebski [mailto:jnareb@gmail.com]\n>>>>\n>>>> \"Tjernlund\" writes:\n>>>>\n>>>>> I would really like to see where the tags are when browsing\n>>>>> file or directory history in gitweb. Would that be possible?\n>> \n>>>> While it probably be possible to show tags in 'history' view, it would\n>>>> be not easy. The problem is that 'history' view shows only commits\n>>>> that touch specified file or directory, and tagged commits usually do\n>>>> not touch those files (at least if one is using \"bump version number\"\n>>>> commits to tag them).\n>>>>\n>>>> So you would have:\n>>>> 1. Design where to show those tags - they would be between shown\n>>>> commits.\n>>>> 2. Create code which shows some/all tags that are between commits in\n>>>> the presence of nonlinear history, without affecting performance\n>>>> too badly.\n>>>\n>>> Ah, that is too bad because I think it would really useful.\n>>> Image browsing a drivers history in the linux kernel. Then it would be\n>>> really nice to see what changes/bug fixes went into what release.\n>> \n>> First, you can help with the first issue even if you can't help with\n>> the coding itself.\n> \n> I like the gitk way of showing tags, won't that work in gitweb too?\n\nErr... \"gitk\" shows tags, but so does 'shortlog' and 'log' view in\ngitweb. The 'history' view in gitweb doesn't show intermediate tags,\nbut neither does \"gitk -- \".\n\n>> Second, with single 'git name-rev --tags --stdin' or with '--decorate'\n>> or '%d' in format we could (I think) either display at least some tags,\n>> or name-rev decorations, i.e. something like:\n>> \n>> (v1.7.3-rc0~38) gitweb: Don't die_error in git_tag after already printing headers\n>> (v1.7.3-rc0~44) Merge branch 'maint'\n>> (v1.7.2.3~15) Typos in code comments, an error message, documentation\n>> (v1.7.3-rc0~85) Merge branch 'jn/maint-gitweb-dynconf'\n>> (v1.7.3-rc0~92) Merge branch 'maint'\n>> (v1.7.2.2~12) gitweb: clarify search results page when no matching commit found\n>> [...]\n>> \n>> If we want to display all tags we would have IIUC extend git-log to\n>> generate such information.\n> \n> if displaying tags is a too expensive operation one could have a knob\n> in gitweb to get at the tags.\n\nGood thinking. We have such knobs, so called 'features', for 'pickaxe'\nand for 'grep' searches (both which can be expensive).\n\n-- \nJakub Narebski\nPoland\n"},{"id":"150539","messageId":"001201cb5295$5c055850$141008f0$@se","threadId":"25075","inReplyTo":"201009121719.32390.jnareb@gmail.com","subject":"RE: gitweb: please show tags file history browsing","fromName":"Tjernlund","fromEmail":"tjernlund@tjernlund.se","sentAt":"2010-09-12T16:12:55Z","receivedAt":"2010-09-12T16:12:55Z","isPatch":false,"sender":{"key":"tjernlund@tjernlund.se","avatar":null},"body":"> -----Original Message-----\n> On Sun, 12 Sep 2010, Tjernlund wrote:\n> >> -----Original Message-----\n> >> From: Jakub Narebski [mailto:jnareb@gmail.com]\n> >> On Sun, 12 Sep 2010, Tjernlund wrote:\n> >>>> -----Original Message-----\n> >>>> From: Jakub Narebski [mailto:jnareb@gmail.com]\n> >>>>\n> >>>> \"Tjernlund\" writes:\n> >>>>\n> >>>>> I would really like to see where the tags are when browsing\n> >>>>> file or directory history in gitweb. Would that be possible?\n> >>\n> >>>> While it probably be possible to show tags in 'history' view, it would\n> >>>> be not easy. The problem is that 'history' view shows only commits\n> >>>> that touch specified file or directory, and tagged commits usually do\n> >>>> not touch those files (at least if one is using \"bump version number\"\n> >>>> commits to tag them).\n> >>>>\n> >>>> So you would have:\n> >>>> 1. Design where to show those tags - they would be between shown\n> >>>> commits.\n> >>>> 2. Create code which shows some/all tags that are between commits in\n> >>>> the presence of nonlinear history, without affecting performance\n> >>>> too badly.\n> >>>\n> >>> Ah, that is too bad because I think it would really useful.\n> >>> Image browsing a drivers history in the linux kernel. Then it would be\n> >>> really nice to see what changes/bug fixes went into what release.\n> >>\n> >> First, you can help with the first issue even if you can't help with\n> >> the coding itself.\n> >\n> > I like the gitk way of showing tags, won't that work in gitweb too?\n> \n> Err... \"gitk\" shows tags, but so does 'shortlog' and 'log' view in\n> gitweb. The 'history' view in gitweb doesn't show intermediate tags,\n> but neither does \"gitk -- \".\n\nI know, I just meant the yellow note with tag name in it, how tags\nare displayed. When they are display is another matter :)\n"},{"id":"150544","messageId":"201009122020.11556.jnareb@gmail.com","threadId":"25075","inReplyTo":"001201cb5295$5c055850$141008f0$@se","subject":"Re: gitweb: please show tags file history browsing","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-09-12T18:20:09Z","receivedAt":"2010-09-12T18:20:09Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Tjernlund wrote:\n>> On Sun, 12 Sep 2010, Tjernlund wrote:\n>>>> From: Jakub Narebski [mailto:jnareb@gmail.com]\n>>>> On Sun, 12 Sep 2010, Tjernlund wrote:\n>>>>>> From: Jakub Narebski [mailto:jnareb@gmail.com]\n\n>>>>>> While it probably be possible to show tags in 'history' view, it would\n>>>>>> be not easy. The problem is that 'history' view shows only commits\n>>>>>> that touch specified file or directory, and tagged commits usually do\n>>>>>> not touch those files (at least if one is using \"bump version number\"\n>>>>>> commits to tag them).\n>>>>>>\n>>>>>> So you would have:\n>>>>>> 1. Design where to show those tags - they would be between shown\n>>>>>> commits.\n>>>>>> 2. Create code which shows some/all tags that are between commits in\n>>>>>> the presence of nonlinear history, without affecting performance\n>>>>>> too badly.\n>>>>>\n>>>>> Ah, that is too bad because I think it would really useful.\n>>>>> Image browsing a drivers history in the linux kernel. Then it would be\n>>>>> really nice to see what changes/bug fixes went into what release.\n>>>>\n>>>> First, you can help with the first issue even if you can't help with\n>>>> the coding itself.\n>>>\n>>> I like the gitk way of showing tags, won't that work in gitweb too?\n>> \n>> Err... \"gitk\" shows tags, but so does 'shortlog' and 'log' view in\n>> gitweb. The 'history' view in gitweb doesn't show intermediate tags,\n>> but neither does \"gitk -- \".\n> \n> I know, I just meant the yellow note with tag name in it, how tags\n> are displayed. When they are display is another matter :)\n\nWhen those yellow notes with tag name are displayed beside commit\nsubject it means that this commit is referenced by given tag (i.e.\n^{commit} = ).\n\nWe have to distinguish situation where tag is between commits, and\ntag points to commit.\n\n-- \nJakub Narebski\nPoland\n"},{"id":"150572","messageId":"001601cb5306$6a7d8030$3f788090$@se","threadId":"25075","inReplyTo":"201009122020.11556.jnareb@gmail.com","subject":"RE: gitweb: please show tags file history browsing","fromName":"Tjernlund","fromEmail":"tjernlund@tjernlund.se","sentAt":"2010-09-13T05:42:12Z","receivedAt":"2010-09-13T05:42:12Z","isPatch":false,"sender":{"key":"tjernlund@tjernlund.se","avatar":null},"body":"> -----Original Message-----\n> From: Jakub Narebski [mailto:jnareb@gmail.com]\n> Tjernlund wrote:\n> >> On Sun, 12 Sep 2010, Tjernlund wrote:\n> >>>> From: Jakub Narebski [mailto:jnareb@gmail.com]\n> >>>> On Sun, 12 Sep 2010, Tjernlund wrote:\n> >>>>>> From: Jakub Narebski [mailto:jnareb@gmail.com]\n> \n> >>>>>> While it probably be possible to show tags in 'history' view, it would\n> >>>>>> be not easy. The problem is that 'history' view shows only commits\n> >>>>>> that touch specified file or directory, and tagged commits usually do\n> >>>>>> not touch those files (at least if one is using \"bump version number\"\n> >>>>>> commits to tag them).\n> >>>>>>\n> >>>>>> So you would have:\n> >>>>>> 1. Design where to show those tags - they would be between shown\n> >>>>>> commits.\n> >>>>>> 2. Create code which shows some/all tags that are between commits in\n> >>>>>> the presence of nonlinear history, without affecting performance\n> >>>>>> too badly.\n> >>>>>\n> >>>>> Ah, that is too bad because I think it would really useful.\n> >>>>> Image browsing a drivers history in the linux kernel. Then it would be\n> >>>>> really nice to see what changes/bug fixes went into what release.\n> >>>>\n> >>>> First, you can help with the first issue even if you can't help with\n> >>>> the coding itself.\n> >>>\n> >>> I like the gitk way of showing tags, won't that work in gitweb too?\n> >>\n> >> Err... \"gitk\" shows tags, but so does 'shortlog' and 'log' view in\n> >> gitweb. The 'history' view in gitweb doesn't show intermediate tags,\n> >> but neither does \"gitk -- \".\n> >\n> > I know, I just meant the yellow note with tag name in it, how tags\n> > are displayed. When they are display is another matter :)\n> \n> When those yellow notes with tag name are displayed beside commit\n> subject it means that this commit is referenced by given tag (i.e.\n> ^{commit} = ).\n> \n> We have to distinguish situation where tag is between commits, and\n> tag points to commit.\n\nWhy? I just want to know if a commit is included or not in the tag.\nWhen a tag is formally between commits, just display the\ntag with the commit line below.\n\n Jocke \n"}]}