{"thread":{"id":"25074","subject":"[PATCH] compat/nedmalloc: don't force NDEBUG on the rest of git","startedAt":"2010-09-11T09:59:18Z","lastAt":"2010-09-11T17:23:18Z","messageCount":2,"participants":["René Scharfe","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"150496","messageId":"4C8B52F6.5040609@lsrfire.ath.cx","threadId":"25074","inReplyTo":null,"subject":"[PATCH] compat/nedmalloc: don't force NDEBUG on the rest of git","fromName":"René Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2010-09-11T09:59:18Z","receivedAt":"2010-09-11T09:59:18Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Define the nedmalloc feature configuration macros for nedmalloc.o, only.\nThis keeps assert(3) working for the rest of the git source; it was\nturned off for nedmalloc users before by defining NDEBUG globally.\n\nAlso remove -DUSE_NED_ALLOCATOR as this macro isn't used anywhere.\n\nSigned-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>\n---\n Makefile |    7 ++++++-\n 1 files changed, 6 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex c27e8bc..4d45e04 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1465,7 +1465,7 @@ ifdef NO_REGEX\n endif\n \n ifdef USE_NED_ALLOCATOR\n-       COMPAT_CFLAGS += -DUSE_NED_ALLOCATOR -DOVERRIDE_STRDUP -DNDEBUG -DREPLACE_SYSTEM_ALLOCATOR -Icompat/nedmalloc\n+       COMPAT_CFLAGS += -Icompat/nedmalloc\n        COMPAT_OBJS += compat/nedmalloc/nedmalloc.o\n endif\n \n@@ -1908,6 +1908,11 @@ ifdef NO_REGEX\n compat/regex/regex.o: EXTRA_CPPFLAGS = -DGAWK -DNO_MBSUPPORT\n endif\n \n+ifdef USE_NED_ALLOCATOR\n+compat/nedmalloc/nedmalloc.o: EXTRA_CPPFLAGS = \\\n+\t-DNDEBUG -DOVERRIDE_STRDUP -DREPLACE_SYSTEM_ALLOCATOR\n+endif\n+\n git-%$X: %.o $(GITLIBS)\n \t$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) $(LIBS)\n \n"},{"id":"150504","messageId":"7vocc4fb3t.fsf@alter.siamese.dyndns.org","threadId":"25074","inReplyTo":"4C8B52F6.5040609@lsrfire.ath.cx","subject":"Re: [PATCH] compat/nedmalloc: don't force NDEBUG on the rest of git","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-09-11T17:23:18Z","receivedAt":"2010-09-11T17:23:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Makes sense; thanks.\n"}]}