{"thread":{"id":"25062","subject":"[PATCH] config.txt: fix placement of diff.noprefix","startedAt":"2010-09-10T01:39:37Z","lastAt":"2010-09-10T16:46:44Z","messageCount":3,"participants":["Mark Lodato","Junio C Hamano","Eli Collins"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"150425","messageId":"1284082777-18826-1-git-send-email-lodatom@gmail.com","threadId":"25062","inReplyTo":null,"subject":"[PATCH] config.txt: fix placement of diff.noprefix","fromName":"Mark Lodato","fromEmail":"lodatom@gmail.com","sentAt":"2010-09-10T01:39:37Z","receivedAt":"2010-09-10T01:39:37Z","isPatch":true,"sender":{"key":"lodatom@gmail.com","avatar":"https://avatars.githubusercontent.com/u/58860?v=4"},"body":"In git-config(1), diff.noprefix was placed in between\ndiff.mnemonicprefix and the list of mnemonic prefixes, which is\nobviously incorrect and very confusing to readers. Now, it is located\nafter the end of the explanation of mnemonicprefix, which makes much\nmore sense.\n\nSigned-off-by: Mark Lodato \n---\n Documentation/config.txt | 5 +++--\n 1 files changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex d294dd6..d82c0da 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -813,8 +813,6 @@ diff.mnemonicprefix::\n \tstandard \"a/\" and \"b/\" depending on what is being compared. When\n \tthis configuration is in effect, reverse diff output also swaps\n \tthe order of the prefixes:\n-diff.noprefix::\n-\tIf set, 'git diff' does not show any source or destination prefix.\n `git diff`;;\n \tcompares the (i)ndex and the (w)ork tree;\n `git diff HEAD`;;\n@@ -826,6 +824,9 @@ diff.noprefix::\n `git diff --no-index a b`;;\n \tcompares two non-git things (1) and (2).\n \n+diff.noprefix::\n+\tIf set, 'git diff' does not show any source or destination prefix.\n+\n diff.renameLimit::\n \tThe number of files to consider when performing the copy/rename\n \tdetection; equivalent to the 'git diff' option '-l'.\n-- \n1.7.2.3\n"},{"id":"150451","messageId":"7vvd6dh83o.fsf@alter.siamese.dyndns.org","threadId":"25062","inReplyTo":"1284082777-18826-1-git-send-email-lodatom@gmail.com","subject":"Re: [PATCH] config.txt: fix placement of diff.noprefix","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-09-10T16:32:59Z","receivedAt":"2010-09-10T16:32:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mark Lodato writes:\n\n> In git-config(1), diff.noprefix was placed in between\n> diff.mnemonicprefix and the list of mnemonic prefixes, which is\n> obviously incorrect and very confusing to readers. Now, it is located\n> after the end of the explanation of mnemonicprefix, which makes much\n> more sense.\n>\n> Signed-off-by: Mark Lodato \n> ---\n> Documentation/config.txt | 5 +++--\n> 1 files changed, 3 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/config.txt b/Documentation/config.txt\n> index d294dd6..d82c0da 100644\n> --- a/Documentation/config.txt\n> +++ b/Documentation/config.txt\n> @@ -813,8 +813,6 @@ diff.mnemonicprefix::\n> \tstandard \"a/\" and \"b/\" depending on what is being compared. When\n> \tthis configuration is in effect, reverse diff output also swaps\n> \tthe order of the prefixes:\n> -diff.noprefix::\n> -\tIf set, 'git diff' does not show any source or destination prefix.\n> `git diff`;;\n> \tcompares the (i)ndex and the (w)ork tree;\n> `git diff HEAD`;;\n> @@ -826,6 +824,9 @@ diff.noprefix::\n> `git diff --no-index a b`;;\n> \tcompares two non-git things (1) and (2).\n> \n> +diff.noprefix::\n> +\tIf set, 'git diff' does not show any source or destination prefix.\n> +\n> diff.renameLimit::\n> \tThe number of files to consider when performing the copy/rename\n> \tdetection; equivalent to the 'git diff' option '-l'.\n\nGood eyes, thanks. How did that happen I wonder...\n"},{"id":"150453","messageId":"AANLkTimpSPkA+=CHw2QqA17HkAdjB1Zd3tsGAWQ3-HiY@mail.gmail.com","threadId":"25062","inReplyTo":"7vvd6dh83o.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] config.txt: fix placement of diff.noprefix","fromName":"Eli Collins","fromEmail":"eli@cloudera.com","sentAt":"2010-09-10T16:46:44Z","receivedAt":"2010-09-10T16:46:44Z","isPatch":true,"sender":{"key":"eli@cloudera.com","avatar":"https://avatars.githubusercontent.com/u/131502?v=4"},"body":"Good find. Apologies, looks like that was an issue with the original patch.\n\nOn Fri, Sep 10, 2010 at 9:32 AM, Junio C Hamano wrote:\n> Mark Lodato writes:\n>\n>> In git-config(1), diff.noprefix was placed in between\n>> diff.mnemonicprefix and the list of mnemonic prefixes, which is\n>> obviously incorrect and very confusing to readers.  Now, it is located\n>> after the end of the explanation of mnemonicprefix, which makes much\n>> more sense.\n>>\n>> Signed-off-by: Mark Lodato \n>> ---\n>>  Documentation/config.txt |    5 +++--\n>>  1 files changed, 3 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/Documentation/config.txt b/Documentation/config.txt\n>> index d294dd6..d82c0da 100644\n>> --- a/Documentation/config.txt\n>> +++ b/Documentation/config.txt\n>> @@ -813,8 +813,6 @@ diff.mnemonicprefix::\n>>       standard \"a/\" and \"b/\" depending on what is being compared.  When\n>>       this configuration is in effect, reverse diff output also swaps\n>>       the order of the prefixes:\n>> -diff.noprefix::\n>> -     If set, 'git diff' does not show any source or destination prefix.\n>>  `git diff`;;\n>>       compares the (i)ndex and the (w)ork tree;\n>>  `git diff HEAD`;;\n>> @@ -826,6 +824,9 @@ diff.noprefix::\n>>  `git diff --no-index a b`;;\n>>       compares two non-git things (1) and (2).\n>>\n>> +diff.noprefix::\n>> +     If set, 'git diff' does not show any source or destination prefix.\n>> +\n>>  diff.renameLimit::\n>>       The number of files to consider when performing the copy/rename\n>>       detection; equivalent to the 'git diff' option '-l'.\n>\n> Good eyes, thanks.  How did that happen I wonder...\n>\n"}]}