{"thread":{"id":"25022","subject":"Re: [PATCH 00/20] *** SUBJECT HERE ***","startedAt":"2010-09-07T16:43:03Z","lastAt":"2010-09-07T16:44:52Z","messageCount":2,"participants":["Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":20},"messages":[{"id":"150218","messageId":"1283877803-17757-1-git-send-email-avarab@gmail.com","threadId":"25022","inReplyTo":null,"subject":"[PATCH 00/20] *** SUBJECT HERE ***","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-09-07T16:43:03Z","receivedAt":"2010-09-07T16:43:03Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"This series continues work where the already pulled ab/i18n series\n(now merged to pu) left off.\n\nIt can also be pulled from:\n\n    git://github.com/avar/git.git ab/i18n-continue\n    http://github.com/avar/git/compare/ab/i18n-in-git-2010-09-07...ab/i18n-continue\n    http://github.com/avar/git/compare/ab/i18n-in-git-2010-09-07...ab/i18n-continue.patch\n\nIt includes the first translation of a mainporcelain command written\nin shellscript (git-am). Comments on invividual patches below.\n\nÆvar Arnfjörð Bjarmason (20):\n  gettextize: git-clean clean.requireForce braces\n  gettextize: git-clone \"Cloning into\" message braces\n\nUnder GCC this warns under -Wall and will presumably break Junio's\n-Werror build. I didn't notice because I use clang which (IMO rightly)\ndoesn't complain about this.\n\n  po/de.po: make the German translation msgfmt --check clean\n\nWe'll see what ze Germans come up with translation wise, but meanwhile\nthis un-breaks the translation already in ab/i18n.\n\n  Makefile: add GNU_GETTEXT, set when we expect GNU gettext\n  Makefile: MSGFMT=\"msgfmt --check\" under GNU_GETTEXT\n\nAnd these two patches make sure that a translation will never break\nlike that again. Since msgfmt --check is a GNU-ism I needed to add\nsupport for GNU_GETTEXT=YesPlease in the Makefile.\n\nMaybe a check for this could be added to the configure.ac script, but\nI couldn't find a way to do so, and for the reasons explained in the\npatches I don't think it was worth my time.\n\n  Revert \"gettextize: git-revert mark the \"me\" variable for\n    translation\"\n\nRevert this as discussion on-list. Alternatively the \"gettextize:\ngit-revert mark the \"me\" variable for translation\" patch could be\nejected from the existing ab/i18n series.\n\n  gettextize: git-revert \"Your local changes\" message\n  gettextize: git-revert literal \"me\" messages\n\nDo The Right Thing when translating the \"me\" messsages.\n\n  gettext: add GETTEXT_POISON support for shell scripts\n  gettext: add GETTEXT_POISON tests for shell scripts\n\nWe need poison for .sh too to ensure sanity.\n\n  gettextize: git-am add git-sh-i18n\n  gettextize: git-am one-line gettext $msg; echo\n  gettextize: git-am multi-line getttext $msg; echo\n  gettextize: git-am eval_gettext messages\n  gettextize: git-am die messages\n  gettextize: git-am cannot_fallback messages\n\nNote: Isn't --check clean because the existing code indented with\nspaces.\n\n  gettextize: git-am clean_abort messages\n  gettextize: git-am \"Apply?\" message\n  gettextize: git-am core say messages\n  gettextize: git-am printf(1) message to eval_gettext\n\nAll these git-am patches are split up like this to make it easier to\nreview them, and to demonstrate the different sort of messages we'll\nhave to translate in the shell scripts.\n\nI won't sent commits quite so granular in the future (unless\nrequested).\n\n Makefile                     |   16 +++++++++\n builtin/clean.c              |    3 +-\n builtin/clone.c              |    3 +-\n builtin/revert.c             |   32 +++++++++++------\n git-am.sh                    |   68 +++++++++++++++++++-----------------\n git-sh-i18n.sh               |   77 +++++++++++++++++++++++++----------------\n po/de.po                     |   11 +++---\n t/t0201-gettext-fallbacks.sh |   12 +++---\n t/t0201-gettext-poison.sh    |   36 +++++++++++++++++++\n t/t4150-am.sh                |    4 ++-\n t/t4151-am-abort.sh          |    2 +-\n t/test-lib.sh                |    9 ++++-\n 12 files changed, 184 insertions(+), 89 deletions(-)\n create mode 100755 t/t0201-gettext-poison.sh\n\n-- \n1.7.2.3.313.gcd15\n"},{"id":"150217","messageId":"AANLkTimgjFnMd1NFcWBbM3NWVo+1FMGs1xW0n1-wbSq8@mail.gmail.com","threadId":"25022","inReplyTo":"1283877803-17757-1-git-send-email-avarab@gmail.com","subject":"Re: [PATCH 00/20] *** SUBJECT HERE ***","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-09-07T16:44:52Z","receivedAt":"2010-09-07T16:44:52Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Sorry, nevermind this. Wrong series. Right one coming up...\n"}]}