{"thread":{"id":"2499","subject":"eth","startedAt":"2005-11-14T16:40:47Z","lastAt":"2005-11-15T05:10:41Z","messageCount":8,"participants":["Kevin Geiss","Junio C Hamano","Martin Langhoff"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"11805","messageId":"20051114164047.GB9131@raven.localdomain","threadId":"2499","inReplyTo":null,"subject":"eth","fromName":"Kevin Geiss","fromEmail":"kevin@desertsol.com","sentAt":"2005-11-14T16:40:47Z","receivedAt":"2005-11-14T16:40:47Z","isPatch":false,"sender":{"key":"kevin@desertsol.com","avatar":null},"body":"---\n\n git-cvsexportcommit.perl | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\napplies-to: e604d20cd75e71750e8316348c988ef0296b3ec5\n224d4f4897ea47425aafc6d491f2a0762e683a4c\ndiff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl\nindex 50b041c..5bce39c 100755\n--- a/git-cvsexportcommit.perl\n+++ b/git-cvsexportcommit.perl\n@@ -4,6 +4,7 @@ use strict;\n use Getopt::Std;\n use File::Temp qw(tempdir);\n use Data::Dumper;\n+use File::Basename qw(basename);\n \n unless ($ENV{GIT_DIR} && -r $ENV{GIT_DIR}){\n die \"GIT_DIR is not defined or is unreadable\";\n@@ -206,8 +207,7 @@ if ($opt_c) {\n }\n sub usage {\n \tprint STDERR < writes:\n\n> sub usage {\n> \tprint STDERR < -Usage: GIT_DIR=/path/to/.gi ${\\basename $0} # fetch/update GIT from CVS\n> - [-h] [-p] [ parent ] commit\n> +Usage: GIT_DIR=/path/to/.git ${\\basename $0} [-h] [-p] [-v] [-c] [ parent ] commit\n> END\n> \texit(1);\n> }\n\nI hate to be nitpicky, but this slurps in File::Basename\n(9Kbytes) only to shorten the displayed command name.\n\nI personally do not like programs that shorten $0 (or in C\nargv[0]) when they identify themselves. This is probably just\nme, but I was bitten by such programs too many times while\ndebugging them, after wasting too many hours only to find that I\nwas not running the executable I thought I was running but\nsomething else that happened to be earlier on my PATH X-<.\n"},{"id":"11848","messageId":"46a038f90511141420u11e396d3q9a6710c79abe0ca3@mail.gmail.com","threadId":"2499","inReplyTo":"7vbr0mx4fj.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 1/1] git-cvsexportcommit.perl: Fix usage() output.","fromName":"Martin Langhoff","fromEmail":"martin.langhoff@gmail.com","sentAt":"2005-11-14T22:20:59Z","receivedAt":"2005-11-14T22:20:59Z","isPatch":true,"sender":{"key":"martin.langhoff@gmail.com","avatar":"https://gravatar.com/avatar/1e3f311b6c4c15836501901ca58f8c0b0667246488084ba524d8bc9867e22fd9?d=mp&s=160"},"body":"On 11/15/05, Junio C Hamano wrote:\n> I hate to be nitpicky, but this slurps in File::Basename\n> (9Kbytes) only to shorten the displayed command name.\n\nFair enough -- I'll leave that one up to you. I'm happy with Kevin's\npatches -- what's the ideal workflow for this? Is the sign-off line\nimportant enough that I should setup a public repo for you to pull\nfrom?\n\nBTW, File::Basename is a standard library usually installed w perl -- \nit shouldn't add any painful dependencies. Not sure if that matters.\n\n\nmartin\n"},{"id":"11853","messageId":"7vsltyvnjf.fsf@assigned-by-dhcp.cox.net","threadId":"2499","inReplyTo":"46a038f90511141420u11e396d3q9a6710c79abe0ca3@mail.gmail.com","subject":"Re: [PATCH 1/1] git-cvsexportcommit.perl: Fix usage() output.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-11-14T23:04:52Z","receivedAt":"2005-11-14T23:04:52Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Martin Langhoff writes:\n\n> ... I'm happy with Kevin's patches -- what's the ideal\n> workflow for this? Is the sign-off line important enough that\n> I should setup a public repo for you to pull from?\n\nGiven that you are far more familiar with that part of the code,\nand I suspect I'd be asking your help in archimport as well, a\nrepo I can pull from would be more preferable (and sign-off by\nyou is certainly an added bonus). If a public repo is too much\nhassle, however, e-mail forwarding is perfectly fine as well.\nYour choice.\n\nBTW, there is no \"mana\" points involved in deciding if I\ndirectly pull from somewhere. Even if that were the case, you\nhave accumulated enough of them already ;-).\n\n> BTW, File::Basename is a standard library usually installed w perl -- \n> it shouldn't add any painful dependencies. Not sure if that matters.\n\nAlthough some might find \"${\\function}\" expansion too cute for\ntheir taste, Keven's code is fine as-is for me. I launched the\nbaloon just wanting to see what others have to say ;-).\n"},{"id":"11867","messageId":"46a038f90511142110x3aa22882j768f33ec1a882dab@mail.gmail.com","threadId":"2499","inReplyTo":"7vsltyvnjf.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 1/1] git-cvsexportcommit.perl: Fix usage() output.","fromName":"Martin Langhoff","fromEmail":"martin.langhoff@gmail.com","sentAt":"2005-11-15T05:10:41Z","receivedAt":"2005-11-15T05:10:41Z","isPatch":true,"sender":{"key":"martin.langhoff@gmail.com","avatar":"https://gravatar.com/avatar/1e3f311b6c4c15836501901ca58f8c0b0667246488084ba524d8bc9867e22fd9?d=mp&s=160"},"body":"On 11/15/05, Junio C Hamano wrote:\n> Given that you are far more familiar with that part of the code,\n> and I suspect I'd be asking your help in archimport as well, a\n> repo I can pull from would be more preferable (and sign-off by\n> you is certainly an added bonus). If a public repo is too much\n> hassle, however, e-mail forwarding is perfectly fine as well.\n> Your choice.\n\nIt is _easy_. I've setup a server for git-related paraphernalia at\nwork already ;)\n\nThe URL is:\n http://locke.catalyst.net.nz/git/git-martinlanghoff.git/#tojunio\n\ngitweb at:\n http://locke.catalyst.net.nz/gitweb?p=git-martinlanghoff.git;a=summary\n\nThat gitweb has per-branch RSS feeds, if you are an rss junkio ;-) you\ncan just subscribe to it...\n\nA word of warning, though: those branches rewind/rebase often, and I\nwon't apologise about it. You should be able to just delete your\n'martinlanghoff' head and refetch it. Anyone else reading this... just\n_don't_ base your work on my branch as it's bound to break.\n\n> BTW, there is no \"mana\" points involved in deciding if I\n> directly pull from somewhere. Even if that were the case, you\n> have accumulated enough of them already ;-).\n\n:-)\n\n/me is happy that you've forgotten about my brown-paper-bag patch with\na random character in the middle!\n\n> Although some might find \"${\\function}\" expansion too cute for\n> their taste, Keven's code is fine as-is for me. I launched the\n> baloon just wanting to see what others have to say ;-).\n\nFine w me -- TIMTOWDI. I do understand, however, your interest in\nhaving full paths in the usage line to make debugging easier. Whatever\nis consistent with the project in general.\n\ncheers,\n\n\nmartin\n"}]}