{"thread":{"id":"24976","subject":"inaccurate commit message message?","startedAt":"2010-09-04T21:37:35Z","lastAt":"2010-09-04T23:07:52Z","messageCount":4,"participants":["Ramana Kumar","Sverre Rabbelier"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"149874","messageId":"AANLkTinbq8z-ygVUWPRq9PA95-+8O8SwOJCLkfMKCg9T@mail.gmail.com","threadId":"24976","inReplyTo":null,"subject":"inaccurate commit message message?","fromName":"Ramana Kumar","fromEmail":"ramana.kumar@gmail.com","sentAt":"2010-09-04T21:37:35Z","receivedAt":"2010-09-04T21:37:35Z","isPatch":false,"sender":{"key":"ramana.kumar@gmail.com","avatar":"https://gravatar.com/avatar/c1e354b4b3844c33709698d3c6491eb791f04384343001b78b4816b6ba3fa8a9?d=mp&s=160"},"body":"The commit message message says \"Lines starting with '#' will be\nignored\", but fails to say \"Lines below this message will be ignored,\neven if they don't start with '#'\".\nIf the second sentence is true, I think it (or something equivalent)\nshould be said, especially because of the relevance during commit\n--verbose.\n\nIn fact the documentation for commit --verbose explicitly says to note\nthat the diff lines won't start with '#'s, as if warning people that\nthose lines might show up in the commit message.\nYet they do not seem to show up... (and I don't think they should)\n"},{"id":"149878","messageId":"AANLkTinGNss5siAjpic07OB036y8K0kvBjSj=unDhQWs@mail.gmail.com","threadId":"24976","inReplyTo":"AANLkTinbq8z-ygVUWPRq9PA95-+8O8SwOJCLkfMKCg9T@mail.gmail.com","subject":"Re: inaccurate commit message message?","fromName":"Sverre Rabbelier","fromEmail":"srabbelier@gmail.com","sentAt":"2010-09-04T21:55:44Z","receivedAt":"2010-09-04T21:55:44Z","isPatch":false,"sender":{"key":"srabbelier@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3098?v=4"},"body":"Heya,\n\nOn Sat, Sep 4, 2010 at 16:37, Ramana Kumar wrote:\n> The commit message message says \"Lines starting with '#' will be\n> ignored\", but fails to say \"Lines below this message will be ignored,\n> even if they don't start with '#'\".\n\nBecause they're not. Only those starting with # are ignored.\n\n> If the second sentence is true, I think it (or something equivalent)\n> should be said, especially because of the relevance during commit\n> --verbose.\n\nIt is not true.\n\n> In fact the documentation for commit --verbose explicitly says to note\n> that the diff lines won't start with '#'s, as if warning people that\n> those lines might show up in the commit message.\n> Yet they do not seem to show up... (and I don't think they should)\n\nAh, you are apparently talking about 'git commit --verbose'. It works\na little different there, all lines starting with # are ignored, as\nwell as everything in and after the diff.\n\n-- \nCheers,\n\nSverre Rabbelier\n"},{"id":"149897","messageId":"AANLkTi=Vb2cQHPo388m9HYVdYkk3XC_-pM9bm182PWyf@mail.gmail.com","threadId":"24976","inReplyTo":"AANLkTinGNss5siAjpic07OB036y8K0kvBjSj=unDhQWs@mail.gmail.com","subject":"Re: inaccurate commit message message?","fromName":"Ramana Kumar","fromEmail":"ramana.kumar@gmail.com","sentAt":"2010-09-04T22:55:49Z","receivedAt":"2010-09-04T22:55:49Z","isPatch":false,"sender":{"key":"ramana.kumar@gmail.com","avatar":"https://gravatar.com/avatar/c1e354b4b3844c33709698d3c6491eb791f04384343001b78b4816b6ba3fa8a9?d=mp&s=160"},"body":"On Sun, Sep 5, 2010 at 7:55 AM, Sverre Rabbelier wrote:\n> Heya,\n>\n> On Sat, Sep 4, 2010 at 16:37, Ramana Kumar wrote:\n>> The commit message message says \"Lines starting with '#' will be\n>> ignored\", but fails to say \"Lines below this message will be ignored,\n>> even if they don't start with '#'\".\n>\n> Because they're not. Only those starting with # are ignored.\n>\n>> If the second sentence is true, I think it (or something equivalent)\n>> should be said, especially because of the relevance during commit\n>> --verbose.\n>\n> It is not true.\n>\n>> In fact the documentation for commit --verbose explicitly says to note\n>> that the diff lines won't start with '#'s, as if warning people that\n>> those lines might show up in the commit message.\n>> Yet they do not seem to show up... (and I don't think they should)\n>\n> Ah, you are apparently talking about 'git commit --verbose'. It works\n> a little different there, all lines starting with # are ignored, as\n> well as everything in and after the diff.\n\nThe documentation, both in man git-commit and in the commit message\nmessage, is misleading when you do git commit --verbose.\nMy proposal is to make it less misleading, by saying in at least one,\nand ideally both, of those places what you just told me for the first\ntime: when you do a git commit --verbose, the diff lines and\neverything after will be ignored for the commit message.\n\n>\n> --\n> Cheers,\n>\n> Sverre Rabbelier\n>\n"},{"id":"149898","messageId":"AANLkTi=eK4qt7KLg7z-3vqV+hgUoW_xire6WftBJAYku@mail.gmail.com","threadId":"24976","inReplyTo":"AANLkTi=Vb2cQHPo388m9HYVdYkk3XC_-pM9bm182PWyf@mail.gmail.com","subject":"Re: inaccurate commit message message?","fromName":"Sverre Rabbelier","fromEmail":"srabbelier@gmail.com","sentAt":"2010-09-04T23:07:52Z","receivedAt":"2010-09-04T23:07:52Z","isPatch":false,"sender":{"key":"srabbelier@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3098?v=4"},"body":"Heya,\n\nOn Sat, Sep 4, 2010 at 17:55, Ramana Kumar wrote:\n> The documentation, both in man git-commit and in the commit message\n> message, is misleading when you do git commit --verbose.\n\nCorrect.\n\n> My proposal is to make it less misleading, by saying in at least one,\n> and ideally both, of those places what you just told me for the first\n> time: when you do a git commit --verbose, the diff lines and\n> everything after will be ignored for the commit message.\n\nSounds like a good idea. See builtin/commit.c around line 660. You'll\nwant to check for the verbose flag and adjust the message printed\nthere accordingly. See Documentation/SubmittingPatches.txt on how to\nsubmit patches.\n\nPlease do ask if you have any questions, I'd be glad to help.\n\n-- \nCheers,\n\nSverre Rabbelier\n"}]}