{"thread":{"id":"24889","subject":"[PATCH] gitweb: Don’t die_error in git_tag after already printing headers","startedAt":"2010-08-27T17:38:16Z","lastAt":"2010-08-31T16:19:35Z","messageCount":2,"participants":["Anders Kaseorg","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"149135","messageId":"alpine.DEB.2.00.1008271337310.25632@dr-wily.mit.edu","threadId":"24889","inReplyTo":null,"subject":"[PATCH] gitweb: Don’t die_error in git_tag after already printing headers","fromName":"Anders Kaseorg","fromEmail":"andersk@mit.edu","sentAt":"2010-08-27T17:38:16Z","receivedAt":"2010-08-27T17:38:16Z","isPatch":true,"sender":{"key":"andersk@mit.edu","avatar":"https://avatars.githubusercontent.com/u/26471?v=4"},"body":"This fixes an XML error when visiting a nonexistent tag\n(?p=git.git;a=tag;h=refs/tags/BADNAME).\n\nSigned-off-by: Anders Kaseorg <andersk@mit.edu>\n---\n gitweb/gitweb.perl |    6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 84261bb..5dab825 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -5192,15 +5192,15 @@ sub git_summary {\n }\n \n sub git_tag {\n-\tmy $head = git_get_head_hash($project);\n-\tgit_header_html();\n-\tgit_print_page_nav('','', $head,undef,$head);\n \tmy %tag = parse_tag($hash);\n \n \tif (! %tag) {\n \t\tdie_error(404, \"Unknown tag object\");\n \t}\n \n+\tmy $head = git_get_head_hash($project);\n+\tgit_header_html();\n+\tgit_print_page_nav('','', $head,undef,$head);\n \tgit_print_header_div('commit', esc_html($tag{'name'}), $hash);\n \tprint \"<div class=\\\"title_text\\\">\\n\" .\n \t      \"<table class=\\\"object_header\\\">\\n\" .\n-- \n1.7.2.2\n"},{"id":"149448","messageId":"m37hj6oivq.fsf@localhost.localdomain","threadId":"24889","inReplyTo":"alpine.DEB.2.00.1008271337310.25632@dr-wily.mit.edu","subject":"Re: [PATCH] gitweb: Don’t die_error in git_tag after already printing headers","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-08-31T16:19:35Z","receivedAt":"2010-08-31T16:19:35Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Anders Kaseorg <andersk@MIT.EDU> writes:\n\n> This fixes an XML error when visiting a nonexistent tag\n> (?p=git.git;a=tag;h=refs/tags/BADNAME).\n> \n> Signed-off-by: Anders Kaseorg <andersk@mit.edu>\n\nGood catch!\n\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n\n> ---\n>  gitweb/gitweb.perl |    6 +++---\n>  1 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 84261bb..5dab825 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -5192,15 +5192,15 @@ sub git_summary {\n>  }\n>  \n>  sub git_tag {\n> -\tmy $head = git_get_head_hash($project);\n> -\tgit_header_html();\n> -\tgit_print_page_nav('','', $head,undef,$head);\n>  \tmy %tag = parse_tag($hash);\n>  \n>  \tif (! %tag) {\n>  \t\tdie_error(404, \"Unknown tag object\");\n>  \t}\n>  \n> +\tmy $head = git_get_head_hash($project);\n> +\tgit_header_html();\n> +\tgit_print_page_nav('','', $head,undef,$head);\n>  \tgit_print_header_div('commit', esc_html($tag{'name'}), $hash);\n>  \tprint \"<div class=\\\"title_text\\\">\\n\" .\n>  \t      \"<table class=\\\"object_header\\\">\\n\" .\n> -- \n> 1.7.2.2\n> \n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"}]}