{"thread":{"id":"24793","subject":"t9155 fails since \"git-svn: fix fetch with deleted tag\" with svn < 1.5","startedAt":"2010-08-19T16:57:24Z","lastAt":"2010-08-23T16:22:59Z","messageCount":7,"participants":["Jens Lehmann","Ævar Arnfjörð Bjarmason","Eric Wong","David D. Kilzer"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"148470","messageId":"4C6D6274.90009@web.de","threadId":"24793","inReplyTo":null,"subject":"t9155 fails since \"git-svn: fix fetch with deleted tag\" with svn < 1.5","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2010-08-19T16:57:24Z","receivedAt":"2010-08-19T16:57:24Z","isPatch":false,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"t9155 fails on current next when running the testsuite on a Fedora\nCore 7 system. The reason is that FC7 comes with svn 1.4.4, while\nin commit 3235b70 the --parents option was introduced into t9155\nwhich was added in svn 1.5.\n\nWhat minimum svn version is required for git svn? I didn't find any\ninformation about that, but I might have overlooked something ...\n"},{"id":"148471","messageId":"AANLkTiky8qn_PSgXSn=0h07cb4VmCFiFXmD9WrpO1z6z@mail.gmail.com","threadId":"24793","inReplyTo":"4C6D6274.90009@web.de","subject":"Re: t9155 fails since \"git-svn: fix fetch with deleted tag\" with svn < 1.5","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-08-19T17:21:25Z","receivedAt":"2010-08-19T17:21:25Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Thu, Aug 19, 2010 at 16:57, Jens Lehmann wrote:\n> t9155 fails on current next when running the testsuite on a Fedora\n> Core 7 system. The reason is that FC7 comes with svn 1.4.4, while\n> in commit 3235b70 the --parents option was introduced into t9155\n> which was added in svn 1.5.\n>\n> What minimum svn version is required for git svn? I didn't find any\n> information about that, but I might have overlooked something ...\n\nWe currently require >= 1.1.0 of SVN::Core for the git-svn tests at least.\n"},{"id":"148475","messageId":"20100819191425.GA1543@dcvr.yhbt.net","threadId":"24793","inReplyTo":"AANLkTiky8qn_PSgXSn=0h07cb4VmCFiFXmD9WrpO1z6z@mail.gmail.com","subject":"Re: t9155 fails since \"git-svn: fix fetch with deleted tag\" with svn < 1.5","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2010-08-19T19:14:25Z","receivedAt":"2010-08-19T19:14:25Z","isPatch":false,"sender":{"key":"e@80x24.org","avatar":null},"body":"Ævar Arnfjörð Bjarmason wrote:\n> On Thu, Aug 19, 2010 at 16:57, Jens Lehmann wrote:\n> > t9155 fails on current next when running the testsuite on a Fedora\n> > Core 7 system. The reason is that FC7 comes with svn 1.4.4, while\n> > in commit 3235b70 the --parents option was introduced into t9155\n> > which was added in svn 1.5.\n\nThe --parents option appears completely unnecessary in this case,\nso removing it should be safe. Patch coming...\n\n> > What minimum svn version is required for git svn? I didn't find any\n> > information about that, but I might have overlooked something ...\n> \n> We currently require >= 1.1.0 of SVN::Core for the git-svn tests at least.\n\nThat's still the only hard requirement I know of. While I haven't had a\n1.1.x installation in years, reports of incompatibility have been few.\nSo either people find it easier to upgrade to newer versions of SVN,\ndon't care, or there just aren't that many incompatibilities.\n\nI'd say we will continue to do our best to support whatever versions\npeople care to report (preferably with patches :) incompatibilities for.\n\n-- \nEric Wong\n"},{"id":"148476","messageId":"20100819191552.GB1543@dcvr.yhbt.net","threadId":"24793","inReplyTo":"20100819191425.GA1543@dcvr.yhbt.net","subject":"[PATCH] t9155: fix compatibility with older SVN","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2010-08-19T19:15:52Z","receivedAt":"2010-08-19T19:15:52Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"The \"--parents\" option did not appear until SVN 1.5.x\nand is completely unnecessary in this case.\n\nReported-by: Jens Lehmann \nSigned-off-by: Eric Wong \n---\n\n Also pushed up to git://git.bogomips.org/git-svn\n\n t/t9155-git-svn-fetch-deleted-tag.sh | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t9155-git-svn-fetch-deleted-tag.sh b/t/t9155-git-svn-fetch-deleted-tag.sh\nindex ef0ac87..a486a98 100755\n--- a/t/t9155-git-svn-fetch-deleted-tag.sh\n+++ b/t/t9155-git-svn-fetch-deleted-tag.sh\n@@ -12,7 +12,7 @@ test_expect_success 'setup svn repo' '\n \tsvn_cmd import -m \"import for git svn\" import \"$svnrepo\" &&\n \trm -rf import &&\n \n-\tsvn_cmd mkdir --parents -m \"create mybranch directory\" \"$svnrepo/branches/mybranch\" &&\n+\tsvn_cmd mkdir -m \"create mybranch directory\" \"$svnrepo/branches/mybranch\" &&\n \tsvn_cmd cp -m \"create branch mybranch\" \"$svnrepo/trunk\" \"$svnrepo/branches/mybranch/trunk\" &&\n \n \tsvn_cmd co \"$svnrepo/trunk\" svn_project &&\n-- \nEric Wong\n"},{"id":"148477","messageId":"56635.12651.qm@web30008.mail.mud.yahoo.com","threadId":"24793","inReplyTo":"20100819191552.GB1543@dcvr.yhbt.net","subject":"Re: [PATCH] t9155: fix compatibility with older SVN","fromName":"David D. Kilzer","fromEmail":"ddkilzer@kilzer.net","sentAt":"2010-08-19T19:39:07Z","receivedAt":"2010-08-19T19:39:07Z","isPatch":true,"sender":{"key":"ddkilzer@kilzer.net","avatar":"https://avatars.githubusercontent.com/u/263571?v=4"},"body":"On Thu, August 19, 2010 at 12:15:52 PM, Eric Wong wrote:\n\n\n> The \"--parents\" option did not appear until SVN 1.5.x\n> and is completely unnecessary in this case.\n\n\nAt one point in development, I wasn't creating the branches directory on the \ninitial import, which is why this was added. Thanks for fixing this!\n\n> Reported-by: Jens Lehmann \n> Signed-off-by: Eric Wong \n\n\nAck.\n\nDave\n"},{"id":"148478","messageId":"4C6D8898.1040907@web.de","threadId":"24793","inReplyTo":"20100819191552.GB1543@dcvr.yhbt.net","subject":"Re: [PATCH] t9155: fix compatibility with older SVN","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2010-08-19T19:40:08Z","receivedAt":"2010-08-19T19:40:08Z","isPatch":true,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"Am 19.08.2010 21:15, schrieb Eric Wong:\n> The \"--parents\" option did not appear until SVN 1.5.x\n> and is completely unnecessary in this case.\n\nThanks for the quick response! I'll test this patch on Monday when\nI have access to that FC7 machine again.\n"},{"id":"148759","messageId":"4C72A063.3010003@web.de","threadId":"24793","inReplyTo":"4C6D8898.1040907@web.de","subject":"Re: [PATCH] t9155: fix compatibility with older SVN","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2010-08-23T16:22:59Z","receivedAt":"2010-08-23T16:22:59Z","isPatch":true,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"Am 19.08.2010 21:40, schrieb Jens Lehmann:\n> Am 19.08.2010 21:15, schrieb Eric Wong:\n>> The \"--parents\" option did not appear until SVN 1.5.x\n>> and is completely unnecessary in this case.\n> \n> Thanks for the quick response! I'll test this patch on Monday when\n> I have access to that FC7 machine again.\n\nJust for the record:\n\nTested-By: Jens Lehmann \n"}]}