{"thread":{"id":"24748","subject":"[PATCH 1/2] git-svn: fix regex to remove \"tail\" from svn tags","startedAt":"2010-08-15T13:15:54Z","lastAt":"2010-08-15T23:48:33Z","messageCount":2,"participants":["David D. Kilzer","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"148137","messageId":"1281878155-61937-1-git-send-email-ddkilzer@kilzer.net","threadId":"24748","inReplyTo":null,"subject":"[PATCH 1/2] git-svn: fix regex to remove \"tail\" from svn tags","fromName":"David D. Kilzer","fromEmail":"ddkilzer@kilzer.net","sentAt":"2010-08-15T13:15:54Z","receivedAt":"2010-08-15T13:15:54Z","isPatch":true,"sender":{"key":"ddkilzer@kilzer.net","avatar":"https://avatars.githubusercontent.com/u/263571?v=4"},"body":"Fix a regular expression used to remove the revision from the\nend of an svn tag or branch name.  The regex did not account for\nany \"tail\" (dashes) that may have been added to the end of the\ntag name (which first appeared in v1.4.1-rc2~11).  If not fixed,\ntags with names like \"tags/mytag@5--@2\" may be created.\n\nSigned-off-by: David D. Kilzer <ddkilzer@kilzer.net>\n---\n git-svn.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 34884b8..39bcb45 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -2959,7 +2959,7 @@ sub other_gs {\n \tmy $gs = Git::SVN->find_by_url($new_url, $url, $branch_from);\n \tunless ($gs) {\n \t\tmy $ref_id = $old_ref_id;\n-\t\t$ref_id =~ s/\\@\\d+$//;\n+\t\t$ref_id =~ s/\\@\\d+-*$//;\n \t\t$ref_id .= \"\\@$r\";\n \t\t# just grow a tail if we're not unique enough :x\n \t\t$ref_id .= '-' while find_ref($ref_id);\n-- \n1.7.2.1.49.g98551\n"},{"id":"148158","messageId":"20100815234833.GA4359@dcvr.yhbt.net","threadId":"24748","inReplyTo":"1281878155-61937-1-git-send-email-ddkilzer@kilzer.net","subject":"Re: [PATCH 1/2] git-svn: fix regex to remove \"tail\" from svn tags","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2010-08-15T23:48:33Z","receivedAt":"2010-08-15T23:48:33Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"\"David D. Kilzer\" <ddkilzer@kilzer.net> wrote:\n> Signed-off-by: David D. Kilzer <ddkilzer@kilzer.net>\n\nThank you David,\n\nI've acked and pushed out both patches to git://git.bogomips.org/git-svn\nfor Junio\n\nDavid D. Kilzer (2):\n      git-svn: fix regex to remove \"tail\" from svn tags\n      git-svn: fix fetch with deleted tag\n\n-- \nEric Wong\n"}]}