{"thread":{"id":"24734","subject":"[PATCH] Do not build i18n on Windows.","startedAt":"2010-08-13T22:02:40Z","lastAt":"2010-08-14T08:24:41Z","messageCount":3,"participants":["Johannes Sixt","Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"148045","messageId":"201008140002.40587.j6t@kdbg.org","threadId":"24734","inReplyTo":null,"subject":"[PATCH] Do not build i18n on Windows.","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2010-08-13T22:02:40Z","receivedAt":"2010-08-13T22:02:40Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"We do not have the necessary libraries and tools.\n\nSigned-off-by: Johannes Sixt \n---\n It is necessary to move the first check for NO_GETTEXT after the\n configuration section.\n\n NEEDS_LIBINTL receives a default setting before the configuration\n section (not visible in the patch text), hence, I have to unset it\n when NO_GETTEXT is set. Perhaps you have a better idea to arrange\n these settings.\n\n -- Hannes\n\n Makefile | 8 +++++---\n 1 files changed, 5 insertions(+), 3 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex cdb8222..48cf304 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -598,9 +598,6 @@ LIB_OBJS += entry.o\n LIB_OBJS += environment.o\n LIB_OBJS += exec_cmd.o\n LIB_OBJS += fsck.o\n-ifndef NO_GETTEXT\n-LIB_OBJS += gettext.o\n-endif\n LIB_OBJS += graph.o\n LIB_OBJS += grep.o\n LIB_OBJS += hash.o\n@@ -1100,6 +1097,7 @@ ifeq ($(uname_S),Windows)\n \tNO_PYTHON = YesPlease\n \tBLK_SHA1 = YesPlease\n \tNATIVE_CRLF = YesPlease\n+\tNO_GETTEXT = YesPlease\n \n \tCC = compat/vcbuild/scripts/clink.pl\n \tAR = compat/vcbuild/scripts/lib.pl\n@@ -1150,6 +1148,7 @@ ifneq (,$(findstring MINGW,$(uname_S)))\n \tNO_REGEX = YesPlease\n \tNO_PYTHON = YesPlease\n \tBLK_SHA1 = YesPlease\n+\tNO_GETTEXT = YesPlease\n \tCOMPAT_CFLAGS \n+= -D__USE_MINGW_ACCESS -DNOGDI -Icompat -Icompat/fnmatch -Icompat/win32\n \tCOMPAT_CFLAGS += -DSTRIP_EXTENSION=\\\".exe\\\"\n \tCOMPAT_OBJS += compat/mingw.o compat/fnmatch/fnmatch.o compat/winansi.o \\\n@@ -1499,6 +1498,9 @@ endif\n \n ifdef NO_GETTEXT\n \tCOMPAT_CFLAGS += -DNO_GETTEXT\n+\tNEEDS_LIBINTL =\n+else\n+\tLIB_OBJS += gettext.o\n endif\n \n ifdef NEEDS_LIBINTL\n-- \n1.7.1.402.gf1eeb\n"},{"id":"148047","messageId":"AANLkTiku5R+idX-C8f0AcCikBLmfEb5ZEhdft+CSRzU0@mail.gmail.com","threadId":"24734","inReplyTo":"201008140002.40587.j6t@kdbg.org","subject":"Re: [PATCH] Do not build i18n on Windows.","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-08-13T22:19:34Z","receivedAt":"2010-08-13T22:19:34Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Fri, Aug 13, 2010 at 22:02, Johannes Sixt wrote:\n> We do not have the necessary libraries and tools.\n\nJust curious, do you mean Windows / MINGW can't build gettext, or that\nyou just haven't done so in your build process yet? At least\nhttp://www.mingw.org/wiki/LibrariesAndTools seems to indicate that\nlibintl has been ported to Windows.\n\nIf you're just not interested in building gettext by default on\nWindows I think it's completely reasonable to add it to the Makefile\n(given that you're probably pretty much the only one doing so). It\nwould just be useful to clarify the \"why\".\n\n> Signed-off-by: Johannes Sixt \n> ---\n>  It is necessary to move the first check for NO_GETTEXT after the\n>  configuration section.\n>\n>  NEEDS_LIBINTL receives a default setting before the configuration\n>  section (not visible in the patch text), hence, I have to unset it\n>  when NO_GETTEXT is set. Perhaps you have a better idea to arrange\n>  these settings.\n\nThis seems backwards. Instead of removing the check from the LIB_OBJS\nassignment and adding it in later I think we could just move the giant\n\"Platform specific tweaks\" section so that it appears before all those\nassignments, and directly after \"export PYTHON_PATH\".\n\nI tried doing so locally and Git builds and tests fine, but I've only\ndone so on one platform, so I might have missed something.\n"},{"id":"148076","messageId":"201008141024.42093.j6t@kdbg.org","threadId":"24734","inReplyTo":"AANLkTiku5R+idX-C8f0AcCikBLmfEb5ZEhdft+CSRzU0@mail.gmail.com","subject":"Re: [PATCH] Do not build i18n on Windows.","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2010-08-14T08:24:41Z","receivedAt":"2010-08-14T08:24:41Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"On Samstag, 14. August 2010, Ævar Arnfjörð Bjarmason wrote:\n> On Fri, Aug 13, 2010 at 22:02, Johannes Sixt wrote:\n> > We do not have the necessary libraries and tools.\n>\n> Just curious, do you mean Windows / MINGW can't build gettext, or that\n> you just haven't done so in your build process yet? At least\n> http://www.mingw.org/wiki/LibrariesAndTools seems to indicate that\n> libintl has been ported to Windows.\n\nThe msysgit build environment that I am using does not have libintl. The \nreason *might* be that I haven't updated it since months. Upstream msysgit \ncould already have it.\n\nThe MSVC build environment doesn't have libintl in any case. Even if msysgit \ngains libintl, the MSVC does *not* automatically gain it as well. Hence, \nsetting NO_GETTEXT in the MSVC section of the Makefile makes sense for now.\n\nBTW, libintl is not the only obstacle: the gettext tools are needed as well.\n\n> If you're just not interested in building gettext by default on\n> Windows I think it's completely reasonable to add it to the Makefile\n> (given that you're probably pretty much the only one doing so). It\n> would just be useful to clarify the \"why\".\n\nAs long as libintl and the gettext tools are not in msysgit, we should set \nNO_GETTEXT for MinGW builds. Once we have them, I don't care that much \nwhether we set it by default or not.\n\n-- Hannes\n"}]}