{"thread":{"id":"24690","subject":"[PATCH] t/lib-git-svn.sh: use $PERL_PATH for perl, not perl from $PATH","startedAt":"2010-08-10T12:14:25Z","lastAt":"2010-08-11T18:45:12Z","messageCount":3,"participants":["Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"147627","messageId":"1281442465-27750-1-git-send-email-avarab@gmail.com","threadId":"24690","inReplyTo":null,"subject":"[PATCH] t/lib-git-svn.sh: use $PERL_PATH for perl, not perl from $PATH","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-08-10T12:14:25Z","receivedAt":"2010-08-10T12:14:25Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Change the git-svn tests to use $PERL_PATH, not the \"perl\" in $PATH.\n\nUsing perl in $PATH was added by Sam Vilain in v1.6.6-rc0~95^2~3,\nPhilippe Bruhat introduced $PERL_PATH to the test suite in\nv1.6.6-rc0~9^2, but the lib-git-svn.sh tests weren't updated to use\nthe new convention.\n\nThis resulted in the git-svn tests always being skipped on my\nsystem. My /usr/bin/perl has access to SVN::Core and SVN::Repos, but\nthe perl in my $PATH does not.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n t/lib-git-svn.sh |    5 ++---\n 1 files changed, 2 insertions(+), 3 deletions(-)\n\ndiff --git a/t/lib-git-svn.sh b/t/lib-git-svn.sh\nindex c3f6676..92d6d31 100644\n--- a/t/lib-git-svn.sh\n+++ b/t/lib-git-svn.sh\n@@ -16,7 +16,6 @@ fi\n GIT_DIR=$PWD/.git\n GIT_SVN_DIR=$GIT_DIR/svn/refs/remotes/git-svn\n SVN_TREE=$GIT_SVN_DIR/svn-tree\n-PERL=${PERL:-perl}\n \n svn >/dev/null 2>&1\n if test $? -ne 1\n@@ -30,7 +29,7 @@ export svnrepo\n svnconf=$PWD/svnconf\n export svnconf\n \n-$PERL -w -e \"\n+\"$PERL_PATH\" -w -e \"\n use SVN::Core;\n use SVN::Repos;\n \\$SVN::Core::VERSION gt '1.1.0' or exit(42);\n@@ -130,7 +129,7 @@ stop_httpd () {\n }\n \n convert_to_rev_db () {\n-\t$PERL -w -- - \"$@\" <<\\EOF\n+\t\"$PERL_PATH\" -w -- - \"$@\" <<\\EOF\n use strict;\n @ARGV == 2 or die \"Usage: convert_to_rev_db <input> <output>\";\n open my $wr, '+>', $ARGV[1] or die \"$!: couldn't open: $ARGV[1]\";\n-- \n1.7.1\n"},{"id":"147803","messageId":"7vzkwtxaot.fsf@alter.siamese.dyndns.org","threadId":"24690","inReplyTo":"1281442465-27750-1-git-send-email-avarab@gmail.com","subject":"Re: [PATCH] t/lib-git-svn.sh: use $PERL_PATH for perl, not perl from $PATH","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-08-11T18:32:02Z","receivedAt":"2010-08-11T18:32:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.  Other test scripts (and the insn in t/README) refer to PERL_PATH\nalready and t/test-lib.sh includes build options for its definition, so\nthis should be complete.\n\n\n \n"},{"id":"147808","messageId":"AANLkTikOnWpByxhUNsoOrvzJP83xJfLT6JJQZ4M2XnTN@mail.gmail.com","threadId":"24690","inReplyTo":"7vzkwtxaot.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] t/lib-git-svn.sh: use $PERL_PATH for perl, not perl from $PATH","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-08-11T18:45:12Z","receivedAt":"2010-08-11T18:45:12Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Wed, Aug 11, 2010 at 18:32, Junio C Hamano <gitster@pobox.com> wrote:\n> Thanks.  Other test scripts (and the insn in t/README) refer to PERL_PATH\n> already and t/test-lib.sh includes build options for its definition, so\n> this should be complete.\n\nThere's actually a lot more (most of these):\n\n    $ ack -l '\\bperl.*-\\w*e' *sh\n    annotate-tests.sh\n    diff-lib.sh\n    gitweb-lib.sh\n    lib-t6000.sh\n    t1010-mktree.sh\n    t1300-repo-config.sh\n    t3300-funny-names.sh\n    t4012-diff-binary.sh\n    t4014-format-patch.sh\n    t4020-diff-external.sh\n    t4029-diff-trailing-space.sh\n    t4030-diff-textconv.sh\n    t4031-diff-rewrite-binary.sh\n    t4103-apply-binary.sh\n    t4116-apply-reverse.sh\n    t4200-rerere.sh\n    t5300-pack-object.sh\n    t5303-pack-corruption-resilience.sh\n    t6011-rev-list-with-bad-commit.sh\n    t6013-rev-list-reverse-parents.sh\n    t6300-for-each-ref.sh\n    t9104-git-svn-follow-parent.sh\n    t9119-git-svn-info.sh\n    t9129-git-svn-i18n-commitencoding.sh\n    t9137-git-svn-dcommit-clobber-series.sh\n    t9143-git-svn-gc.sh\n    test-lib.sh\n\nBut they're all using standard features of perl for one-liners. It's a\nreasonable assumption that we can use the perl in $PATH in those\ncases. But maybe we should change those too.\n"}]}