{"thread":{"id":"24633","subject":"[PATCH/RFC] fetch: allow command line --tags to override config","startedAt":"2010-08-04T18:56:42Z","lastAt":"2010-08-14T21:37:01Z","messageCount":12,"participants":["Daniel Johnson","Tay Ray Chuan","Junio C Hamano","Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"147125","messageId":"1280948202-17385-1-git-send-email-ComputerDruid@gmail.com","threadId":"24633","inReplyTo":null,"subject":"[PATCH/RFC] fetch: allow command line --tags to override config","fromName":"Daniel Johnson","fromEmail":"computerdruid@gmail.com","sentAt":"2010-08-04T18:56:42Z","receivedAt":"2010-08-04T18:56:42Z","isPatch":true,"sender":{"key":"computerdruid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/34696?v=4"},"body":"Originally, if remote..tagopt was set, the --tags and option would\nhave no effect when given to git fetch. So if\ntagopt=\"--no-tags\"\n\n\tgit fetch --tags\n\nwould not actually fetch tags.\n\nThis patch changes this behavior to only follow what is written in the\nconfig if there is no option passed by the command line.\n\nSigned-off-by: Daniel Johnson \n---\n builtin/fetch.c | 10 ++++++----\n 1 files changed, 6 insertions(+), 4 deletions(-)\n\ndiff --git a/builtin/fetch.c b/builtin/fetch.c\nindex 1b67f5f..7a53144 100644\n--- a/builtin/fetch.c\n+++ b/builtin/fetch.c\n@@ -675,10 +675,12 @@ static int do_fetch(struct transport *transport,\n \n \tfor_each_ref(add_existing, &existing_refs);\n \n-\tif (transport->remote->fetch_tags == 2 && tags != TAGS_UNSET)\n-\t\ttags = TAGS_SET;\n-\tif (transport->remote->fetch_tags == -1)\n-\t\ttags = TAGS_UNSET;\n+\tif (tags == TAGS_DEFAULT) {\n+\t\tif (transport->remote->fetch_tags == 2)\n+\t\t\ttags = TAGS_SET;\n+\t\tif (transport->remote->fetch_tags == -1)\n+\t\t\ttags = TAGS_UNSET;\n+\t}\n \n \tif (!transport->get_refs_list || !transport->fetch)\n \t\tdie(\"Don't know how to fetch from %s\", transport->url);\n-- \n1.7.2\n"},{"id":"147160","messageId":"AANLkTikf96RLfTq4Q6DAPesr6j70CJfT8vBzidJk42dE@mail.gmail.com","threadId":"24633","inReplyTo":"1280948202-17385-1-git-send-email-ComputerDruid@gmail.com","subject":"Re: [PATCH/RFC] fetch: allow command line --tags to override config","fromName":"Tay Ray Chuan","fromEmail":"rctay89@gmail.com","sentAt":"2010-08-05T09:56:05Z","receivedAt":"2010-08-05T09:56:05Z","isPatch":true,"sender":{"key":"rctay89@gmail.com","avatar":"https://avatars.githubusercontent.com/u/61553?v=4"},"body":"Hi,\n\nOn Thu, Aug 5, 2010 at 2:56 AM, Daniel Johnson wrote:\n> Originally, if remote..tagopt was set, the --tags and option would\n> have no effect when given to git fetch. So if\n> tagopt=\"--no-tags\"\n>\n>        git fetch --tags\n>\n> would not actually fetch tags.\n>\n> This patch changes this behavior to only follow what is written in the\n> config if there is no option passed by the command line.\n>\n> Signed-off-by: Daniel Johnson \n\nThis is pretty confusing as it is. Could you please provide a patch\nfor the git-fetch documentation too?\n\n-- \nCheers,\nRay Chuan\n"},{"id":"147312","messageId":"1281102867-6490-1-git-send-email-ComputerDruid@gmail.com","threadId":"24633","inReplyTo":"AANLkTikf96RLfTq4Q6DAPesr6j70CJfT8vBzidJk42dE@mail.gmail.com","subject":"[PATCH] Documentation: changes in the behavior of tagopt","fromName":"Daniel Johnson","fromEmail":"computerdruid@gmail.com","sentAt":"2010-08-06T13:54:27Z","receivedAt":"2010-08-06T13:54:27Z","isPatch":true,"sender":{"key":"computerdruid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/34696?v=4"},"body":"---\nHow does this look?\n\n Documentation/config.txt | 4 +++-\n Documentation/fetch-options.txt | 8 ++++++--\n 2 files changed, 9 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex f81fb91..682ebef 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1627,7 +1627,9 @@ remote..tagopt::\n \tSetting this value to \\--no-tags disables automatic tag following when\n \tfetching from remote . Setting it to \\--tags will fetch every\n \ttag from remote , even if they are not reachable from remote\n-\tbranch heads.\n+\tbranch heads. Passing these flags directly to linkgit:git-fetch[1] can\n+\toverride this setting. See options \\--tags and \\--no-tags of\n+\tlinkgit:git-fetch[1].\n \n remote..vcs::\n \tSetting this to a value will cause git to interact with\ndiff --git a/Documentation/fetch-options.txt b/Documentation/fetch-options.txt\nindex 9333c42..2fdfeac 100644\n--- a/Documentation/fetch-options.txt\n+++ b/Documentation/fetch-options.txt\n@@ -49,7 +49,9 @@ ifndef::git-pull[]\n endif::git-pull[]\n \tBy default, tags that point at objects that are downloaded\n \tfrom the remote repository are fetched and stored locally.\n-\tThis option disables this automatic tag following.\n+\tThis option disables this automatic tag following. The default\n+\tbehavior for a remote may be specified with the remote..tagopt\n+\tsetting. See linkgit:git-clone[1].\n \n -t::\n --tags::\n@@ -58,7 +60,9 @@ endif::git-pull[]\n \tobjects reachable from the branch heads that are being\n \ttracked will not be fetched by this mechanism. This\n \tflag lets all tags and their associated objects be\n-\tdownloaded.\n+\tdownloaded. The default behavior for a remote may be\n+\tspecified with the remote..tagopt setting. See\n+\tlinkgit:git-clone[1].\n \n -u::\n --update-head-ok::\n-- \n1.7.2\n"},{"id":"147409","messageId":"AANLkTike2mAoGGk2ryZGjOmfT=yjHBLD4W5GPaXkxiso@mail.gmail.com","threadId":"24633","inReplyTo":"1281102867-6490-1-git-send-email-ComputerDruid@gmail.com","subject":"Re: [PATCH] Documentation: changes in the behavior of tagopt","fromName":"Tay Ray Chuan","fromEmail":"rctay89@gmail.com","sentAt":"2010-08-08T02:17:32Z","receivedAt":"2010-08-08T02:17:32Z","isPatch":true,"sender":{"key":"rctay89@gmail.com","avatar":"https://avatars.githubusercontent.com/u/61553?v=4"},"body":"On Fri, Aug 6, 2010 at 9:54 PM, Daniel Johnson wrote:\n> ---\n> How does this look?\n\nLooks ok - now you'll have to squash this with your code patch.\n\n-- \nCheers,\nRay Chuan\n"},{"id":"147839","messageId":"1281567440-6329-1-git-send-email-ComputerDruid@gmail.com","threadId":"24633","inReplyTo":"AANLkTike2mAoGGk2ryZGjOmfT=yjHBLD4W5GPaXkxiso@mail.gmail.com","subject":"[RFC/PATCHv2] fetch: allow command line --tags to override config","fromName":"Daniel Johnson","fromEmail":"computerdruid@gmail.com","sentAt":"2010-08-11T22:57:20Z","receivedAt":"2010-08-11T22:57:20Z","isPatch":false,"sender":{"key":"computerdruid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/34696?v=4"},"body":"Originally, if remote..tagopt was set, the --tags and option would\nhave no effect when given to git fetch. So if\ntagopt=\"--no-tags\"\n\n\tgit fetch --tags\n\nwould not actually fetch tags.\n\nThis patch changes this behavior to only follow what is written in the\nconfig if there is no option passed by the command line.\n\nSigned-off-by: Daniel Johnson \n---\nOn Sat, Aug 7, 2010 at 10:17 PM, Tay Ray Chuan wrote:\n> On Fri, Aug 6, 2010 at 9:54 PM, Daniel Johnson wrote:\n>> ---\n>> How does this look?\n>\n> Looks ok - now you'll have to squash this with your code patch.\nAnd here it is. Sorry about the lateness. I also fixed a mistake I made in the\ndocumentation (linked to the wrong secton).\n\nI'd still like comments on both the code and the change in behavior behind it.\n\n Documentation/config.txt | 4 +++-\n Documentation/fetch-options.txt | 8 ++++++--\n builtin/fetch.c | 10 ++++++----\n 3 files changed, 15 insertions(+), 7 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex f81fb91..682ebef 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1627,7 +1627,9 @@ remote..tagopt::\n \tSetting this value to \\--no-tags disables automatic tag following when\n \tfetching from remote . Setting it to \\--tags will fetch every\n \ttag from remote , even if they are not reachable from remote\n-\tbranch heads.\n+\tbranch heads. Passing these flags directly to linkgit:git-fetch[1] can\n+\toverride this setting. See options \\--tags and \\--no-tags of\n+\tlinkgit:git-fetch[1].\n \n remote..vcs::\n \tSetting this to a value will cause git to interact with\ndiff --git a/Documentation/fetch-options.txt b/Documentation/fetch-options.txt\nindex 9333c42..470ac31 100644\n--- a/Documentation/fetch-options.txt\n+++ b/Documentation/fetch-options.txt\n@@ -49,7 +49,9 @@ ifndef::git-pull[]\n endif::git-pull[]\n \tBy default, tags that point at objects that are downloaded\n \tfrom the remote repository are fetched and stored locally.\n-\tThis option disables this automatic tag following.\n+\tThis option disables this automatic tag following. The default\n+\tbehavior for a remote may be specified with the remote..tagopt\n+\tsetting. See linkgit:git-config[1].\n \n -t::\n --tags::\n@@ -58,7 +60,9 @@ endif::git-pull[]\n \tobjects reachable from the branch heads that are being\n \ttracked will not be fetched by this mechanism. This\n \tflag lets all tags and their associated objects be\n-\tdownloaded.\n+\tdownloaded. The default behavior for a remote may be\n+\tspecified with the remote..tagopt setting. See\n+\tlinkgit:git-config[1].\n \n -u::\n --update-head-ok::\ndiff --git a/builtin/fetch.c b/builtin/fetch.c\nindex 1b67f5f..7a53144 100644\n--- a/builtin/fetch.c\n+++ b/builtin/fetch.c\n@@ -675,10 +675,12 @@ static int do_fetch(struct transport *transport,\n \n \tfor_each_ref(add_existing, &existing_refs);\n \n-\tif (transport->remote->fetch_tags == 2 && tags != TAGS_UNSET)\n-\t\ttags = TAGS_SET;\n-\tif (transport->remote->fetch_tags == -1)\n-\t\ttags = TAGS_UNSET;\n+\tif (tags == TAGS_DEFAULT) {\n+\t\tif (transport->remote->fetch_tags == 2)\n+\t\t\ttags = TAGS_SET;\n+\t\tif (transport->remote->fetch_tags == -1)\n+\t\t\ttags = TAGS_UNSET;\n+\t}\n \n \tif (!transport->get_refs_list || !transport->fetch)\n \t\tdie(\"Don't know how to fetch from %s\", transport->url);\n-- \n1.7.2\n"},{"id":"147980","messageId":"7v8w4bmhmc.fsf@alter.siamese.dyndns.org","threadId":"24633","inReplyTo":"1281567440-6329-1-git-send-email-ComputerDruid@gmail.com","subject":"Re: [RFC/PATCHv2] fetch: allow command line --tags to override config","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-08-13T01:22:19Z","receivedAt":"2010-08-13T01:22:19Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Daniel Johnson writes:\n\n> Originally, if remote..tagopt was set, the --tags and option would\n> have no effect when given to git fetch. So if\n> tagopt=\"--no-tags\"\n>\n> \tgit fetch --tags\n>\n> would not actually fetch tags.\n>\n> This patch changes this behavior to only follow what is written in the\n> config if there is no option passed by the command line.\n>\n> Signed-off-by: Daniel Johnson \n> ---\n> On Sat, Aug 7, 2010 at 10:17 PM, Tay Ray Chuan wrote:\n>> On Fri, Aug 6, 2010 at 9:54 PM, Daniel Johnson wrote:\n>>> ---\n>>> How does this look?\n>>\n>> Looks ok - now you'll have to squash this with your code patch.\n> And here it is. Sorry about the lateness. I also fixed a mistake I made in the\n> documentation (linked to the wrong secton).\n>\n> I'd still like comments on both the code and the change in behavior behind it.\n\nThe current behaviour seems to me a bug introduced while git-fetch was\nrewritten in C (the original found in contrib/examples reads from the\nconfig only when no --tags/--no-tags option is given from the command\nline).\n\nIs this something we can protect with a test script from future breakages?\n\nThanks.\n"},{"id":"148018","messageId":"1281730410-20009-1-git-send-email-ComputerDruid@gmail.com","threadId":"24633","inReplyTo":"7v8w4bmhmc.fsf@alter.siamese.dyndns.org","subject":"[RFC/PATCH] t5525: test the tagopt variable and that it can be overridden","fromName":"Daniel Johnson","fromEmail":"computerdruid@gmail.com","sentAt":"2010-08-13T20:13:30Z","receivedAt":"2010-08-13T20:13:30Z","isPatch":true,"sender":{"key":"computerdruid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/34696?v=4"},"body":"---\n> The current behaviour seems to me a bug introduced while git-fetch was\n> rewritten in C (the original found in contrib/examples reads from the\n> config only when no --tags/--no-tags option is given from the command\n> line).\n>\n> Is this something we can protect with a test script from future breakages?\nThis should test that behavior. I'd appreciate feedback on how to improve this\ntest. I'm not sure if this is the right name/number either.\n\n t/t5525-fetch-tagopt.sh | 44 ++++++++++++++++++++++++++++++++++++++++++++\n 1 files changed, 44 insertions(+), 0 deletions(-)\n create mode 100755 t/t5525-fetch-tagopt.sh\n\ndiff --git a/t/t5525-fetch-tagopt.sh b/t/t5525-fetch-tagopt.sh\nnew file mode 100755\nindex 0000000..17bd407\n--- /dev/null\n+++ b/t/t5525-fetch-tagopt.sh\n@@ -0,0 +1,44 @@\n+\n+#!/bin/sh\n+\n+test_description='tagopt variable affects \"git fetch\" and is overridden by commandline.'\n+\n+. ./test-lib.sh\n+\n+setup_clone () {\n+\t(git clone --mirror . $1 &&\n+\tgit remote add remote_$1 $1 &&\n+\tcd $1 &&\n+\tgit tag tag_$1)\n+}\n+\n+test_expect_success setup '\n+\techo >file original &&\n+\tgit add file &&\n+\tgit commit -a -m original &&\n+\tsetup_clone one &&\n+\tgit config remote.remote_one.tagopt --no-tags &&\n+\tsetup_clone two &&\n+\tgit config remote.remote_two.tagopt --tags\n+\t'\n+\n+test_expect_success \"fetch with tagopt=--no-tags does not get tag\" '\n+\tgit fetch remote_one &&\n+\t! (git show-ref tag_one)\n+\t'\n+\n+test_expect_success \"fetch --tags with tagopt=--no-tags gets tag\" '\n+\tgit fetch --tags remote_one &&\n+\t(git show-ref tag_one)\n+\t'\n+\n+test_expect_success \"fetch --no-tags with tagopt=--tags does not get tag\" '\n+\tgit fetch --no-tags remote_two &&\n+\t! (git show-ref tag_two)\n+\t'\n+\n+test_expect_success \"fetch with tagopt=--tags gets tag\" '\n+\tgit fetch remote_two &&\n+\t(git show-ref tag_two)\n+\t'\n+test_done\n-- \n1.7.2\n"},{"id":"148034","messageId":"AANLkTimYm+GmJ4BmZKOmcZkJf_wgeUiKhTs06qxex+0q@mail.gmail.com","threadId":"24633","inReplyTo":"1281730410-20009-1-git-send-email-ComputerDruid@gmail.com","subject":"Re: [RFC/PATCH] t5525: test the tagopt variable and that it can be overridden","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-08-13T20:55:35Z","receivedAt":"2010-08-13T20:55:35Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Fri, Aug 13, 2010 at 20:13, Daniel Johnson wrote:\n> ---\n>> The current behaviour seems to me a bug introduced while git-fetch was\n>> rewritten in C (the original found in contrib/examples reads from the\n>> config only when no --tags/--no-tags option is given from the command\n>> line).\n>>\n>> Is this something we can protect with a test script from future breakages?\n> This should test that behavior. I'd appreciate feedback on how to improve this\n> test. I'm not sure if this is the right name/number either.\n\nThanks for tackling this.\n\n>  t/t5525-fetch-tagopt.sh |   44 ++++++++++++++++++++++++++++++++++++++++++++\n>  1 files changed, 44 insertions(+), 0 deletions(-)\n>  create mode 100755 t/t5525-fetch-tagopt.sh\n>\n> diff --git a/t/t5525-fetch-tagopt.sh b/t/t5525-fetch-tagopt.sh\n\nThe test name looks fine.\n\n(The t55* test names are a bit of a mess with mixed pull/fetch, but\nthat's not something that should be dealt with here)\n\n> new file mode 100755\n> index 0000000..17bd407\n> --- /dev/null\n> +++ b/t/t5525-fetch-tagopt.sh\n> @@ -0,0 +1,44 @@\n> +\n> +#!/bin/sh\n\nIs that an empty line before the test begins? The shebang should be on\nthe first line.\n\n> +test_description='tagopt variable affects \"git fetch\" and is overridden by commandline.'\n> +\n> +. ./test-lib.sh\n> +\n> +setup_clone () {\n> +       (git clone --mirror . $1 &&\n> +       git remote add remote_$1 $1 &&\n> +       cd $1 &&\n> +       git tag tag_$1)\n> +}\n\nMaybe only put the \"cd $1 ...\" inside a subshell for clarity.\n\n> +test_expect_success setup '\n> +       echo >file original &&\n> +       git add file &&\n> +       git commit -a -m original &&\n\nMaybe this can use test_commit if you don't mind it creating a tag\ntoo.\n\n> +       setup_clone one &&\n> +       git config remote.remote_one.tagopt --no-tags &&\n> +       setup_clone two &&\n> +       git config remote.remote_two.tagopt --tags\n> +       '\n> +\n> +test_expect_success \"fetch with tagopt=--no-tags does not get tag\" '\n> +       git fetch remote_one &&\n> +       ! (git show-ref tag_one)\n> +       '\n\nDoesn't need a subshell? You should also use:\n\n test_must_fail git show-ref ...\n\n> +test_expect_success \"fetch --tags with tagopt=--no-tags gets tag\" '\n> +       git fetch --tags remote_one &&\n> +       (git show-ref tag_one)\n> +       '\n\nDoesn't need a subshell?\n\n> +test_expect_success \"fetch --no-tags with tagopt=--tags does not get tag\" '\n> +       git fetch --no-tags remote_two &&\n> +       ! (git show-ref tag_two)\n> +       '\n> +\n> +test_expect_success \"fetch with tagopt=--tags gets tag\" '\n> +       git fetch remote_two &&\n> +       (git show-ref tag_two)\n> +       '\n> +test_done\n\ntest_must_fail etc etc.\n\nOtherwise it looks good.\n"},{"id":"148038","messageId":"1281734852-21413-1-git-send-email-ComputerDruid@gmail.com","threadId":"24633","inReplyTo":"AANLkTimYm+GmJ4BmZKOmcZkJf_wgeUiKhTs06qxex+0q@mail.gmail.com","subject":"[RFC/PATCHv2] t5525: test the tagopt variable and that it can be overridden","fromName":"Daniel Johnson","fromEmail":"computerdruid@gmail.com","sentAt":"2010-08-13T21:27:32Z","receivedAt":"2010-08-13T21:27:32Z","isPatch":false,"sender":{"key":"computerdruid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/34696?v=4"},"body":"---\n>> @@ -0,0 +1,44 @@\n>> +\n>> +#!/bin/sh\n>\n> Is that an empty line before the test begins? The shebang should be on\n> the first line.\nEmbarrassing. That's what I get for using yank/put and not paying closer\nattention. The rest is fixed too.\n\n t/t5525-fetch-tagopt.sh | 41 +++++++++++++++++++++++++++++++++++++++++\n 1 files changed, 41 insertions(+), 0 deletions(-)\n create mode 100755 t/t5525-fetch-tagopt.sh\n\ndiff --git a/t/t5525-fetch-tagopt.sh b/t/t5525-fetch-tagopt.sh\nnew file mode 100755\nindex 0000000..4fbf7a1\n--- /dev/null\n+++ b/t/t5525-fetch-tagopt.sh\n@@ -0,0 +1,41 @@\n+#!/bin/sh\n+\n+test_description='tagopt variable affects \"git fetch\" and is overridden by commandline.'\n+\n+. ./test-lib.sh\n+\n+setup_clone () {\n+\tgit clone --mirror . $1 &&\n+\tgit remote add remote_$1 $1 &&\n+\t(cd $1 &&\n+\tgit tag tag_$1)\n+}\n+\n+test_expect_success setup '\n+\ttest_commit test &&\n+\tsetup_clone one &&\n+\tgit config remote.remote_one.tagopt --no-tags &&\n+\tsetup_clone two &&\n+\tgit config remote.remote_two.tagopt --tags\n+\t'\n+\n+test_expect_success \"fetch with tagopt=--no-tags does not get tag\" '\n+\tgit fetch remote_one &&\n+\ttest_must_fail git show-ref tag_one\n+\t'\n+\n+test_expect_success \"fetch --tags with tagopt=--no-tags gets tag\" '\n+\tgit fetch --tags remote_one &&\n+\tgit show-ref tag_one\n+\t'\n+\n+test_expect_success \"fetch --no-tags with tagopt=--tags does not get tag\" '\n+\tgit fetch --no-tags remote_two &&\n+\ttest_must_fail git show-ref tag_two\n+\t'\n+\n+test_expect_success \"fetch with tagopt=--tags gets tag\" '\n+\tgit fetch remote_two &&\n+\tgit show-ref tag_two\n+\t'\n+test_done\n-- \n1.7.2\n"},{"id":"148042","messageId":"AANLkTikP5xsvfBt7Rq9CoNnF=7SE4-V6LBML=tDMtT_Q@mail.gmail.com","threadId":"24633","inReplyTo":"1281734852-21413-1-git-send-email-ComputerDruid@gmail.com","subject":"Re: [RFC/PATCHv2] t5525: test the tagopt variable and that it can be overridden","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-08-13T21:39:04Z","receivedAt":"2010-08-13T21:39:04Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Fri, Aug 13, 2010 at 21:27, Daniel Johnson wrote:\n> ---\n>>> @@ -0,0 +1,44 @@\n>>> +\n>>> +#!/bin/sh\n>>\n>> Is that an empty line before the test begins? The shebang should be on\n>> the first line.\n> Embarrassing. That's what I get for using yank/put and not paying closer\n> attention. The rest is fixed too.\n\nNice, I haven't actually *run it* but it looks good, so provided that\nit passes tests when our beloved maintainer applies it:\n\nReviewed-by: Ævar Arnfjörð Bjarmason \n"},{"id":"148109","messageId":"201008141732.16214.ComputerDruid@gmail.com","threadId":"24633","inReplyTo":"AANLkTikP5xsvfBt7Rq9CoNnF=7SE4-V6LBML=tDMtT_Q@mail.gmail.com","subject":"Re: [RFC/PATCHv2] t5525: test the tagopt variable and that it can be overridden","fromName":"Daniel Johnson","fromEmail":"computerdruid@gmail.com","sentAt":"2010-08-14T21:32:05Z","receivedAt":"2010-08-14T21:32:05Z","isPatch":false,"sender":{"key":"computerdruid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/34696?v=4"},"body":"On Friday 13 August 2010 17:39:04 Ævar Arnfjörð Bjarmason wrote:\n> On Fri, Aug 13, 2010 at 21:27, Daniel Johnson \nwrote:\n> > ---\n> > \n> >>> @@ -0,0 +1,44 @@\n> >>> +\n> >>> +#!/bin/sh\n> >> \n> >> Is that an empty line before the test begins? The shebang should be on\n> >> the first line.\n> > \n> > Embarrassing. That's what I get for using yank/put and not paying closer\n> > attention. The rest is fixed too.\n> \n> Nice, I haven't actually *run it* but it looks good, so provided that\n> it passes tests when our beloved maintainer applies it:\n> \n> Reviewed-by: Ævar Arnfjörð Bjarmason \n\nWell, now that we have a fix and a test to help guard against future breakages, \ncan someone tell me the next step as to getting them included?\n\nThanks,\n-Dan\n"},{"id":"148110","messageId":"AANLkTimGhJf0Yp7-1k6EMT6j4T5N-zwxUVDD24DT2fX5@mail.gmail.com","threadId":"24633","inReplyTo":"201008141732.16214.ComputerDruid@gmail.com","subject":"Re: [RFC/PATCHv2] t5525: test the tagopt variable and that it can be overridden","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-08-14T21:37:01Z","receivedAt":"2010-08-14T21:37:01Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Sat, Aug 14, 2010 at 21:32, Daniel Johnson wrote:\n> Well, now that we have a fix and a test to help guard against future breakages,\n> can someone tell me the next step as to getting them included?\n\nYou've done all the needed things. Junio goes through the mail archive\na few things a week to pick up patches. Hopefully he'll pick this up.\n"}]}