{"thread":{"id":"24612","subject":"[PATCH] perl/Makefile: Unset INSTALL_BASE when making perl.mak","startedAt":"2010-08-03T10:30:11Z","lastAt":"2010-08-12T02:48:40Z","messageCount":3,"participants":["Ævar Arnfjörð Bjarmason","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"147032","messageId":"1280831411-4511-1-git-send-email-avarab@gmail.com","threadId":"24612","inReplyTo":null,"subject":"[PATCH] perl/Makefile: Unset INSTALL_BASE when making perl.mak","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-08-03T10:30:11Z","receivedAt":"2010-08-03T10:30:11Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"PREFIX and INSTALL_BASE are mutually exclusive. If both are supplied\nby INSTALL_BASE being set in PERL_MM_OPT ExtUtils::MakeMaker will\nproduce an error:\n\n $ echo $PERL_MM_OPT\n INSTALL_BASE=/home/avar/perl5\n $ make -C perl PERL_PATH='/usr/bin/perl' prefix='/home/avar' perl.mak\n make: Entering directory `/home/avar/g/git/perl'\n /usr/bin/perl Makefile.PL PREFIX='/home/avar'\n Only one of PREFIX or INSTALL_BASE can be given. Not both.\n make: *** [perl.mak] Error 255\n make: Leaving directory `/home/avar/g/git/perl'\n\nChange the perl Makefile to work around this by explicitly unsetting\nINSTALL_BASE.\n\nINSTALL_BASE is set in PERL_MM_OPT by e.g. the popular local::lib\npackage, from its documentation:\n\n eval $(perl -I$HOME/perl5/lib/perl5 -Mlocal::lib 2>/dev/null)\n\nMany other environments might also have set PERL_MM_OPT before\nbuilding Git. This change enables us to build in these environments.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n perl/Makefile | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/perl/Makefile b/perl/Makefile\nindex 4ab21d6..a2ffb64 100644\n--- a/perl/Makefile\n+++ b/perl/Makefile\n@@ -38,7 +38,7 @@ $(makfile): ../GIT-CFLAGS Makefile\n \techo '\techo $(instdir_SQ)' >> $@\n else\n $(makfile): Makefile.PL ../GIT-CFLAGS\n-\t$(PERL_PATH) $< PREFIX='$(prefix_SQ)'\n+\t$(PERL_PATH) $< PREFIX='$(prefix_SQ)' INSTALL_BASE=''\n endif\n \n # this is just added comfort for calling make directly in perl dir\n-- \n1.7.1\n"},{"id":"147038","messageId":"m3d3u0osjo.fsf@localhost.localdomain","threadId":"24612","inReplyTo":"1280831411-4511-1-git-send-email-avarab@gmail.com","subject":"Re: [PATCH] perl/Makefile: Unset INSTALL_BASE when making perl.mak","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-08-03T11:16:40Z","receivedAt":"2010-08-03T11:16:40Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> PREFIX and INSTALL_BASE are mutually exclusive. If both are supplied\n> by INSTALL_BASE being set in PERL_MM_OPT ExtUtils::MakeMaker will\n> produce an error:\n> \n> $ echo $PERL_MM_OPT\n> INSTALL_BASE=/home/avar/perl5\n> $ make -C perl PERL_PATH='/usr/bin/perl' prefix='/home/avar' perl.mak\n> make: Entering directory `/home/avar/g/git/perl'\n> /usr/bin/perl Makefile.PL PREFIX='/home/avar'\n> Only one of PREFIX or INSTALL_BASE can be given. Not both.\n> make: *** [perl.mak] Error 255\n> make: Leaving directory `/home/avar/g/git/perl'\n> \n> Change the perl Makefile to work around this by explicitly unsetting\n> INSTALL_BASE.\n> \n> INSTALL_BASE is set in PERL_MM_OPT by e.g. the popular local::lib\n> package, from its documentation:\n> \n> eval $(perl -I$HOME/perl5/lib/perl5 -Mlocal::lib 2>/dev/null)\n> \n> Many other environments might also have set PERL_MM_OPT before\n> building Git. This change enables us to build in these environments.\n> \n> Signed-off-by: Ævar Arnfjörð Bjarmason \n\nGreat! I really appreciate this, using local::lib myself.\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"147856","messageId":"1281581320-4235-1-git-send-email-avarab@gmail.com","threadId":"24612","inReplyTo":"1280831411-4511-1-git-send-email-avarab@gmail.com","subject":"[PATCH v2/pu] perl/Makefile: Unset INSTALL_BASE when making perl.mak","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-08-12T02:48:40Z","receivedAt":"2010-08-12T02:48:40Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"PREFIX and INSTALL_BASE are mutually exclusive. If both are supplied\nby INSTALL_BASE being set in PERL_MM_OPT ExtUtils::MakeMaker will\nproduce an error:\n\n $ echo $PERL_MM_OPT\n INSTALL_BASE=/home/avar/perl5\n $ make -C perl PERL_PATH='/usr/bin/perl' prefix='/home/avar' perl.mak\n make: Entering directory `/home/avar/g/git/perl'\n /usr/bin/perl Makefile.PL PREFIX='/home/avar'\n Only one of PREFIX or INSTALL_BASE can be given. Not both.\n make: *** [perl.mak] Error 255\n make: Leaving directory `/home/avar/g/git/perl'\n\nChange the perl Makefile to work around this by explicitly unsetting\nINSTALL_BASE.\n\nINSTALL_BASE is set in PERL_MM_OPT by e.g. the popular local::lib\npackage, from its documentation:\n\n eval $(perl -I$HOME/perl5/lib/perl5 -Mlocal::lib 2>/dev/null)\n\nMany other environments might also have set PERL_MM_OPT before\nbuilding Git. This change enables us to build in these environments.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n\nHere's a patch on top of pu instead. This change conflicted with the\ngettext series.\n\n perl/Makefile | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/perl/Makefile b/perl/Makefile\nindex 4e624ff..b2977cd 100644\n--- a/perl/Makefile\n+++ b/perl/Makefile\n@@ -39,7 +39,7 @@ $(makfile): ../GIT-CFLAGS Makefile\n \techo '\techo $(instdir_SQ)' >> $@\n else\n $(makfile): Makefile.PL ../GIT-CFLAGS\n-\t$(PERL_PATH) $< PREFIX='$(prefix_SQ)' --localedir='$(localedir_SQ)'\n+\t$(PERL_PATH) $< PREFIX='$(prefix_SQ)' INSTALL_BASE='' --localedir='$(localedir_SQ)'\n endif\n \n # this is just added comfort for calling make directly in perl dir\n-- \n1.7.2.1.327.gfb40\n"}]}