{"thread":{"id":"24593","subject":"[PATCH] test-lib: Remove 3 year old no-op --no-python option","startedAt":"2010-07-31T16:49:53Z","lastAt":"2010-07-31T16:52:52Z","messageCount":2,"participants":["Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"146868","messageId":"1280594993-2481-1-git-send-email-avarab@gmail.com","threadId":"24593","inReplyTo":null,"subject":"[PATCH] test-lib: Remove 3 year old no-op --no-python option","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-07-31T16:49:53Z","receivedAt":"2010-07-31T16:49:53Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"The --no-python option was added to test-lib.sh by Johannes Schindelin\nin early 2006 in abb7c7b3. It was later turned into a no-op by Junio C\nHamano in 7cdbff14 the same year.\n\nOver three years is long enough before removing this old wart which\nwas retained for backwards compatibility. Our tests have been using\nNO_PYTHON and \"test_have_prereq PYTHON\" for a long time now.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n t/test-lib.sh |    3 ---\n 1 files changed, 0 insertions(+), 3 deletions(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex e5523dd..e151da6 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -132,9 +132,6 @@ do\n \t\twith_dashes=t; shift ;;\n \t--no-color)\n \t\tcolor=; shift ;;\n-\t--no-python)\n-\t\t# noop now...\n-\t\tshift ;;\n \t--va|--val|--valg|--valgr|--valgri|--valgrin|--valgrind)\n \t\tvalgrind=t; verbose=t; shift ;;\n \t--tee)\n-- \n1.7.1\n"},{"id":"146869","messageId":"AANLkTinPx6HbaQQF04XoDu6ACBYzyCNFhCQgFQiy=ayO@mail.gmail.com","threadId":"24593","inReplyTo":"1280594993-2481-1-git-send-email-avarab@gmail.com","subject":"Re: [PATCH] test-lib: Remove 3 year old no-op --no-python option","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-07-31T16:52:52Z","receivedAt":"2010-07-31T16:52:52Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Sat, Jul 31, 2010 at 16:49, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:\n> The --no-python option was added to test-lib.sh by Johannes Schindelin\n> in early 2006 in abb7c7b3. It was later turned into a no-op by Junio C\n> Hamano in 7cdbff14 the same year.\n\nSorry for the resend. git-send-email was hanging and I thought the\noriginal didn't go through:\n\n    Subject: [PATCH] test-lib: Remove 3 year old no-op --no-python option\n    Date: Sat, 31 Jul 2010 16:49:18 +0000\n    Message-Id: <1280594958-2314-1-git-send-email-avarab@gmail.com>\n    X-Mailer: git-send-email 1.7.1\n    MIME-Version: 1.0\n    Content-Type: text/plain; charset=UTF-8\n    Content-Transfer-Encoding: 8bit\n\n    Send this email? ([y]es|[n]o|[q]uit|[a]ll): y\n    Password:\n    ^C\n\n    stty: standard input: Input/output error\n\nBut evidently that went through, here's the output from the second\none:\n\n    Send this email? ([y]es|[n]o|[q]uit|[a]ll): y\n    Password:\n    OK. Log says:\n    Server: smtp.gmail.com\n    MAIL FROM:<avarab@gmail.com>\n    RCPT TO:<git@vger.kernel.org>\n    RCPT TO:<gitster@pobox.com>\n    RCPT TO:<avarab@gmail.com>\n    From: =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?=\n<avarab@gmail.com>\n    To: git@vger.kernel.org\n    Cc: Junio C Hamano <gitster@pobox.com>,\n            =?UTF-8?q?=C3=86var=20Arnfj=C3=B6r=C3=B0=20Bjarmason?=\n<avarab@gmail.com>\n    Subject: [PATCH] test-lib: Remove 3 year old no-op --no-python option\n    Date: Sat, 31 Jul 2010 16:49:53 +0000\n    Message-Id: <1280594993-2481-1-git-send-email-avarab@gmail.com>\n    X-Mailer: git-send-email 1.7.1\n    MIME-Version: 1.0\n    Content-Type: text/plain; charset=UTF-8\n    Content-Transfer-Encoding: 8bit\n\n    Result: 250 2.0.0 OK 1280595002 j1sm1835091wej.39\n\nPerhaps git-send-email should indicate that it has aquired a\nconnection to the server?\n"}]}