{"thread":{"id":"24579","subject":"\"clean\" filter breaks git-svn","startedAt":"2010-07-30T03:55:37Z","lastAt":"2010-07-30T21:21:33Z","messageCount":3,"participants":["Matt Wozniski","Jonathan Nieder","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"146753","messageId":"AANLkTikp6PgHyj2ujbuD52884ny88hMyxR1CpsbNAVCJ@mail.gmail.com","threadId":"24579","inReplyTo":null,"subject":"\"clean\" filter breaks git-svn","fromName":"Matt Wozniski","fromEmail":"godlygeek@gmail.com","sentAt":"2010-07-30T03:55:37Z","receivedAt":"2010-07-30T03:55:37Z","isPatch":false,"sender":{"key":"godlygeek@gmail.com","avatar":null},"body":"I'm playing around with smudge and clean filters, and I've discovered\nthat they seem to completely break git-svn.  When trying to fetch\ncommits A and B from the SVN repos, it will fetch A, and then clean(A)\nis committed to my repository.  Then when it tries to fetch B, it is\nhorribly confused - it complains of a checksum mismatch, since the\nmd5sums of the files in A in the SVN repos don't match up with the\nmd5sums of the files in the clean(A) commit in git land.  Is this a\nknown problem?  And, are there any work arounds other than just not\nusing filters when using git-svn?  Could git-svn be made to accept the\nmd5sum of *either* A or clean(A) instead?\n\nThanks!\n\n~Matt\n\nPS - Please CC me if possible; I'm not subscribed\n"},{"id":"146801","messageId":"20100730203111.GD2448@burratino","threadId":"24579","inReplyTo":"AANLkTikp6PgHyj2ujbuD52884ny88hMyxR1CpsbNAVCJ@mail.gmail.com","subject":"Re: \"clean\" filter breaks git-svn","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-07-30T20:31:11Z","receivedAt":"2010-07-30T20:31:11Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi Matt,\n\nMatt Wozniski wrote:\n\n>                                              When trying to fetch\n> commits A and B from the SVN repos, it will fetch A, and then clean(A)\n> is committed to my repository.  Then when it tries to fetch B, it is\n> horribly confused - it complains of a checksum mismatch, since the\n> md5sums of the files in A in the SVN repos don't match up with the\n> md5sums of the files in the clean(A) commit in git land.\n\nInteresting.  Yeah, that sounds like a bug.\n\nI am not convinced cleaning fetched files is the right thing to do in\nthe first place (why not just trust the SVN repo?), but I assume\npeople with workflows involving such filters could make a better call.\n\n> Is this a\n> known problem?\n\nThere is no test for it in git.git, so in that sense no.\n\n>                                    Could git-svn be made to accept the\n> md5sum of *either* A or clean(A) instead?\n\nI don’t think that would be right.  It’s not just the md5sums not\nmatching that is the problem; it is that in these situations git-svn\nand the SVN server do not agree about the file’s current content.\n\nOnce the code makes the semantics clear, I assume it should Just\nWork™.\n\nGood luck,\nJonathan\n"},{"id":"146802","messageId":"7vwrscpswy.fsf@alter.siamese.dyndns.org","threadId":"24579","inReplyTo":"20100730203111.GD2448@burratino","subject":"Re: \"clean\" filter breaks git-svn","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-07-30T21:21:33Z","receivedAt":"2010-07-30T21:21:33Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> Interesting.  Yeah, that sounds like a bug.\n>\n> I am not convinced cleaning fetched files is the right thing to do in\n> the first place (why not just trust the SVN repo?),...\n\nMy knee-jerk reaction was that it isn't even about _trusting_, but\nmirroring what happened on the other side of the world faithfully.\n\nIf you clean what you got from the other side, and then build on top of\nthat result, how are you supposed to send your contributions back to the\nother side which does not have the same clean-up?\n"}]}