{"thread":{"id":"24569","subject":"[PATCH 0/3] svn-fe fixes","startedAt":"2010-07-29T05:36:17Z","lastAt":"2010-07-29T05:36:20Z","messageCount":4,"participants":["Ramkumar Ramachandra"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"146694","messageId":"1280381780-6265-1-git-send-email-artagnon@gmail.com","threadId":"24569","inReplyTo":null,"subject":"[PATCH 0/3] svn-fe fixes","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2010-07-29T05:36:17Z","receivedAt":"2010-07-29T05:36:17Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Hi,\n\nMy first patch removes a few function calls that Jonathan forgot to\nremove while turning off persistence- those functions aren't generated\nby the obj_pool.h merged into `pu` (Commit fd94590214). My second\npatch fixes the IncludePath in the Makefile so that svn-fe.h is able\nto find the specified header. My third patch is just a trivial\npatch to add /svn-fe to the .gitignore.\n\nI'm sorry I didn't catch this earlier- I only just noticed that the\nversion merged into `pu` wasn't exactly the version I was basing my\nwork on, so I grafted out the commits and rebased to find these\nproblems. In the meantime, I'd request everyone to try out svn-fe in\n`pu`- I'm soon going to send in more patches that are based on what's\nalready merged.\n\nThanks.\n\n-- Ram\n\nRamkumar Ramachandra (3):\n vcs-svn: Remove stray calls to removed functions\n contrib/svn-fe: Fix IncludePath\n contrib/svn-fe: Add the svn-fe target to .gitignore\n\n contrib/svn-fe/.gitignore | 1 +\n contrib/svn-fe/Makefile | 2 +-\n contrib/svn-fe/svn-fe.c | 2 +-\n vcs-svn/repo_tree.c | 3 ---\n vcs-svn/string_pool.c | 1 -\n 5 files changed, 3 insertions(+), 6 deletions(-)\n"},{"id":"146695","messageId":"1280381780-6265-2-git-send-email-artagnon@gmail.com","threadId":"24569","inReplyTo":"1280381780-6265-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 1/3] vcs-svn: Remove stray calls to removed functions","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2010-07-29T05:36:18Z","receivedAt":"2010-07-29T05:36:18Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"repo_tree.c makes calls to non-existant commit_init, dir_init and\ndirent_init functions, and string_pool.c makes a call to non-existant\nstring_init function. These functions were previously generated in\nobj_pool.h before persistence in svn-fe was turned off.\n\nSigned-off-by: Ramkumar Ramachandra \n---\n vcs-svn/repo_tree.c | 3 ---\n vcs-svn/string_pool.c | 1 -\n 2 files changed, 0 insertions(+), 4 deletions(-)\n\ndiff --git a/vcs-svn/repo_tree.c b/vcs-svn/repo_tree.c\nindex c27d077..1ce184d 100644\n--- a/vcs-svn/repo_tree.c\n+++ b/vcs-svn/repo_tree.c\n@@ -308,9 +308,6 @@ static void mark_init(void)\n \n void repo_init() {\n \tpool_init();\n-\tcommit_init();\n-\tdir_init();\n-\tdirent_init();\n \tmark_init();\n \tif (commit_pool.size == 0) {\n \t\t/* Create empty tree for commit 0. */\ndiff --git a/vcs-svn/string_pool.c b/vcs-svn/string_pool.c\nindex bd5a380..616b17e 100644\n--- a/vcs-svn/string_pool.c\n+++ b/vcs-svn/string_pool.c\n@@ -93,7 +93,6 @@ void pool_init(void)\n {\n \tuint32_t node;\n \tuint32_t string = 0;\n-\tstring_init();\n \twhile (string < string_pool.size) {\n \t\tnode = node_alloc(1);\n \t\tnode_pointer(node)->offset = string;\n-- \n1.7.1\n"},{"id":"146696","messageId":"1280381780-6265-3-git-send-email-artagnon@gmail.com","threadId":"24569","inReplyTo":"1280381780-6265-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 2/3] contrib/svn-fe: Fix IncludePath","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2010-07-29T05:36:19Z","receivedAt":"2010-07-29T05:36:19Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Include the path \"../../vcs-svn\" while compiling it in the Makefile\nand change svn-fe.c to include svndump.h.\n\nSigned-off-by: Ramkumar Ramachandra \n---\n contrib/svn-fe/Makefile | 2 +-\n contrib/svn-fe/svn-fe.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/svn-fe/Makefile b/contrib/svn-fe/Makefile\nindex 4cc8d15..360d8da 100644\n--- a/contrib/svn-fe/Makefile\n+++ b/contrib/svn-fe/Makefile\n@@ -38,7 +38,7 @@ svn-fe$X: svn-fe.o $(VCSSVN_LIB) $(GIT_LIB)\n \t\t$(ALL_LDFLAGS) $(LIBS)\n \n svn-fe.o: svn-fe.c ../../vcs-svn/svndump.h\n-\t$(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) $<\n+\t$(QUIET_CC)$(CC) -I../../vcs-svn -o $*.o -c $(ALL_CFLAGS) $<\n \n svn-fe.html: svn-fe.txt\n \t$(QUIET_SUBDIR0)../../Documentation $(QUIET_SUBDIR1) \\\ndiff --git a/contrib/svn-fe/svn-fe.c b/contrib/svn-fe/svn-fe.c\nindex 43c4320..e9b9ba4 100644\n--- a/contrib/svn-fe/svn-fe.c\n+++ b/contrib/svn-fe/svn-fe.c\n@@ -4,7 +4,7 @@\n */\n \n #include \n-#include \"vcs-svn/svndump.h\"\n+#include \"svndump.h\"\n \n int main(int argc, char **argv)\n {\n-- \n1.7.1\n"},{"id":"146697","messageId":"1280381780-6265-4-git-send-email-artagnon@gmail.com","threadId":"24569","inReplyTo":"1280381780-6265-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 3/3] contrib/svn-fe: Add the svn-fe target to .gitignore","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2010-07-29T05:36:20Z","receivedAt":"2010-07-29T05:36:20Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Add the svn-fe target to .gitignroe.\n\nSigned-off-by: Ramkumar Ramachandra \n---\n contrib/svn-fe/.gitignore | 1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/svn-fe/.gitignore b/contrib/svn-fe/.gitignore\nindex 27a33b6..02a7791 100644\n--- a/contrib/svn-fe/.gitignore\n+++ b/contrib/svn-fe/.gitignore\n@@ -1,3 +1,4 @@\n /*.xml\n /*.1\n /*.html\n+/svn-fe\n-- \n1.7.1\n"}]}