{"thread":{"id":"2455","subject":"git-core-arch: Missing dependency","startedAt":"2005-11-11T14:46:06Z","lastAt":"2005-11-12T01:26:12Z","messageCount":6,"participants":["Horst von Brand","Junio C Hamano","Andreas Ericsson","H. Peter Anvin","Chris Wright"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"11593","messageId":"200511111446.jABEk6QM023362@pincoya.inf.utfsm.cl","threadId":"2455","inReplyTo":null,"subject":"git-core-arch: Missing dependency","fromName":"Horst von Brand","fromEmail":"vonbrand@inf.utfsm.cl","sentAt":"2005-11-11T14:46:06Z","receivedAt":"2005-11-11T14:46:06Z","isPatch":false,"sender":{"key":"vonbrand@inf.utfsm.cl","avatar":"https://avatars.githubusercontent.com/u/211384?v=4"},"body":"The command git-archimport makes use of tla, but the relevant package(s) are\nnot on the requirements\n-- \nDr. Horst H. von Brand User #22616 counter.li.org\nDepartamento de Informatica Fono: +56 32 654431\nUniversidad Tecnica Federico Santa Maria +56 32 654239\nCasilla 110-V, Valparaiso, Chile Fax: +56 32 797513\n"},{"id":"11611","messageId":"7vy83vnl7r.fsf@assigned-by-dhcp.cox.net","threadId":"2455","inReplyTo":"200511111446.jABEk6QM023362@pincoya.inf.utfsm.cl","subject":"Re: git-core-arch: Missing dependency","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-11-11T17:33:12Z","receivedAt":"2005-11-11T17:33:12Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Horst von Brand writes:\n\n> The command git-archimport makes use of tla, but the relevant package(s) are\n> not on the requirements\n\nThanks. Should the fix be like this?\n\n-- >8 --\nSubject: RPM: arch submodule needs tla.\n\nSigned-off-by: Junio C Hamano \n\n---\n\n git-core.spec.in | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\napplies-to: 76d3d1c302c20b82fd976e958aabd19f7f01e7b5\na12a9bcce8347f5e5349b05fcd65629e6846a854\ndiff --git a/git-core.spec.in b/git-core.spec.in\nindex cf7e942..6a482ad 100644\n--- a/git-core.spec.in\n+++ b/git-core.spec.in\n@@ -36,7 +36,7 @@ Git tools for importing CVS repositories\n %package arch\n Summary: Git tools for importing Arch repositories\n Group: Development/Tools\n-Requires: git-core = %{version}-%{release}\n+Requires: git-core = %{version}-%{release}, tla\n %description arch\n Git tools for importing Arch repositories.\n \n---\n0.99.9.GIT\n"},{"id":"11614","messageId":"4374E0EF.2020801@op5.se","threadId":"2455","inReplyTo":"7vy83vnl7r.fsf@assigned-by-dhcp.cox.net","subject":"Re: git-core-arch: Missing dependency","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2005-11-11T18:20:31Z","receivedAt":"2005-11-11T18:20:31Z","isPatch":false,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"Junio C Hamano wrote:\n> Horst von Brand writes:\n> \n> \n>>The command git-archimport makes use of tla, but the relevant package(s) are\n>>not on the requirements\n> \n> \n> Thanks. Should the fix be like this?\n> \n> Group: Development/Tools\n> -Requires: git-core = %{version}-%{release}\n> +Requires: git-core = %{version}-%{release}, tla\n\nJust to be anal;\nRequires doesn't usually include the %release, since that's supposed to \nrepresent changes in the spec-file rather than the source (although \npatches included in the spec-file often counts as a new %release, but \nthat's no reason to make it so in the official spec).\n\nI really have to sobner up and get cracking on that spec-file thingie \nstuff. Or some such.\n\nCheers for the beers and review of the peers.\n\nHooray for firday. ;)\n\n-- \nAndreas Ericsson andreas.ericsson@op5.se\nOP5 AB www.op5.se\nTel: +46 8-230225 Fax: +46 8-230231\n"},{"id":"11618","messageId":"7vu0ejm30l.fsf@assigned-by-dhcp.cox.net","threadId":"2455","inReplyTo":"4374E0EF.2020801@op5.se","subject":"Re: git-core-arch: Missing dependency","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-11-11T18:51:38Z","receivedAt":"2005-11-11T18:51:38Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Andreas Ericsson writes:\n\n> Junio C Hamano wrote:\n>> Horst von Brand writes:\n>>\n>>>The command git-archimport makes use of tla, but the relevant package(s) are\n>>>not on the requirements\n>> Thanks. Should the fix be like this?\n>> Group: Development/Tools\n>> -Requires: git-core = %{version}-%{release}\n>> +Requires: git-core = %{version}-%{release}, tla\n>\n> Just to be anal;\n> Requires doesn't usually include the %release,...\n\nObviously both you and Chris (who did the part you are quoting\nfor us) know RPM spec a lot better than I do, and I see two\nexperts contradicting with each other. It could have been just\nan oversight, or it might have done deliberately --- I cannot\njudge myself, so I punt here. I'll remove \"-%{release}\" when I\nhear Chris says he agrees with you.\n\nThanks both.\n"},{"id":"11646","messageId":"43754083.4090501@zytor.com","threadId":"2455","inReplyTo":"7vu0ejm30l.fsf@assigned-by-dhcp.cox.net","subject":"Re: git-core-arch: Missing dependency","fromName":"H. Peter Anvin","fromEmail":"hpa@zytor.com","sentAt":"2005-11-12T01:08:19Z","receivedAt":"2005-11-12T01:08:19Z","isPatch":false,"sender":{"key":"hpa@zytor.com","avatar":null},"body":"Junio C Hamano wrote:\n> Andreas Ericsson writes:\n> \n> \n>>Junio C Hamano wrote:\n>>\n>>>Horst von Brand writes:\n>>>\n>>>\n>>>>The command git-archimport makes use of tla, but the relevant package(s) are\n>>>>not on the requirements\n>>>\n>>>Thanks. Should the fix be like this?\n>>> Group: Development/Tools\n>>>-Requires: git-core = %{version}-%{release}\n>>>+Requires: git-core = %{version}-%{release}, tla\n>>\n>>Just to be anal;\n>>Requires doesn't usually include the %release,...\n> \n> \n> Obviously both you and Chris (who did the part you are quoting\n> for us) know RPM spec a lot better than I do, and I see two\n> experts contradicting with each other. It could have been just\n> an oversight, or it might have done deliberately --- I cannot\n> judge myself, so I punt here. I'll remove \"-%{release}\" when I\n> hear Chris says he agrees with you.\n> \n\nYou can do it either way. It's a matter of the strictness of the \nbinding. If you put %{version} there, then it has to come from the same \nupstream release; for %{version}-%{release} it has to come from the same \nSRPM, i.e. usually from the same build.\n\nIn this case I think %{version}-%{release} is appropriate.\n\n\t-hpa\n"},{"id":"11648","messageId":"20051112012612.GD5856@shell0.pdx.osdl.net","threadId":"2455","inReplyTo":"43754083.4090501@zytor.com","subject":"Re: git-core-arch: Missing dependency","fromName":"Chris Wright","fromEmail":"chrisw@osdl.org","sentAt":"2005-11-12T01:26:12Z","receivedAt":"2005-11-12T01:26:12Z","isPatch":false,"sender":{"key":"chrisw@sous-sol.org","avatar":null},"body":"* H. Peter Anvin (hpa@zytor.com) wrote:\n> Junio C Hamano wrote:\n> >Andreas Ericsson writes:\n> >>Just to be anal;\n> >>Requires doesn't usually include the %release,...\n> >\n> >Obviously both you and Chris (who did the part you are quoting\n> >for us) know RPM spec a lot better than I do, and I see two\n> >experts contradicting with each other. It could have been just\n> >an oversight, or it might have done deliberately --- I cannot\n> >judge myself, so I punt here. I'll remove \"-%{release}\" when I\n> >hear Chris says he agrees with you.\n> \n> You can do it either way. It's a matter of the strictness of the \n> binding. If you put %{version} there, then it has to come from the same \n> upstream release; for %{version}-%{release} it has to come from the same \n> SRPM, i.e. usually from the same build.\n> \n> In this case I think %{version}-%{release} is appropriate.\n\nYeah, I was being conservative. In reality, the release is rarely\nbumped, so it's probably not critical either way.\n\nthanks,\n-chris\n"}]}