{"thread":{"id":"24529","subject":"[PATCH] Clarify help message when no remote is specified in fetch/pull.","startedAt":"2010-07-26T16:32:09Z","lastAt":"2010-07-27T17:36:48Z","messageCount":2,"participants":["Matthieu Moy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"146395","messageId":"1280161929-18620-1-git-send-email-Matthieu.Moy@imag.fr","threadId":"24529","inReplyTo":null,"subject":"[PATCH] Clarify help message when no remote is specified in fetch/pull.","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@imag.fr","sentAt":"2010-07-26T16:32:09Z","receivedAt":"2010-07-26T16:32:09Z","isPatch":true,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"The message is especially confusing when \"git fetch\" is ran from \"git\npull\", for users not aware of \"git fetch\". The new message makes it clear\nthat \"fetch\" means \"fetch new revisions\", and gives hint on the solution.\n\nWe don't add a advice.* configuration option since this message doesn't\nappear in normal use, and shouldn't disturb advanced users.\n\nSigned-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>\n---\nI already gave this a try a long time ago:\n\n  http://thread.gmane.org/gmane.comp.version-control.git/143229/focus=143404\n\nThis version should fix the drawbacks mentionned by Junio.\n\n builtin/fetch.c |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin/fetch.c b/builtin/fetch.c\nindex 6eb1dfe..1b67f5f 100644\n--- a/builtin/fetch.c\n+++ b/builtin/fetch.c\n@@ -845,7 +845,8 @@ static int fetch_one(struct remote *remote, int argc, const char **argv)\n \tint exit_code;\n \n \tif (!remote)\n-\t\tdie(\"Where do you want to fetch from today?\");\n+\t\tdie(\"No remote repository specified.  Please, specify either a URL or a\\n\"\n+\t\t    \"remote name from which new revisions should be fetched.\");\n \n \ttransport = transport_get(remote, NULL);\n \ttransport_set_verbosity(transport, verbosity, progress);\n-- \n1.7.2.19.g9a302.dirty\n"},{"id":"146500","messageId":"7vlj8w7rnz.fsf@alter.siamese.dyndns.org","threadId":"24529","inReplyTo":"1280161929-18620-1-git-send-email-Matthieu.Moy@imag.fr","subject":"Re: [PATCH] Clarify help message when no remote is specified in fetch/pull.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-07-27T17:36:48Z","receivedAt":"2010-07-27T17:36:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sounds good.  Thanks.\n"}]}