{"thread":{"id":"24514","subject":"[PATCH 2/2] simplify digit_in_number","startedAt":"2010-07-25T17:36:20Z","lastAt":"2010-07-25T17:46:02Z","messageCount":3,"participants":["Ralf Thielow","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"146304","messageId":"1280079381-4548-1-git-send-email-ralf.thielow@googlemail.com","threadId":"24514","inReplyTo":null,"subject":"[PATCH 1/2] log-tree: simplify digit_in_number","fromName":"Ralf Thielow","fromEmail":"ralf.thielow@googlemail.com","sentAt":"2010-07-25T17:36:20Z","receivedAt":"2010-07-25T17:36:20Z","isPatch":true,"sender":{"key":"ralf.thielow@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1275832?v=4"},"body":"---\n log-tree.c |   10 ++++------\n 1 files changed, 4 insertions(+), 6 deletions(-)\n\ndiff --git a/log-tree.c b/log-tree.c\nindex b46ed3b..95a00a4 100644\n--- a/log-tree.c\n+++ b/log-tree.c\n@@ -254,12 +254,10 @@ static void append_signoff(struct strbuf *sb, const char *signoff)\n \n static unsigned int digits_in_number(unsigned int number)\n {\n-\tunsigned int i = 10, result = 1;\n-\twhile (i <= number) {\n-\t\ti *= 10;\n-\t\tresult++;\n-\t}\n-\treturn result;\n+\tint digits = 0;\n+\twhile (number /= 10) \n+\t\tdigits++;\n+\treturn digits++;\n }\n \n void get_patch_filename(struct commit *commit, int nr, const char *suffix,\n-- \n1.7.0.4\n"},{"id":"146303","messageId":"1280079381-4548-2-git-send-email-ralf.thielow@googlemail.com","threadId":"24514","inReplyTo":"1280079381-4548-1-git-send-email-ralf.thielow@googlemail.com","subject":"[PATCH 2/2] simplify digit_in_number","fromName":"Ralf Thielow","fromEmail":"ralf.thielow@googlemail.com","sentAt":"2010-07-25T17:36:21Z","receivedAt":"2010-07-25T17:36:21Z","isPatch":true,"sender":{"key":"ralf.thielow@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1275832?v=4"},"body":"---\n log-tree.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/log-tree.c b/log-tree.c\nindex 95a00a4..c2af716 100644\n--- a/log-tree.c\n+++ b/log-tree.c\n@@ -254,10 +254,10 @@ static void append_signoff(struct strbuf *sb, const char *signoff)\n \n static unsigned int digits_in_number(unsigned int number)\n {\n-\tint digits = 0;\n+\tint digits = 1;\n \twhile (number /= 10) \n \t\tdigits++;\n-\treturn digits++;\n+\treturn digits;\n }\n \n void get_patch_filename(struct commit *commit, int nr, const char *suffix,\n-- \n1.7.0.4\n"},{"id":"146309","messageId":"20100725174602.GA9146@burratino","threadId":"24514","inReplyTo":"1280079381-4548-1-git-send-email-ralf.thielow@googlemail.com","subject":"Re: [PATCH 1/2] log-tree: simplify digit_in_number","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-07-25T17:46:02Z","receivedAt":"2010-07-25T17:46:02Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Ralf Thielow wrote:\n\n> +++ b/log-tree.c\n> @@ -254,12 +254,10 @@ static void append_signoff(struct strbuf *sb, const char *signoff)\n>  \n>  static unsigned int digits_in_number(unsigned int number)\n>  {\n> -\tunsigned int i = 10, result = 1;\n> -\twhile (i <= number) {\n> -\t\ti *= 10;\n> -\t\tresult++;\n> -\t}\n> -\treturn result;\n> +\tint digits = 0;\n> +\twhile (number /= 10) \n> +\t\tdigits++;\n> +\treturn digits++;\n\nI think you mean \"return ++digits;\".\n\nBut other questions come to mind first:\n\n - What is the motivation?  How did this come up and what does your change\n   improve?\n\n - Why rewrite this in one patch, only to rewrite it again?\n\nHope that helps,\nJonathan\n"}]}