{"thread":{"id":"24474","subject":"[PATCH 1/3] gitk: improve dark background, s/black/$fgcolor/","startedAt":"2010-07-22T23:10:36Z","lastAt":"2010-07-22T23:10:36Z","messageCount":1,"participants":["David Fries"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"146032","messageId":"20100722231036.GA25144@spacedout.fries.net","threadId":"24474","inReplyTo":null,"subject":"[PATCH 1/3] gitk: improve dark background, s/black/$fgcolor/","fromName":"David Fries","fromEmail":"david@fries.net","sentAt":"2010-07-22T23:10:36Z","receivedAt":"2010-07-22T23:10:36Z","isPatch":true,"sender":{"key":"david@fries.net","avatar":"https://avatars.githubusercontent.com/u/2767875?v=4"},"body":"Replace most uses of black with $fgcolor as items such as a black\noutline on the tag or tag lines with a black background doesn't show\nup.  Use $fgcolor instead to make it contrast with the background.\n---\n gitk-git/gitk |    9 +++++----\n 1 files changed, 5 insertions(+), 4 deletions(-)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex 1b0e09a..8ca7182 100644\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -6270,7 +6270,7 @@ proc drawtags {id x xt y1} {\n \tset xt [expr {$xt + $delta + $wid + $lthickness + $linespc}]\n     }\n     set t [$canv create line $x $y1 [lindex $xvals end] $y1 \\\n-\t       -width $lthickness -fill black -tags tag.$id]\n+\t       -width $lthickness -fill $fgcolor -tags tag.$id]\n     $canv lower $t\n     foreach tag $marks x $xvals wid $wvals {\n \tset xl [expr {$x + $delta}]\n@@ -6280,7 +6280,7 @@ proc drawtags {id x xt y1} {\n \t    # draw a tag\n \t    set t [$canv create polygon $x [expr {$yt + $delta}] $xl $yt \\\n \t\t       $xr $yt $xr $yb $xl $yb $x [expr {$yb - $delta}] \\\n-\t\t       -width 1 -outline black -fill yellow -tags tag.$id]\n+\t\t       -width 1 -outline $fgcolor -fill yellow -tags tag.$id]\n \t    $canv bind $t <1> [list showtag $tag 1]\n \t    set rowtextx([rowofcommit $id]) [expr {$xr + $linespc}]\n \t} else {\n@@ -6295,7 +6295,7 @@ proc drawtags {id x xt y1} {\n \t    }\n \t    set xl [expr {$xl - $delta/2}]\n \t    $canv create polygon $x $yt $xr $yt $xr $yb $x $yb \\\n-\t\t-width 1 -outline black -fill $col -tags tag.$id\n+\t\t-width 1 -outline $fgcolor -fill $col -tags tag.$id\n \t    if {[regexp {^(remotes/.*/|remotes/)} $tag match remoteprefix]} {\n \t        set rwid [font measure mainfont $remoteprefix]\n \t\tset xi [expr {$x + 1}]\n@@ -8215,6 +8215,7 @@ proc linehover {} {\n     global hoverx hovery hoverid hovertimer\n     global canv linespc lthickness\n     global commitinfo\n+    global fgcolor\n \n     set text [lindex $commitinfo($hoverid) 0]\n     set ymax [lindex [$canv cget -scrollregion] 3]\n@@ -8227,7 +8228,7 @@ proc linehover {} {\n     set x1 [expr {$x + [font measure mainfont $text] + 2 * $lthickness}]\n     set y1 [expr {$y + $linespc + 2 * $lthickness}]\n     set t [$canv create rectangle $x0 $y0 $x1 $y1 \\\n-\t       -fill \\#ffff80 -outline black -width 1 -tags hover]\n+\t       -fill \\#ffff80 -outline $fgcolor -width 1 -tags hover]\n     $canv raise $t\n     set t [$canv create text $x $y -anchor nw -text $text -tags hover \\\n \t       -font mainfont]\n-- \n1.7.1\n"}]}