{"thread":{"id":"24345","subject":"[PATCH] test-lib: TAP compliance for skipping tests on request","startedAt":"2010-07-09T11:15:19Z","lastAt":"2010-07-12T16:44:32Z","messageCount":5,"participants":["Michael J Gruber","Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"145202","messageId":"97f41d49b6e374d3e66908f3c62844da27312501.1278673984.git.git@drmicha.warpmail.net","threadId":"24345","inReplyTo":null,"subject":"[PATCH] test-lib: TAP compliance for skipping tests on request","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2010-07-09T11:15:19Z","receivedAt":"2010-07-09T11:15:19Z","isPatch":true,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Make the output TAP compliant for tests skipped on request (GI_SKIP_TESTS).\n\nSigned-off-by: Michael J Gruber \n---\nWe may want to better spell out the reasons, but I think\nit's good enough like this for *explicitly* skipped tests.\n\n t/test-lib.sh | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 8e3de53..2076271 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -395,7 +395,7 @@ test_skip () {\n \tcase \"$to_skip\" in\n \tt)\n \t\tsay_color skip >&3 \"skipping test: $@\"\n-\t\tsay_color skip \"ok $test_count: # skip $1\"\n+\t\tsay_color skip \"ok $test_count # SKIP $1\"\n \t\t: true\n \t\t;;\n \t*)\n@@ -838,7 +838,7 @@ done\n case \"$to_skip\" in\n t)\n \tsay_color skip >&3 \"skipping test $this_test altogether\"\n-\tsay_color skip \"skip all tests in $this_test\"\n+\tskip_all=\"skip all tests in $this_test\"\n \ttest_done\n esac\n \n-- \n1.7.2.rc1.212.g850a\n"},{"id":"145235","messageId":"AANLkTiml1lQlSBDGgUg9scsvsaffDT2n405USmsSIm1n@mail.gmail.com","threadId":"24345","inReplyTo":"97f41d49b6e374d3e66908f3c62844da27312501.1278673984.git.git@drmicha.warpmail.net","subject":"Re: [PATCH] test-lib: TAP compliance for skipping tests on request","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-07-09T19:36:47Z","receivedAt":"2010-07-09T19:36:47Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Fri, Jul 9, 2010 at 11:15, Michael J Gruber wrote:\n> Make the output TAP compliant for tests skipped on request (GI_SKIP_TESTS).\n\nThat \"GI_SKIP_TESTS\" has a T-deficit.\n\n> Signed-off-by: Michael J Gruber \n> ---\n> We may want to better spell out the reasons, but I think\n> it's good enough like this for *explicitly* skipped tests.\n>\n>  t/test-lib.sh |    4 ++--\n>  1 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/t/test-lib.sh b/t/test-lib.sh\n> index 8e3de53..2076271 100644\n> --- a/t/test-lib.sh\n> +++ b/t/test-lib.sh\n> @@ -395,7 +395,7 @@ test_skip () {\n>        case \"$to_skip\" in\n>        t)\n>                say_color skip >&3 \"skipping test: $@\"\n> -               say_color skip \"ok $test_count: # skip $1\"\n> +               say_color skip \"ok $test_count # SKIP $1\"\n\nGood catch with the s/://, but I think the lower-case \"skip\" should\nstay that way. At least that's what Test::More does:\n\n $ perl -MTest::More=tests,2 -E 'SKIP: { skip \"no can do\", 1 } pass \"can do\"'\n 1..2\n ok 1 # skip no can do\n ok 2 - can do\n\nIt only uses upper-case on skip-all. I.e. when part of the plan line:\n\n $ perl -MTest::More=skip_all,\"this platform sucks\" -e1\n 1..0 # SKIP this platform sucks\n\nMaybe I've missed something, or Test::More has a bug.\n\n>                : true\n>                ;;\n>        *)\n> @@ -838,7 +838,7 @@ done\n>  case \"$to_skip\" in\n>  t)\n>        say_color skip >&3 \"skipping test $this_test altogether\"\n> -       say_color skip \"skip all tests in $this_test\"\n> +       skip_all=\"skip all tests in $this_test\"\n>        test_done\n>  esac\n\nGood catch. I missed that (again) in my \"tests: Use skip_all=\nto skip tests\" patch.\n"},{"id":"145359","messageId":"82aab66bffd86b562c76a13a4666d3cf22a64cca.1278930335.git.git@drmicha.warpmail.net","threadId":"24345","inReplyTo":"AANLkTiml1lQlSBDGgUg9scsvsaffDT2n405USmsSIm1n@mail.gmail.com","subject":"[PATCHv2] test-lib: TAP compliance for skipping tests on request","fromName":"Michael J Gruber","fromEmail":"git@drmicha.warpmail.net","sentAt":"2010-07-12T10:33:49Z","receivedAt":"2010-07-12T10:33:49Z","isPatch":false,"sender":{"key":"git@grubix.eu","avatar":"https://avatars.githubusercontent.com/u/233215?v=4"},"body":"Make the output TAP compliant for tests skipped on request (GIT_SKIP_TESTS).\n\nSigned-off-by: Michael J Gruber \n---\nv2 has a typo fix in the commit message and the spelling of \"skip\"\nas suggested by AAB.\n\nI think I've read it differently in the RFC, but then I was also confused about\nthe \"#\" in the RFC, and following the \"reference\" implementation (as per AAB)\nshould be the best approach.\n\n t/test-lib.sh | 4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex bc06564..db8371c 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -396,7 +396,7 @@ test_skip () {\n \tcase \"$to_skip\" in\n \tt)\n \t\tsay_color skip >&3 \"skipping test: $@\"\n-\t\tsay_color skip \"ok $test_count: # skip $1\"\n+\t\tsay_color skip \"ok $test_count # skip $1\"\n \t\t: true\n \t\t;;\n \t*)\n@@ -833,7 +833,7 @@ do\n \tcase \"$this_test\" in\n \t$skp)\n \t\tsay_color skip >&3 \"skipping test $this_test altogether\"\n-\t\tsay_color skip \"skip all tests in $this_test\"\n+\t\tskip_all=\"skip all tests in $this_test\"\n \t\ttest_done\n \tesac\n done\n-- \n1.7.2.rc1.212.g850a\n"},{"id":"145361","messageId":"AANLkTimAu6H4hK-WEhjrGDr5CICWzB_wxrD-GgrBtdKe@mail.gmail.com","threadId":"24345","inReplyTo":"82aab66bffd86b562c76a13a4666d3cf22a64cca.1278930335.git.git@drmicha.warpmail.net","subject":"Re: [PATCHv2] test-lib: TAP compliance for skipping tests on request","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-07-12T11:07:05Z","receivedAt":"2010-07-12T11:07:05Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Mon, Jul 12, 2010 at 10:33, Michael J Gruber\n wrote:\n> Make the output TAP compliant for tests skipped on request (GIT_SKIP_TESTS).\n>\n> Signed-off-by: Michael J Gruber \n> ---\n> v2 has a typo fix in the commit message and the spelling of \"skip\"\n> as suggested by AAB.\n>\n> I think I've read it differently in the RFC, but then I was also confused about\n> the \"#\" in the RFC, and following the \"reference\" implementation (as per AAB)\n> should be the best approach.\n\nAcked-by: Ævar Arnfjörð Bjarmason \n"},{"id":"145376","messageId":"7vd3usd4zz.fsf@alter.siamese.dyndns.org","threadId":"24345","inReplyTo":"AANLkTimAu6H4hK-WEhjrGDr5CICWzB_wxrD-GgrBtdKe@mail.gmail.com","subject":"Re: [PATCHv2] test-lib: TAP compliance for skipping tests on request","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-07-12T16:44:32Z","receivedAt":"2010-07-12T16:44:32Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, both.\n"}]}