{"thread":{"id":"24304","subject":"[PATCH 3/5] git-cvsserver: take care of empty passwords","startedAt":"2010-07-06T17:37:16Z","lastAt":"2010-07-06T18:21:37Z","messageCount":3,"participants":["Áshin László","Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"144928","messageId":"AANLkTinpjbOStczVo7NaPlxqyAh_32kLy0kWKc_AsLiI@mail.gmail.com","threadId":"24304","inReplyTo":"3594077658746039911@unknownmsgid","subject":"[PATCH 3/5] git-cvsserver: take care of empty passwords","fromName":"Áshin László","fromEmail":"ashinlaszlo@gmail.com","sentAt":"2010-07-06T17:37:16Z","receivedAt":"2010-07-06T17:37:16Z","isPatch":true,"sender":{"key":"ashinlaszlo@gmail.com","avatar":null},"body":"Do not try to descramble them.\n---\n git-cvsserver.perl |    6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/git-cvsserver.perl b/git-cvsserver.perl\nindex 10dcc65..e842d77 100755\n--- a/git-cvsserver.perl\n+++ b/git-cvsserver.perl\n@@ -241,11 +241,15 @@ if ($state->{method} eq 'pserver') {\n            exit 1;\n        }\n\n+        if (length($password) > 0) {\n+            $password = descramble($password);\n+        }\n+\n        my $auth_ok;\n        open my $passwd, \"<\", $authdb or die $!;\n        while (<$passwd>) {\n            if (m{^\\Q$user\\E:(.*)}) {\n-                if (crypt($user, descramble($password)) eq $1) {\n+                if (crypt($user, $password) eq $1) {\n                    $auth_ok = 1;\n                }\n            };\n--\n1.7.0.4\n"},{"id":"144934","messageId":"AANLkTilSvEf6DIM_JZql8pTnSCrnFQ2tAOGuqownVl4e@mail.gmail.com","threadId":"24304","inReplyTo":"AANLkTinpjbOStczVo7NaPlxqyAh_32kLy0kWKc_AsLiI@mail.gmail.com","subject":"Re: [PATCH 3/5] git-cvsserver: take care of empty passwords","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-07-06T18:05:40Z","receivedAt":"2010-07-06T18:05:40Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Tue, Jul 6, 2010 at 17:37, Áshin László <ashinlaszlo@gmail.com> wrote:\n> Do not try to descramble them.\n\nThis commit message isn't very revealing. What does this do exactly?\nIs the behavior with empty passwords changed now? Does git-cvsserver\nno longer support empty passwords? Is the on-disk format in the authdb\njust different? (I.e. \"\" instead of \"A\" or something). Or something\nelse?\n"},{"id":"144936","messageId":"AANLkTinkg-i3KczWliWymP1FWYx0_YeoLGLHq2h2jLa-@mail.gmail.com","threadId":"24304","inReplyTo":"AANLkTilSvEf6DIM_JZql8pTnSCrnFQ2tAOGuqownVl4e@mail.gmail.com","subject":"Re: [PATCH 3/5] git-cvsserver: take care of empty passwords","fromName":"Áshin László","fromEmail":"ashinlaszlo@gmail.com","sentAt":"2010-07-06T18:21:37Z","receivedAt":"2010-07-06T18:21:37Z","isPatch":true,"sender":{"key":"ashinlaszlo@gmail.com","avatar":null},"body":"descramble() dies if it is called with empty string as an argument.\nThis patch only fixes this.\n\nThe test case written to check empty passwords only checks the case\nwhen the user is not in the authdb, so the old code doesn't even call\ndescramble().\n\nOn Tue, Jul 6, 2010 at 20:05, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:\n> On Tue, Jul 6, 2010 at 17:37, Áshin László <ashinlaszlo@gmail.com> wrote:\n>> Do not try to descramble them.\n>\n> This commit message isn't very revealing. What does this do exactly?\n> Is the behavior with empty passwords changed now? Does git-cvsserver\n> no longer support empty passwords? Is the on-disk format in the authdb\n> just different? (I.e. \"\" instead of \"A\" or something). Or something\n> else?\n>\n"}]}