{"thread":{"id":"24281","subject":"[PATCH 2/4] git-cvsserver: simplify control flow in pserver authentication","startedAt":"2010-07-03T21:22:45Z","lastAt":"2010-07-03T22:16:27Z","messageCount":2,"participants":["Áshin László","Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"144758","messageId":"AANLkTiktRjlLWrvLG4Jkd_Yu7FLAgJ6_mhYITy3bI3Cb@mail.gmail.com","threadId":"24281","inReplyTo":"1707116361121042582@unknownmsgid","subject":"[PATCH 2/4] git-cvsserver: simplify control flow in pserver authentication","fromName":"Áshin László","fromEmail":"ashinlaszlo@gmail.com","sentAt":"2010-07-03T21:22:45Z","receivedAt":"2010-07-03T21:22:45Z","isPatch":true,"sender":{"key":"ashinlaszlo@gmail.com","avatar":null},"body":" git-cvsserver.perl |   16 +++++++---------\n 1 files changed, 7 insertions(+), 9 deletions(-)\n\ndiff --git a/git-cvsserver.perl b/git-cvsserver.perl\nindex 9664e86..46e5fdb 100755\n--- a/git-cvsserver.perl\n+++ b/git-cvsserver.perl\n@@ -225,18 +225,12 @@ if ($state->{method} eq 'pserver') {\n        }\n\n        # Fall through to LOVE\n-    } else {\n-        # Trying to authenticate a user\n-        if (not exists $cfg->{gitcvs}->{authdb}) {\n-            print \"E the repo config file needs a [gitcvs] section\nwith an 'authdb' parameter set to the filename of the authentication\ndatabase\\n\";\n-            print \"I HATE YOU\\n\";\n-            exit 1;\n-        }\n-\n+    } elsif (exists $cfg->{gitcvs}->{authdb}) {\n        my $authdb = $cfg->{gitcvs}->{authdb};\n\n        unless (-e $authdb) {\n-            print \"E The authentication database specified in\n[gitcvs.authdb] does not exist\\n\";\n+            print \"E The authentication database specified in \";\n+            print \"[gitcvs.authdb] does not exist\\n\";\n            print \"I HATE YOU\\n\";\n            exit 1;\n        }\n@@ -258,6 +252,10 @@ if ($state->{method} eq 'pserver') {\n        }\n\n        # Fall through to LOVE\n+    } else {\n+        print \"E Unable to find usable authentication method\\n\";\n+        print \"I HATE YOU\\n\";\n+        exit 1;\n    }\n\n    # For checking whether the user is anonymous on commit\n--\n1.7.2.rc1.dirty\n"},{"id":"144763","messageId":"AANLkTin69L7BoexBFdTL7L5SB-n1QHe9CJD0KPk3aW7N@mail.gmail.com","threadId":"24281","inReplyTo":"AANLkTiktRjlLWrvLG4Jkd_Yu7FLAgJ6_mhYITy3bI3Cb@mail.gmail.com","subject":"Re: [PATCH 2/4] git-cvsserver: simplify control flow in pserver authentication","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-07-03T22:16:27Z","receivedAt":"2010-07-03T22:16:27Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Looks good. That code is somewhat contrived as-is.\n"}]}