{"thread":{"id":"24212","subject":"What's cooking in git.git (Jun 2010, #05; Sun, 27)","startedAt":"2010-06-27T20:11:41Z","lastAt":"2010-06-30T20:37:38Z","messageCount":5,"participants":["Junio C Hamano","Nazri Ramliy"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"144364","messageId":"7v6314fd6q.fsf@alter.siamese.dyndns.org","threadId":"24212","inReplyTo":null,"subject":"What's cooking in git.git (Jun 2010, #05; Sun, 27)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-06-27T20:11:41Z","receivedAt":"2010-06-27T20:11:41Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Here are the topics that have been cooking.  Commits prefixed with '-' are\nonly in 'pu' while commits prefixed with '+' are in 'next'.  The ones\nmarked with '.' do not appear in any of the integration branches, but I am\nstill holding onto them.\n\nI'd like to have most of the topics still cooking in 'next' in upcoming 1.7.2\nwhile I don't think any of the ones out of 'next' is ready; that makes\ntoday the perfect time to tag 1.7.2-rc0 ;-)\n\n--------------------------------------------------\n[Graduated to \"master\"]\n\n* ab/blame-textconv (2010-06-07) 3 commits\n  (merged to 'next' on 2010-06-23 at a7da5af)\n + t/t8006: test textconv support for blame\n + textconv: support for blame\n + textconv: make the API public\n (this branch is used by cp/textconv-cat-file.)\n\n* cp/textconv-cat-file (2010-06-09) 5 commits\n + git-cat-file.txt: Document --textconv\n  (merged to 'next' on 2010-06-23 at eb6f216)\n + t/t8007: test textconv support for cat-file\n + textconv: support for cat_file\n + sha1_name: add get_sha1_with_context()\n\n* jn/show-num-walks (2010-06-01) 1 commit\n  (merged to 'next' on 2010-06-23 at e61649c)\n + DWIM 'git show -5' to 'git show --do-walk -5'\n\n* js/maint-am-rebase-invalid-author (2010-06-16) 1 commit\n  (merged to 'next' on 2010-06-23 at b345ad5)\n + am: use get_author_ident_from_commit instead of mailinfo when rebasing\n\n* pb/maint-perl-errmsg-no-dir (2010-06-18) 1 commit\n  (merged to 'next' on 2010-06-23 at 990ea67)\n + Git.pm: better error message\n\n* tr/send-email-8bit (2010-06-17) 1 commit\n  (merged to 'next' on 2010-06-23 at be75199)\n + send-email: ask about and declare 8bit mails\n\n--------------------------------------------------\n[New Topics]\n\n* jk/url-decode (2010-06-24) 1 commit\n - url_decode: URL scheme ends with a colon and does not require a slash\n\n* jl/maint-submodule-ignore-dirty-submodules (2010-06-25) 1 commit\n - git submodule: ignore dirty submodules for summary and status\n (this branch is used by jl/status-ignore-submodules and jl/status-ignore-submodules; uses jl/maint-diff-ignore-submodules.)\n\n* jl/status-ignore-submodules (2010-06-25) 1 commit\n - Add the option \"--ignore-submodules\" to \"git status\"\n (this branch uses jl/maint-diff-ignore-submodules, jl/maint-submodule-ignore-dirty-submodules and jl/maint-submodule-ignore-dirty-submodules.)\n\nThese two looked sane; will merge to 'next' shortly.\n\n* mg/doc-rev-parse-treepath-syntax (2010-06-27) 1 commit\n - git-rev-parse.txt: Document \":path\" specifier\n\nSwapping the two bullets in the existing documentation without anything\nelse may be a simpler and easier-to-read alternative.\n\n* jp/string-list-api-cleanup (2010-06-26) 6 commits\n  (merged to 'next' on 2010-06-27 at b1e8b97)\n + string_list: Fix argument order for string_list_append\n + string_list: Fix argument order for string_list_lookup\n + string_list: Fix argument order for string_list_insert_at_index\n + string_list: Fix argument order for string_list_insert\n + string_list: Fix argument order for for_each_string_list\n + string_list: Fix argument order for print_string_list\n (this branch is used by jn/grep-open.)\n\n* mg/rev-parse-tests (2010-05-14) 2 commits\n  (merged to 'next' on 2010-06-27 at 3336145)\n + t6018: make sure all tested symbolic names are different revs\n + t6018: add tests for rev-list's --branches and --tags\n\nResurrects the tests from discarded mg/rev-parse-option-sifter-deprecation.\n\n--------------------------------------------------\n[Stalled -- would discard unless there are some movements soon]\n\n* js/rebase-origin-x (2010-02-05) 1 commit\n - [RFC w/o test and incomplete] rebase: add -x option to record original commit name\n\nI retract my objection against the idea of -x; needs polishing before\nmoving forward.\n\n* zl/mailinfo-recode-patch (2010-06-14) 2 commits\n - add --recode-patch option to git-am\n - add --recode-patch option to git-mailinfo\n\nPerhaps another round is coming?\n\n* rr/svn-export (2010-06-10) 7 commits\n - Add LICENSE\n - Add SVN dump parser\n - Add infrastructure to write revisions in fast-export format\n - Add stream helper library\n - Add library for string-specific memory pool\n - Add cpp macro implementation of treaps\n - Add memory pool library\n\nI recall there was another round of re-roll planned for this one.\n\n* ab/i18n (2010-06-15) 3 commits\n . Add initial C, Shell and Perl gettext translations\n . fixup! Add infrastructure\n . Add infrastructure for translating Git with gettext\n\nI saw a new round on the list, but I haven't got around picking it up yet.\n\n--------------------------------------------------\n[Cooking]\n\n* ps/gitweb-soc (2010-06-02) 2 commits\n  (merged to 'next' on 2010-06-13 at 92245ae)\n + git-instaweb: Add option to reuse previous config file\n + Makefile: Use $(sharedir)/gitweb for target 'install-gitweb'\n\nIf we are going to have a configuration variable to control this, I\nstrongly suspect that --reuse-config should be renamed so that the\nvariable can be named more sanely and in line with whatever option\nthat replaces it.\n\n* ab/tap (2010-06-26) 6 commits\n  (merged to 'next' on 2010-06-27 at a761d14)\n + t9700: Use Test::More->builder, not $Test::Builder::Test\n + tests: Say \"pass\" rather than \"ok\" on empty lines for TAP\n + tests: Skip tests in a way that makes sense under TAP\n + test-lib: output a newline before \"ok\" under a TAP harness\n + test-lib: Make the test_external_* functions TAP-aware\n + test-lib: Adjust output to be valid TAP format\n\nUpdated with a newer round with support for older Test::More before 0.94\nversion.\n\n* ar/decorate-color (2010-06-24) 4 commits\n - Allow customizable commit decorations colors\n - log --decorate: Colorize commit decorations\n - log-tree.c: Use struct name_decoration's type for classifying decoration\n - commit.h: add 'type' to struct name_decoration\n\nTests, perhaps?  Otherwise looked sane.\n\n* tc/checkout-B (2010-06-24) 3 commits\n - builtin/checkout: learn -B\n - builtin/checkout: reword hint for -b\n - add tests for checkout -b\n\n* as/maint-completion-set-u-fix (2010-06-17) 1 commit\n  (merged to 'next' on 2010-06-27 at 24ce8c2)\n + bash-completion: Fix __git_ps1 to work with \"set -u\"\n\n* tr/rev-list-count (2010-06-17) 2 commits\n  (merged to 'next' on 2010-06-27 at 0525b63)\n + bash completion: Support \"divergence from upstream\" messages in __git_ps1\n + rev-list: introduce --count option\n\n* jl/maint-diff-ignore-submodules (2010-06-25) 3 commits\n  (merged to 'next' on 2010-06-25 at d75dbf1)\n + t4027,4041: Use test -s to test for an empty file\n  (merged to 'next' on 2010-06-23 at 057acb7)\n + Add optional parameters to the diff option \"--ignore-submodules\"\n + git diff: rename test that had a conflicting name\n (this branch is used by jl/maint-submodule-ignore-dirty-submodules and jl/status-ignore-submodules.)\n\n* jn/grep-open (2010-06-26) 8 commits\n  (merged to 'next' on 2010-06-27 at 84c0976)\n + Merge branch 'jp/string-list-api-cleanup' into jn/grep-open\n  (merged to 'next' on 2010-06-22 at 8edca58)\n + t/t7811-grep-open.sh: remove broken/redundant creation of fake \"less\" script\n + t/t7811-grep-open.sh: ensure fake \"less\" is made executable\n + t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expression\n  (merged to 'next' on 2010-06-18 at cf96ea8)\n + grep -O: allow optional argument specifying the pager (or editor)\n + grep: Add the option '--open-files-in-pager'\n + Unify code paths of threaded greps\n + grep: refactor grep_objects loop into its own function\n (this branch uses jp/string-list-api-cleanup.)\n\n* eb/double-convert-before-merge (2010-06-16) 1 commit\n - ll-merge: Normalize files before merging\n\nI saw a new round on the list, but I haven't got around picking it up yet.\n\n* cc/cherry-pick-stdin (2010-06-14) 2 commits\n  (merged to 'next' on 2010-06-27 at 3af0bba)\n + revert: accept arbitrary rev-list options\n + t3508 (cherry-pick): futureproof against unmerged files\n\n--------------------------------------------------\n[Discarded]\n\n* mg/rev-parse-lrbranches-locals (2010-05-14) 1 commit\n . revlist: Introduce --lrbranches and --locals revision specifiers\n (this branch uses mg/rev-parse-option-sifter-deprecation.)\n\n* mg/rev-parse-option-sifter-deprecation (2010-05-14) 3 commits\n . t6018: make sure all tested symbolic names are different revs\n . t6018: add tests for rev-list's --branches and --tags\n . rev-parse: deprecate use as an option sifter\n\nThe tests are resurrected in a separate branch, though.\n"},{"id":"144374","messageId":"1277710240-11378-1-git-send-email-ayiehere@gmail.com","threadId":"24212","inReplyTo":"7v6314fd6q.fsf@alter.siamese.dyndns.org","subject":"[PATCH] Add test for correct coloring of git log --decoration","fromName":"Nazri Ramliy","fromEmail":"ayiehere@gmail.com","sentAt":"2010-06-28T07:30:40Z","receivedAt":"2010-06-28T07:30:40Z","isPatch":true,"sender":{"key":"ayiehere@gmail.com","avatar":"https://avatars.githubusercontent.com/u/164756?v=4"},"body":"Signed-off-by: Nazri Ramliy <ayiehere@gmail.com>\n---\nOn Mon, Jun 28, 2010 at 4:11 AM, Junio C Hamano <gitster@pobox.com> wrote:\n> * ar/decorate-color (2010-06-24) 4 commits\n>  - Allow customizable commit decorations colors\n>  - log --decorate: Colorize commit decorations\n>  - log-tree.c: Use struct name_decoration's type for classifying decoration\n>  - commit.h: add 'type' to struct name_decoration\n> \n> Tests, perhaps?  Otherwise looked sane.\n\nHere is a proposed test for checking if the decorations are colored correctly.\nIt should be applied on top of 5e11bee65f601ba97dc4c61c75fcb2f448fdcb1c in pu.\n\nI've tried adding \n\n\tlog --decorate --all --oneline --color=always\n\nto t4013-diff-various.sh but it seems a bit out of place because my test only\ntest for colors, while no other test in that file test for colors, hence the\nnew test file (t4207-log-decoration-colors.sh).\n\nnazri\n\n t/t4207-log-decoration-colors.sh |   70 ++++++++++++++++++++++++++++++++++++++\n 1 files changed, 70 insertions(+), 0 deletions(-)\n create mode 100755 t/t4207-log-decoration-colors.sh\n\ndiff --git a/t/t4207-log-decoration-colors.sh b/t/t4207-log-decoration-colors.sh\nnew file mode 100755\nindex 0000000..260e71f\n--- /dev/null\n+++ b/t/t4207-log-decoration-colors.sh\n@@ -0,0 +1,70 @@\n+#!/bin/sh\n+#\n+# Copyright (c) 2010 Nazri Ramliy\n+#\n+\n+test_description='Test for \"git log --decorate\" colors\n+'\n+\n+. ./test-lib.sh\n+\n+test_expect_success setup '\n+  echo foo > foo.txt &&\n+  git add foo.txt &&\n+  test_tick &&\n+  git commit -m first &&\n+\n+  echo bar > bar.txt &&\n+  git add bar.txt &&\n+  test_tick &&\n+  git commit -m second &&\n+\n+  test_tick &&\n+  EDITOR=cat git tag v1.0 &&\n+\n+  git clone . local_clone &&\n+\n+  cd local_clone &&\n+  git config diff.color.commit yellow &&\n+  git config color.decorate.branch green &&\n+  git config color.decorate.remoteBranch red &&\n+  git config color.decorate.tag yellow &&\n+  git config color.decorate.stash magenta &&\n+  git config color.decorate.HEAD cyan &&\n+\n+  echo baz >> foo.txt &&\n+  git stash save baz\n+'\n+\n+get_color()\n+{\n+  git config --get-color no.such.slot \"$1\"\n+}\n+\n+# Colors\n+c_reset=$(get_color reset)\n+c_commit=$(get_color yellow)\n+c_branch=$(get_color green)\n+c_remoteBranch=$(get_color red)\n+c_tag=$(get_color yellow)\n+c_stash=$(get_color magenta)\n+c_HEAD=$(get_color cyan)\n+\n+cat > expected << EOF\n+${c_commit}COMMIT_ID (${c_stash}refs/stash${c_reset}${c_commit})${c_reset} On master: baz\n+${c_commit}COMMIT_ID (${c_HEAD}HEAD${c_reset}${c_commit},\\\n+ ${c_tag}tag: v1.0${c_reset}${c_commit},\\\n+ ${c_remoteBranch}origin/master${c_reset}${c_commit},\\\n+ ${c_remoteBranch}origin/HEAD${c_reset}${c_commit},\\\n+ ${c_branch}master${c_reset}${c_commit})${c_reset} second\n+${c_commit}COMMIT_ID${c_reset} first\n+EOF\n+\n+# We want log to show all, but the second parent to refs/stash is irrelevant\n+# to this test since it does not contain any decoration, hence --first-parent\n+test_expect_success 'Commit Decorations Colored Correctly' '\n+  git log --first-parent --abbrev=10 --all --decorate --oneline --color=always |sed \"s/[0-9a-f]\\{10,10\\}/COMMIT_ID/\" > out &&\n+  test_cmp expected out\n+'\n+\n+test_done\n-- \n1.7.1.245.g7c42e.dirty\n"},{"id":"144440","messageId":"7vbpaucs2c.fsf@alter.siamese.dyndns.org","threadId":"24212","inReplyTo":"1277710240-11378-1-git-send-email-ayiehere@gmail.com","subject":"Re: [PATCH] Add test for correct coloring of git log --decoration","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-06-29T05:43:07Z","receivedAt":"2010-06-29T05:43:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nazri Ramliy <ayiehere@gmail.com> writes:\n\n> I've tried adding \n>\n> \tlog --decorate --all --oneline --color=always\n>\n> to t4013-diff-various.sh but it seems a bit out of place because my test only\n> test for colors, while no other test in that file test for colors, hence the\n> new test file (t4207-log-decoration-colors.sh).\n\nIt sounds fine to have these in a separate file.\n\n> diff --git a/t/t4207-log-decoration-colors.sh b/t/t4207-log-decoration-colors.sh\n> new file mode 100755\n> index 0000000..260e71f\n> --- /dev/null\n> +++ b/t/t4207-log-decoration-colors.sh\n> @@ -0,0 +1,70 @@\n> +#!/bin/sh\n> +#\n> +# Copyright (c) 2010 Nazri Ramliy\n> +#\n> +\n> +test_description='Test for \"git log --decorate\" colors\n> +'\n\nLet's not expand a single-line description needlessly into a multi-line\none.\n\n> +. ./test-lib.sh\n> +\n> +test_expect_success setup '\n> +  echo foo > foo.txt &&\n\nIndent these with <TAB>, like:\n\n\techo foo >foo.txt &&\n\n> +  git add foo.txt &&\n> +  test_tick &&\n> +  git commit -m first &&\n> +\n> +  echo bar > bar.txt &&\n> +  git add bar.txt &&\n> +  test_tick &&\n> +  git commit -m second &&\n> +\n> +  test_tick &&\n> +  EDITOR=cat git tag v1.0 &&\n\nI think \"EDITOR=cat\" is doubly wrong.  You are not annotating the tag\nanyway, so it won't get called, but if you were, you will get something\nlike this:\n\n\t$ EDITOR=cat git tag -a v1.0\n\n\t#\n        # Write a tag message\n        #\n        fatal: no tag message?\n\n> +  git clone . local_clone &&\n> +  cd local_clone &&\n\nDo not chdir around inside test scripts without having that in a subshell,\nas people typically write \"cd ..\" at the very end of a && chain, which may\nnot be called when anything in between fails, throwing the later tests\ninto chaos.\n\nIn this case your excuse will be that you will run everything after this\npoint in that local-clone subdirectory, but still this is not a good style\nwe would want to keep around, risking to be copied by other people who do\nnot think carefully.\n\nI think the set-up sequence for this test script should probably be\nstructured like this:\n\n\tget_color()\n        {\n        \tgit config ...\n\t}\n\n\ttest_expect_success setup '\n\t\tgit config diff.color.commit yellow &&\n                ...\n                git config color.decorate.HEAD cyan &&\n\n                c_reset=$(get_color reset) &&\n                ...\n\t\tc_HEAD=$(get_color cyan) &&\n\n        \ttest_commit A &&\n\t\tgit clone . other &&\n                (\n                \tcd other &&\n                        test_commit A1\n\t\t) &&\n\t\tgit remote add -f other ./other &&\n                test_commit B &&\n\t\tgit tag v1.0 &&\n                echo >>A &&\n                git stash save Changes to A &&\n\t'\n\nso that the main test is done inside the top-level directory (you wanted\nthe clone only because you wanted to have remote tracking branches, not\nbecause you didn't want to touch the top-level directory).\n"},{"id":"144445","messageId":"1277797628-32466-1-git-send-email-ayiehere@gmail.com","threadId":"24212","inReplyTo":"7vbpaucs2c.fsf@alter.siamese.dyndns.org","subject":"[PATCH] Add test for correct coloring of git log --decoration","fromName":"Nazri Ramliy","fromEmail":"ayiehere@gmail.com","sentAt":"2010-06-29T07:47:08Z","receivedAt":"2010-06-29T07:47:08Z","isPatch":true,"sender":{"key":"ayiehere@gmail.com","avatar":"https://avatars.githubusercontent.com/u/164756?v=4"},"body":"Signed-off-by: Nazri Ramliy <ayiehere@gmail.com>\n---\nOn Tue, Jun 29, 2010 at 1:43 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Let's not expand a single-line description needlessly into a multi-line\n> one.\n\nFixed.\n\n>> +test_expect_success setup '\n>> +  echo foo > foo.txt &&\n>\n> Indent these with <TAB>, like:\n>\n>        echo foo >foo.txt &&\n\nFixed.\n\n> I think \"EDITOR=cat\" is doubly wrong.\n\nFixed.\n\n> Do not chdir around inside test scripts without having that in a subshell,\n> as people typically write \"cd ..\" at the very end of a && chain, which may\n> not be called when anything in between fails, throwing the later tests\n> into chaos.\n\nFixed.\n\n> In this case your excuse will be that you will run everything after this\n> point in that local-clone subdirectory, but still this is not a good style\n> we would want to keep around, risking to be copied by other people who do\n> not think carefully.\n[snip]\n> I think the set-up sequence for this test script should probably be\n> structured like this:\n[snip]\n> so that the main test is done inside the top-level directory (you wanted\n> the clone only because you wanted to have remote tracking branches, not\n> because you didn't want to touch the top-level directory).\n\nThanks for taking the time to explain it well.\n\nI should have familiarized myself more with the utility functions in\ntest-lib.sh (so that I would know about test_commit).\n\nI've updated the test to also test for the need to print 'reset' right before\nrestoring the commit color.  This is done by setting the tag color to \"reverse\nbold yellow\".  Without the 'reset', the next decoration would be wrongly\nprinted in reverse.\n\nnazri\n\n t/t4207-log-decoration-colors.sh |   65 ++++++++++++++++++++++++++++++++++++++\n 1 files changed, 65 insertions(+), 0 deletions(-)\n create mode 100755 t/t4207-log-decoration-colors.sh\n\ndiff --git a/t/t4207-log-decoration-colors.sh b/t/t4207-log-decoration-colors.sh\nnew file mode 100755\nindex 0000000..5ea5865\n--- /dev/null\n+++ b/t/t4207-log-decoration-colors.sh\n@@ -0,0 +1,65 @@\n+#!/bin/sh\n+#\n+# Copyright (c) 2010 Nazri Ramliy\n+#\n+\n+test_description='Test for \"git log --decorate\" colors'\n+\n+. ./test-lib.sh\n+\n+get_color ()\n+{\n+\tgit config --get-color no.such.slot \"$1\"\n+}\n+\n+test_expect_success setup '\n+\tgit config diff.color.commit yellow &&\n+\tgit config color.decorate.branch green &&\n+\tgit config color.decorate.remoteBranch red &&\n+\tgit config color.decorate.tag \"reverse bold yellow\" &&\n+\tgit config color.decorate.stash magenta &&\n+\tgit config color.decorate.HEAD cyan &&\n+\n+\tc_reset=$(get_color reset) &&\n+\n+\tc_commit=$(get_color yellow) &&\n+\tc_branch=$(get_color green) &&\n+\tc_remoteBranch=$(get_color red) &&\n+\tc_tag=$(get_color \"reverse bold yellow\") &&\n+\tc_stash=$(get_color magenta) &&\n+\tc_HEAD=$(get_color cyan) &&\n+\n+\ttest_commit A &&\n+\tgit clone . other &&\n+\t(\n+\t\tcd other &&\n+\t\ttest_commit A1\n+\t) &&\n+\n+\tgit remote add -f other ./other &&\n+\ttest_commit B &&\n+\tgit tag v1.0 &&\n+\techo >>A.t &&\n+\tgit stash save Changes to A.t\n+'\n+\n+cat > expected << EOF\n+${c_commit}COMMIT_ID (${c_HEAD}HEAD${c_reset}${c_commit},\\\n+ ${c_tag}tag: v1.0${c_reset}${c_commit},\\\n+ ${c_tag}tag: B${c_reset}${c_commit},\\\n+ ${c_branch}master${c_reset}${c_commit})${c_reset} B\n+${c_commit}COMMIT_ID (${c_tag}tag: A1${c_reset}${c_commit},\\\n+ ${c_remoteBranch}other/master${c_reset}${c_commit})${c_reset} A1\n+${c_commit}COMMIT_ID (${c_stash}refs/stash${c_reset}${c_commit})${c_reset}\\\n+ On master: Changes to A.t\n+${c_commit}COMMIT_ID (${c_tag}tag: A${c_reset}${c_commit})${c_reset} A\n+EOF\n+\n+# We want log to show all, but the second parent to refs/stash is irrelevant\n+# to this test since it does not contain any decoration, hence --first-parent\n+test_expect_success 'Commit Decorations Colored Correctly' '\n+\tgit log --first-parent --abbrev=10 --all --decorate --oneline --color=always | sed \"s/[0-9a-f]\\{10,10\\}/COMMIT_ID/\" > out &&\n+\ttest_cmp expected out\n+'\n+\n+test_done\n-- \n1.7.1.245.g7c42e.dirty\n"},{"id":"144550","messageId":"7voces45pp.fsf@alter.siamese.dyndns.org","threadId":"24212","inReplyTo":"1277797628-32466-1-git-send-email-ayiehere@gmail.com","subject":"Re: [PATCH] Add test for correct coloring of git log --decoration","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-06-30T20:37:38Z","receivedAt":"2010-06-30T20:37:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Nazri Ramliy <ayiehere@gmail.com> writes:\n\n> I've updated the test to also test for the need to print 'reset' right before\n> restoring the commit color.  This is done by setting the tag color to \"reverse\n> bold yellow\".  Without the 'reset', the next decoration would be wrongly\n> printed in reverse.\n\nThanks, will queue.\n"}]}