{"thread":{"id":"24187","subject":"[BUG] git gui blame: Show History Context [still] broken since 29e5573d","startedAt":"2010-06-24T16:28:59Z","lastAt":"2010-07-27T01:09:11Z","messageCount":7,"participants":["Matthieu Moy","Pat Thoyts","Junio C Hamano","Jonathan Nieder"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"144160","messageId":"vpqy6e4v1h0.fsf@bauges.imag.fr","threadId":"24187","inReplyTo":null,"subject":"[BUG] git gui blame: Show History Context [still] broken since 29e5573d","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2010-06-24T16:28:59Z","receivedAt":"2010-06-24T16:28:59Z","isPatch":false,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Hi,\n\nI reported this bug a while ago:\n\nhttp://kerneltrap.org/mailarchive/git/2010/2/22/24038\n\nIn short, the \"Show history context\" item of the context menu of \"git\ngui blame\" is broken since february. Two patches were proposed:\n\nhttp://thread.gmane.org/gmane.comp.version-control.git/140688\nhttp://thread.gmane.org/gmane.comp.version-control.git/140288\n\nBut I've just noticed that none of theme were applied.\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"145286","messageId":"87sk3qrjk3.fsf@fox.patthoyts.tk","threadId":"24187","inReplyTo":"vpqy6e4v1h0.fsf@bauges.imag.fr","subject":"Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2010-07-10T23:41:48Z","receivedAt":"2010-07-10T23:41:48Z","isPatch":false,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"Matthieu Moy writes:\n\n>Hi,\n>\n>I reported this bug a while ago:\n>\n>http://kerneltrap.org/mailarchive/git/2010/2/22/24038\n>\n>In short, the \"Show history context\" item of the context menu of \"git\n>gui blame\" is broken since february. Two patches were proposed:\n>\n>http://thread.gmane.org/gmane.comp.version-control.git/140688\n>http://thread.gmane.org/gmane.comp.version-control.git/140288\n>\n>But I've just noticed that none of theme were applied.\n>\n\nChecking this it seems you are correct. This has been fixed for\nmsysGit with the above patch included there but is missing from\ngit-gui itself and hence missing from core git.\n\n-- \nPat Thoyts http://www.patthoyts.tk/\nPGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD\n"},{"id":"145395","messageId":"7vtyo4a096.fsf@alter.siamese.dyndns.org","threadId":"24187","inReplyTo":"87sk3qrjk3.fsf@fox.patthoyts.tk","subject":"Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-07-12T20:55:17Z","receivedAt":"2010-07-12T20:55:17Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Pat Thoyts writes:\n\n> Matthieu Moy writes:\n>\n>>Hi,\n>>\n>>I reported this bug a while ago:\n>>\n>>http://kerneltrap.org/mailarchive/git/2010/2/22/24038\n>>\n>>In short, the \"Show history context\" item of the context menu of \"git\n>>gui blame\" is broken since february. Two patches were proposed:\n>>\n>>http://thread.gmane.org/gmane.comp.version-control.git/140688\n>>http://thread.gmane.org/gmane.comp.version-control.git/140288\n>>\n>>But I've just noticed that none of theme were applied.\n>\n> Checking this it seems you are correct. This has been fixed for\n> msysGit with the above patch included there but is missing from\n> git-gui itself and hence missing from core git.\n\nCan we resolve this before 1.7.2 final?\n\nShawn, I see 9c898a1 (git-gui: check whether systems nice command works or\ndisable it, 2010-02-07) on your 'maint' that is not in mine (and a merge\nof that commit on your 'master'), but neither of these.\n"},{"id":"145983","messageId":"vpqzkxkorzr.fsf@bauges.imag.fr","threadId":"24187","inReplyTo":"7vtyo4a096.fsf@alter.siamese.dyndns.org","subject":"Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2010-07-22T08:11:52Z","receivedAt":"2010-07-22T08:11:52Z","isPatch":false,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Junio C Hamano writes:\n\n> Pat Thoyts writes:\n>\n>> Matthieu Moy writes:\n>>\n>>>Hi,\n>>>\n>>>I reported this bug a while ago:\n>>>\n>>>http://kerneltrap.org/mailarchive/git/2010/2/22/24038\n>>>\n>>>In short, the \"Show history context\" item of the context menu of \"git\n>>>gui blame\" is broken since february. Two patches were proposed:\n>>>\n>>>http://thread.gmane.org/gmane.comp.version-control.git/140688\n>>>http://thread.gmane.org/gmane.comp.version-control.git/140288\n>>>\n>>>But I've just noticed that none of theme were applied.\n>>\n>> Checking this it seems you are correct. This has been fixed for\n>> msysGit with the above patch included there but is missing from\n>> git-gui itself and hence missing from core git.\n>\n> Can we resolve this before 1.7.2 final?\n\nToo late for the 1.7.2, but can we finally get one of these patches\napplied? They're both very short and straightforward, and fix an\nimportant feature of git-gui which is basically broken as of now.\n\nThanks,\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"145984","messageId":"20100722082310.GB13386@burratino","threadId":"24187","inReplyTo":"vpqzkxkorzr.fsf@bauges.imag.fr","subject":"Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-07-22T08:23:10Z","receivedAt":"2010-07-22T08:23:10Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Matthieu Moy wrote:\n\n> Too late for the 1.7.2, but can we finally get one of these patches\n> applied? They're both very short and straightforward, and fix an\n> important feature of git-gui which is basically broken as of now.\n\nMaybe some interested person should maintain a temporary fork of\ngit-gui that could be merged in the meantime. That is what people\nseem to usually do with submodules in analogous situations.\n"},{"id":"146329","messageId":"87iq43wbz3.fsf@fox.patthoyts.tk","threadId":"24187","inReplyTo":"20100722082310.GB13386@burratino","subject":"Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d","fromName":"Pat Thoyts","fromEmail":"patthoyts@users.sourceforge.net","sentAt":"2010-07-25T20:19:44Z","receivedAt":"2010-07-25T20:19:44Z","isPatch":false,"sender":{"key":"patthoyts@users.sourceforge.net","avatar":"https://avatars.githubusercontent.com/u/30739?v=4"},"body":"Jonathan Nieder writes:\n\n>Matthieu Moy wrote:\n>\n>> Too late for the 1.7.2, but can we finally get one of these patches\n>> applied? They're both very short and straightforward, and fix an\n>> important feature of git-gui which is basically broken as of now.\n>\n>Maybe some interested person should maintain a temporary fork of\n>git-gui that could be merged in the meantime. That is what people\n>seem to usually do with submodules in analogous situations.\n\nI pushed git-gui + my patches to git://git.patthoyts.tk/git-gui\n(http://www.patthoyts.tk/gitweb.cgi?p=git-gui;a=summary)\nso if someone wants to pull from that it is Shawn's repository plus 3.\n\nAlternatively the git-gui patches could be pulled from msysGit which\nhas a few in addition to these three.\n\n-- \nPat Thoyts http://www.patthoyts.tk/\nPGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD\n"},{"id":"146445","messageId":"20100727010911.GA4041@burratino","threadId":"24187","inReplyTo":"87iq43wbz3.fsf@fox.patthoyts.tk","subject":"git gui tree (Re: [BUG] git gui blame: Show History Context [still] broken since 29e5573d)","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-07-27T01:09:11Z","receivedAt":"2010-07-27T01:09:11Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Pat Thoyts wrote:\n\n> I pushed git-gui + my patches to git://git.patthoyts.tk/git-gui\n> (http://www.patthoyts.tk/gitweb.cgi?p=git-gui;a=summary)\n> so if someone wants to pull from that it is Shawn's repository plus 3.\n\nQuick thoughts:\n\nWere those patches reviewed? I assume so, but I do not see a\nReviewed-by or anything so I do not know who to blame if they\ngo awry.\n\nHere[1] is another candidate patch, though it has not received\nmuch attention, unfortunately.\n\nThanks,\nJonathan\n\n[1] http://thread.gmane.org/gmane.linux.debian.devel.bugs.general/723900/focus=150231\n"}]}