{"thread":{"id":"24151","subject":"[PATCH 0/2] git-cvsserver: Minor fixes for oopsies","startedAt":"2010-06-19T16:06:56Z","lastAt":"2010-06-19T16:06:58Z","messageCount":3,"participants":["Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"143942","messageId":"1276963618-14662-1-git-send-email-avarab@gmail.com","threadId":"24151","inReplyTo":null,"subject":"[PATCH 0/2] git-cvsserver: Minor fixes for oopsies","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-06-19T16:06:56Z","receivedAt":"2010-06-19T16:06:56Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"The original git-cvsserver pserver support had some oops code. There\nwas a typo in a comment, and the error for invalid password formats\nwasn't correct.\n\nAs an aside, since the original implementation I've released the code\non CPAN as the Crypt::CVS. That version also has a scramble() function\nand exhaustive tests.\n\nIt would make a good experimental case for adding dual-life modules to\nGit due to its smallness and the inclusion of tests.\n\nÆvar Arnfjörð Bjarmason (2):\n  git-cvsserver: typo in a comment: bas -> has\n  git-cvsserver: fix error for invalid password formats\n\n git-cvsserver.perl |    7 +++++--\n 1 files changed, 5 insertions(+), 2 deletions(-)\n"},{"id":"143943","messageId":"1276963618-14662-2-git-send-email-avarab@gmail.com","threadId":"24151","inReplyTo":"1276963618-14662-1-git-send-email-avarab@gmail.com","subject":"[PATCH 1/2] git-cvsserver: typo in a comment: bas -> has","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-06-19T16:06:57Z","receivedAt":"2010-06-19T16:06:57Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n git-cvsserver.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-cvsserver.perl b/git-cvsserver.perl\nindex 3833bee..6de7921 100755\n--- a/git-cvsserver.perl\n+++ b/git-cvsserver.perl\n@@ -2656,7 +2656,7 @@ sub descramble\n     );\n     my ($str) = @_;\n \n-    # This should never happen, the same password format (A) bas been\n+    # This should never happen, the same password format (A) has been\n     # used by CVS since the beginning of time\n     die \"invalid password format $1\" unless substr($str, 0, 1) eq 'A';\n \n-- \n1.7.1.251.g92a7\n"},{"id":"143944","messageId":"1276963618-14662-3-git-send-email-avarab@gmail.com","threadId":"24151","inReplyTo":"1276963618-14662-1-git-send-email-avarab@gmail.com","subject":"[PATCH 2/2] git-cvsserver: fix error for invalid password formats","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-06-19T16:06:58Z","receivedAt":"2010-06-19T16:06:58Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Change the error message to report the erroneous password\ncharacter. $1 was never set in the previos version, it was a leftover\nfrom older code that used a regex for the test.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n git-cvsserver.perl |    5 ++++-\n 1 files changed, 4 insertions(+), 1 deletions(-)\n\ndiff --git a/git-cvsserver.perl b/git-cvsserver.perl\nindex 6de7921..0f45c39 100755\n--- a/git-cvsserver.perl\n+++ b/git-cvsserver.perl\n@@ -2658,7 +2658,10 @@ sub descramble\n \n     # This should never happen, the same password format (A) has been\n     # used by CVS since the beginning of time\n-    die \"invalid password format $1\" unless substr($str, 0, 1) eq 'A';\n+    {\n+        my $fmt = substr($str, 0, 1);\n+        die \"invalid password format `$fmt'\" unless $fmt eq 'A';\n+    }\n \n     my @str = unpack \"C*\", substr($str, 1);\n     my $ret = join '', map { chr $SHIFTS[$_] } @str;\n-- \n1.7.1.251.g92a7\n"}]}