{"thread":{"id":"24124","subject":"[PATCH] Only run aggregate-results over actual counts","startedAt":"2010-06-15T21:36:15Z","lastAt":"2010-07-16T20:26:55Z","messageCount":5,"participants":["Thomas Rast","Sverre Rabbelier","Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"143787","messageId":"e10dd00b7a2064c71c9a509e2a7e82c935a60441.1276637243.git.trast@student.ethz.ch","threadId":"24124","inReplyTo":null,"subject":"[PATCH] Only run aggregate-results over actual counts","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2010-06-15T21:36:15Z","receivedAt":"2010-06-15T21:36:15Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"The current make target 'aggregate-results' scanned all files matching\ntest-results/t*-*.  Normally these are only the test counts (and the\nexit values, which are ignored), but with --tee the suite also dumps\nall output.  Furthermore, with --verbose t1450 contains several lines\nstarting with \"broken link from ...\" which matches the criteria used\nby aggregate-results.sh.\n\nRename the counts output files to *.counts, and only scan those.\n\nSigned-off-by: Thomas Rast <trast@student.ethz.ch>\n---\n\nDid this ever work?  Or was just nobody crazy enough to run all tests\nwith --tee --valgrind?\n\n t/Makefile    |    2 +-\n t/test-lib.sh |    2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/Makefile b/t/Makefile\nindex f9de24b..cf5f9e2 100644\n--- a/t/Makefile\n+++ b/t/Makefile\n@@ -36,7 +36,7 @@ aggregate-results-and-cleanup: $(T)\n \t$(MAKE) clean\n \n aggregate-results:\n-\tfor f in test-results/t*-*; do \\\n+\tfor f in test-results/t*-*.counts; do \\\n \t\techo \"$$f\"; \\\n \tdone | '$(SHELL_PATH_SQ)' ./aggregate-results.sh\n \ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex 37987d7..7e2cd7d 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -547,7 +547,7 @@ test_done () {\n \tGIT_EXIT_OK=t\n \ttest_results_dir=\"$TEST_DIRECTORY/test-results\"\n \tmkdir -p \"$test_results_dir\"\n-\ttest_results_path=\"$test_results_dir/${0%.sh}-$$\"\n+\ttest_results_path=\"$test_results_dir/${0%.sh}-$$.counts\"\n \n \techo \"total $test_count\" >> $test_results_path\n \techo \"success $test_success\" >> $test_results_path\n-- \n1.7.1.608.g80d39f\n"},{"id":"143788","messageId":"AANLkTil4HfoMPD4ds0uXRPruYrz4CtpAy-4TfEk0E_yT@mail.gmail.com","threadId":"24124","inReplyTo":"e10dd00b7a2064c71c9a509e2a7e82c935a60441.1276637243.git.trast@student.ethz.ch","subject":"Re: [PATCH] Only run aggregate-results over actual counts","fromName":"Sverre Rabbelier","fromEmail":"srabbelier@gmail.com","sentAt":"2010-06-15T21:44:30Z","receivedAt":"2010-06-15T21:44:30Z","isPatch":true,"sender":{"key":"srabbelier@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3098?v=4"},"body":"Heya,\n\nOn Tue, Jun 15, 2010 at 23:36, Thomas Rast <trast@student.ethz.ch> wrote:\n> Signed-off-by: Thomas Rast <trast@student.ethz.ch>\n\nFwiw:\n\nAcked-by: Sverre Rabbelier <srabbelier@gmail.com>\n\n-- \nCheers,\n\nSverre Rabbelier\n"},{"id":"145677","messageId":"3ce03e702e005a978d3229fa74860d6529296921.1279272868.git.trast@student.ethz.ch","threadId":"24124","inReplyTo":"AANLkTil4HfoMPD4ds0uXRPruYrz4CtpAy-4TfEk0E_yT@mail.gmail.com","subject":"[PATCH resend] Only run aggregate-results over actual counts","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2010-07-16T09:37:44Z","receivedAt":"2010-07-16T09:37:44Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"The current make target 'aggregate-results' scanned all files matching\ntest-results/t*-*.  Normally these are only the test counts (and the\nexit values, which are ignored), but with --tee the suite also dumps\nall output.  Furthermore, with --verbose t1450 contains several lines\nstarting with \"broken link from ...\" which matches the criteria used\nby aggregate-results.sh.\n\nRename the counts output files to *.counts, and only scan those.\n\nSigned-off-by: Thomas Rast <trast@student.ethz.ch>\nAcked-by: Sverre Rabbelier <srabbelier@gmail.com>\n---\n t/Makefile    |    2 +-\n t/test-lib.sh |    2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/Makefile b/t/Makefile\nindex f9de24b..cf5f9e2 100644\n--- a/t/Makefile\n+++ b/t/Makefile\n@@ -36,7 +36,7 @@ aggregate-results-and-cleanup: $(T)\n \t$(MAKE) clean\n \n aggregate-results:\n-\tfor f in test-results/t*-*; do \\\n+\tfor f in test-results/t*-*.counts; do \\\n \t\techo \"$$f\"; \\\n \tdone | '$(SHELL_PATH_SQ)' ./aggregate-results.sh\n \ndiff --git a/t/test-lib.sh b/t/test-lib.sh\nindex ac496aa..83a5a84 100644\n--- a/t/test-lib.sh\n+++ b/t/test-lib.sh\n@@ -635,7 +635,7 @@ test_done () {\n \tGIT_EXIT_OK=t\n \ttest_results_dir=\"$TEST_DIRECTORY/test-results\"\n \tmkdir -p \"$test_results_dir\"\n-\ttest_results_path=\"$test_results_dir/${0%.sh}-$$\"\n+\ttest_results_path=\"$test_results_dir/${0%.sh}-$$.counts\"\n \n \techo \"total $test_count\" >> $test_results_path\n \techo \"success $test_success\" >> $test_results_path\n-- \n1.7.2.rc3.259.g43154\n"},{"id":"145693","messageId":"AANLkTin1BQTWj7AiEuWibanhVKu6UBJmn1iKEF-DB-s9@mail.gmail.com","threadId":"24124","inReplyTo":"3ce03e702e005a978d3229fa74860d6529296921.1279272868.git.trast@student.ethz.ch","subject":"Re: [PATCH resend] Only run aggregate-results over actual counts","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-07-16T14:27:02Z","receivedAt":"2010-07-16T14:27:02Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Fri, Jul 16, 2010 at 09:37, Thomas Rast <trast@student.ethz.ch> wrote:\n> The current make target 'aggregate-results' scanned all files matching\n> test-results/t*-*.  Normally these are only the test counts (and the\n> exit values, which are ignored), but with --tee the suite also dumps\n> all output.  Furthermore, with --verbose t1450 contains several lines\n> starting with \"broken link from ...\" which matches the criteria used\n> by aggregate-results.sh.\n>\n> Rename the counts output files to *.counts, and only scan those.\n>\n> Signed-off-by: Thomas Rast <trast@student.ethz.ch>\n> Acked-by: Sverre Rabbelier <srabbelier@gmail.com>\n\nAcked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n\n> --- a/t/test-lib.sh\n> +++ b/t/test-lib.sh\n> @@ -635,7 +635,7 @@ test_done () {\n>        GIT_EXIT_OK=t\n>        test_results_dir=\"$TEST_DIRECTORY/test-results\"\n>        mkdir -p \"$test_results_dir\"\n> -       test_results_path=\"$test_results_dir/${0%.sh}-$$\"\n> +       test_results_path=\"$test_results_dir/${0%.sh}-$$.counts\"\n>\n>        echo \"total $test_count\" >> $test_results_path\n>        echo \"success $test_success\" >> $test_results_path\n\nFor Junio: FYI this bumps into my \"test-lib: Don't write test-results\nwhen HARNESS_ACTIVE\" patch in flight. The fixup is trivial though.\n"},{"id":"145708","messageId":"7vfwzjrx4g.fsf@alter.siamese.dyndns.org","threadId":"24124","inReplyTo":"3ce03e702e005a978d3229fa74860d6529296921.1279272868.git.trast@student.ethz.ch","subject":"Re: [PATCH resend] Only run aggregate-results over actual counts","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-07-16T20:26:55Z","receivedAt":"2010-07-16T20:26:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}