{"thread":{"id":"24091","subject":"[PATCH] gitweb: Fix typo in hash key name in %opts in git_header_html","startedAt":"2010-06-12T22:35:59Z","lastAt":"2010-06-12T22:35:59Z","messageCount":1,"participants":["Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"143593","messageId":"20100612223425.19002.86147.stgit@localhost.localdomain","threadId":"24091","inReplyTo":null,"subject":"[PATCH] gitweb: Fix typo in hash key name in %opts in git_header_html","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-06-12T22:35:59Z","receivedAt":"2010-06-12T22:35:59Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"The name of the key has to be the same in call site handle_errors_html\nand in called subroutine that uses it, i.e. git_header_html.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nI'm sorry about that.  Stupid mistake.\n\nI have noticed this when working (again) on gitweb output caching\nseries.  There was toss-up on which version ''-no_http_headers'\nor '-no_http_header' to choose.\n\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 934aacb..e108bbc 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -3220,7 +3220,7 @@ sub git_header_html {\n \t}\n \tprint $cgi->header(-type=>$content_type, -charset => 'utf-8',\n \t                   -status=> $status, -expires => $expires)\n-\t\tunless ($opts{'-no_http_headers'});\n+\t\tunless ($opts{'-no_http_header'});\n \tmy $mod_perl_version = $ENV{'MOD_PERL'} ? \" $ENV{'MOD_PERL'}\" : '';\n \tprint <<EOF;\n <?xml version=\"1.0\" encoding=\"utf-8\"?>\n"}]}