{"thread":{"id":"2406","subject":"[PATCH] sparse fixes for http-{fetch,push}.c","startedAt":"2005-11-08T22:18:31Z","lastAt":"2005-11-08T22:18:31Z","messageCount":1,"participants":["Peter Hagervall"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"11353","messageId":"20051108221830.GA14318@peppar.cs.umu.se","threadId":"2406","inReplyTo":null,"subject":"[PATCH] sparse fixes for http-{fetch,push}.c","fromName":"Peter Hagervall","fromEmail":"hager@cs.umu.se","sentAt":"2005-11-08T22:18:31Z","receivedAt":"2005-11-08T22:18:31Z","isPatch":true,"sender":{"key":"hager@cs.umu.se","avatar":null},"body":"Make a bunch of needlessly global functions static, and replace two\nK&R-style declarations.\n\nSigned-off-by: Peter Hagervall <hager@cs.umu.se>\n---\n\ndiff --git a/http-fetch.c b/http-fetch.c\nindex ea8af1b..88b74b4 100644\n--- a/http-fetch.c\n+++ b/http-fetch.c\n@@ -569,7 +569,7 @@ static void release_request(struct trans\n }\n \n #ifdef USE_CURL_MULTI\n-void process_curl_messages(void)\n+static void process_curl_messages(void)\n {\n \tint num_messages;\n \tstruct active_request_slot *slot;\n@@ -625,7 +625,7 @@ void process_curl_messages(void)\n \t}\n }\n \n-void process_request_queue(void)\n+static void process_request_queue(void)\n {\n \tstruct transfer_request *request = request_queue_head;\n \tstruct active_request_slot *slot = active_queue_head;\ndiff --git a/http-push.c b/http-push.c\nindex 0b90fb9..8866189 100644\n--- a/http-push.c\n+++ b/http-push.c\n@@ -595,7 +595,7 @@ static void start_move(struct transfer_r\n \t}\n }\n \n-int refresh_lock(struct active_lock *lock)\n+static int refresh_lock(struct active_lock *lock)\n {\n \tstruct active_request_slot *slot;\n \tchar *if_header;\n@@ -726,7 +726,7 @@ static void release_request(struct trans\n }\n \n #ifdef USE_CURL_MULTI\n-void process_curl_messages(void)\n+static void process_curl_messages(void)\n {\n \tint num_messages;\n \tstruct active_request_slot *slot;\n@@ -766,7 +766,7 @@ void process_curl_messages(void)\n \t}\n }\n \n-void process_request_queue(void)\n+static void process_request_queue(void)\n {\n \tstruct transfer_request *request = request_queue_head;\n \tstruct active_request_slot *slot = active_queue_head;\n@@ -799,7 +799,7 @@ void process_request_queue(void)\n }\n #endif\n \n-void process_waiting_requests(void)\n+static void process_waiting_requests(void)\n {\n \tstruct active_request_slot *slot = active_queue_head;\n \n@@ -812,7 +812,7 @@ void process_waiting_requests(void)\n \t\t}\n }\n \n-void add_request(unsigned char *sha1, struct active_lock *lock)\n+static void add_request(unsigned char *sha1, struct active_lock *lock)\n {\n \tstruct transfer_request *request = request_queue_head;\n \tstruct packed_git *target;\n@@ -939,7 +939,7 @@ static int setup_index(unsigned char *sh\n \treturn 0;\n }\n \n-static int fetch_indices()\n+static int fetch_indices(void)\n {\n \tunsigned char sha1[20];\n \tchar *url;\n@@ -1189,7 +1189,7 @@ end_lockprop_element(void *userData, con\n \t}\n }\n \n-struct active_lock *lock_remote(char *file, long timeout)\n+static struct active_lock *lock_remote(char *file, long timeout)\n {\n \tstruct active_request_slot *slot;\n \tstruct buffer out_buffer;\n@@ -1318,7 +1318,7 @@ struct active_lock *lock_remote(char *fi\n \treturn new_lock;\n }\n \n-int unlock_remote(struct active_lock *lock)\n+static int unlock_remote(struct active_lock *lock)\n {\n \tstruct active_request_slot *slot;\n \tchar *lock_token_header;\n@@ -1359,7 +1359,7 @@ int unlock_remote(struct active_lock *lo\n \treturn rc;\n }\n \n-int check_locking()\n+static int check_locking(void)\n {\n \tstruct active_request_slot *slot;\n \tstruct buffer in_buffer;\n@@ -1425,7 +1425,7 @@ int check_locking()\n \t\treturn 1;\n }\n \n-int is_ancestor(unsigned char *sha1, struct commit *commit)\n+static int is_ancestor(unsigned char *sha1, struct commit *commit)\n {\n \tstruct commit_list *parents;\n \n@@ -1446,8 +1446,8 @@ int is_ancestor(unsigned char *sha1, str\n \treturn 0;\n }\n \n-void get_delta(unsigned char *sha1, struct object *obj,\n-\t       struct active_lock *lock)\n+static void get_delta(unsigned char *sha1, struct object *obj,\n+\t\t      struct active_lock *lock)\n {\n \tstruct commit *commit;\n \tstruct commit_list *parents;\n@@ -1503,7 +1503,7 @@ void get_delta(unsigned char *sha1, stru\n \t}\n }\n \n-int update_remote(unsigned char *sha1, struct active_lock *lock)\n+static int update_remote(unsigned char *sha1, struct active_lock *lock)\n {\n \tstruct active_request_slot *slot;\n \tchar *out_data;\n"}]}