{"thread":{"id":"23969","subject":"[PATCH] Makefile: Use $(sharedir)/gitweb for target 'install-gitweb'","startedAt":"2010-06-01T15:11:20Z","lastAt":"2010-06-02T14:49:04Z","messageCount":4,"participants":["Pavan Kumar Sunkara","Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"142692","messageId":"1275405080-17326-1-git-send-email-pavan.sss1991@gmail.com","threadId":"23969","inReplyTo":null,"subject":"[PATCH] Makefile: Use $(sharedir)/gitweb for target 'install-gitweb'","fromName":"Pavan Kumar Sunkara","fromEmail":"pavan.sss1991@gmail.com","sentAt":"2010-06-01T15:11:20Z","receivedAt":"2010-06-01T15:11:20Z","isPatch":true,"sender":{"key":"pavan.sss1991@gmail.com","avatar":"https://avatars.githubusercontent.com/u/174703?v=4"},"body":"Export gitwebdir variable so that when user types the command\n'make install-gitweb', gitweb is installed in $(sharedir)/gitweb\nrather than /var/www/cgi-bin. Now, $(sharedir)/gitweb is default\nfor both 'install' and 'install-gitweb' targets.\n\nRemove 'gitwebdir=$(gitwebdir_SQ)' from gitweb part of 'install'\ntarget which is unneccessary now.\n\nSigned-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>\n---\n Makefile |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 8f011a5..32e3146 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -294,7 +294,7 @@ lib = lib\n # DESTDIR=\n pathsep = :\n \n-export prefix bindir sharedir sysconfdir\n+export prefix bindir sharedir gitwebdir sysconfdir\n \n CC = gcc\n AR = ar\n@@ -2049,7 +2049,7 @@ install: all\n \t$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install\n ifndef NO_PERL\n \t$(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install\n-\t$(MAKE) -C gitweb gitwebdir=$(gitwebdir_SQ) install\n+\t$(MAKE) -C gitweb install\n endif\n ifndef NO_PYTHON\n \t$(MAKE) -C git_remote_helpers prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install\n-- \n1.7.1.447.g40f7.dirty\n"},{"id":"142722","messageId":"201006012150.02970.jnareb@gmail.com","threadId":"23969","inReplyTo":"1275405080-17326-1-git-send-email-pavan.sss1991@gmail.com","subject":"Re: [PATCH] Makefile: Use $(sharedir)/gitweb for target 'install-gitweb'","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-06-01T19:50:02Z","receivedAt":"2010-06-01T19:50:02Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Tue, 1 June 2010, Pavan Kumar Sunkara wrote:\n\n> Export gitwebdir variable so that when user types the command\n> 'make install-gitweb', gitweb is installed in $(sharedir)/gitweb\n> rather than /var/www/cgi-bin. Now, $(sharedir)/gitweb is default\n> for both 'install' and 'install-gitweb' targets.\n> \n> Remove 'gitwebdir=$(gitwebdir_SQ)' from gitweb part of 'install'\n> target which is unneccessary now.\n> \n> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>\n\nFor what it is worth:\n\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n\n(But I have not tested it!)\n\n> ---\n>  Makefile |    4 ++--\n>  1 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/Makefile b/Makefile\n> index 8f011a5..32e3146 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -294,7 +294,7 @@ lib = lib\n>  # DESTDIR=\n>  pathsep = :\n>  \n> -export prefix bindir sharedir sysconfdir\n> +export prefix bindir sharedir gitwebdir sysconfdir\n\nNitpick: why not\n\n  +export prefix bindir sharedir sysconfdir gitwebdir\n\ni.e. have 'gitwebdir' last?  Not that it matters, though....\n\n>  \n>  CC = gcc\n>  AR = ar\n> @@ -2049,7 +2049,7 @@ install: all\n>  \t$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install\n>  ifndef NO_PERL\n>  \t$(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install\n> -\t$(MAKE) -C gitweb gitwebdir=$(gitwebdir_SQ) install\n> +\t$(MAKE) -C gitweb install\n\nNice.\n\n>  endif\n>  ifndef NO_PYTHON\n>  \t$(MAKE) -C git_remote_helpers prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install\n> -- \n> 1.7.1.447.g40f7.dirty\n> \n> \n\n-- \nJakub Narebski\nPoland\n"},{"id":"142760","messageId":"7vfx16qcmm.fsf@alter.siamese.dyndns.org","threadId":"23969","inReplyTo":"201006012150.02970.jnareb@gmail.com","subject":"Re: [PATCH] Makefile: Use $(sharedir)/gitweb for target 'install-gitweb'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-06-02T04:31:13Z","receivedAt":"2010-06-02T04:31:13Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n> On Tue, 1 June 2010, Pavan Kumar Sunkara wrote:\n>\n>> Export gitwebdir variable so that when user types the command\n>> 'make install-gitweb', gitweb is installed in $(sharedir)/gitweb\n>> rather than /var/www/cgi-bin. Now, $(sharedir)/gitweb is default\n>> for both 'install' and 'install-gitweb' targets.\n>> \n>> Remove 'gitwebdir=$(gitwebdir_SQ)' from gitweb part of 'install'\n>> target which is unneccessary now.\n>> \n>> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>\n>\n> For what it is worth:\n>\n> Acked-by: Jakub Narebski <jnareb@gmail.com>\n>\n> (But I have not tested it!)\n\nI am wondering if we would also want to do something with this line\n\n    gitwebdir ?= /var/www/cgi-bin\n\nin gitweb/Makefile.  This is orthogonal to the patch under discussion\ndoes, though.\n"},{"id":"142822","messageId":"AANLkTinIaY65N_DyDq6RrS6AyLeksL_ZfiawwDZySzB3@mail.gmail.com","threadId":"23969","inReplyTo":"7vfx16qcmm.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Makefile: Use $(sharedir)/gitweb for target 'install-gitweb'","fromName":"Pavan Kumar Sunkara","fromEmail":"pavan.sss1991@gmail.com","sentAt":"2010-06-02T14:49:04Z","receivedAt":"2010-06-02T14:49:04Z","isPatch":true,"sender":{"key":"pavan.sss1991@gmail.com","avatar":"https://avatars.githubusercontent.com/u/174703?v=4"},"body":">\n> I am wondering if we would also want to do something with this line\n>\n>    gitwebdir ?= /var/www/cgi-bin\n>\n> in gitweb/Makefile.  This is orthogonal to the patch under discussion\n> does, though.\n>\n>\n\nWell, Let us say that we use /var/www/cgi-bin as default if user\ndownloads only gitweb and install it.\nIf he is installing git, then gitweb needs to be installed in\n$(sharedir)/gitweb. Putting it as default in main Makefile is\nsupported.\n\nSo, It won't be orthogonal to the patch.\n\nThanks,\nPavan.\n"}]}