{"thread":{"id":"2396","subject":"ls-files and read-tree need core.filemode","startedAt":"2005-11-08T08:23:37Z","lastAt":"2005-11-08T18:15:27Z","messageCount":4,"participants":["Alex Riesen","Junio C Hamano","Linus Torvalds"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"11306","messageId":"81b0412b0511080023k1384dc26j944e9a07987be436@mail.gmail.com","threadId":"2396","inReplyTo":null,"subject":"ls-files and read-tree need core.filemode","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2005-11-08T08:23:37Z","receivedAt":"2005-11-08T08:23:37Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Hi,\n\nls-files.c and read-tree.c miss the default configuration, in\nparticular the filemode=false part.\nThe recent +x bit flip made me notice that, because git-merge refused\nto merge anything saying that git-pull.sh is not up to date.\n\nAs usual, sorry for attachments.\n"},{"id":"11308","messageId":"7vacgfldry.fsf@assigned-by-dhcp.cox.net","threadId":"2396","inReplyTo":"81b0412b0511080023k1384dc26j944e9a07987be436@mail.gmail.com","subject":"Re: ls-files and read-tree need core.filemode","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-11-08T08:55:29Z","receivedAt":"2005-11-08T08:55:29Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alex Riesen <raa.lkml@gmail.com> writes:\n\n> As usual, sorry for attachments.\n\nAttachments are a bit cumbersome to quote but otherwise OK, at\nleast for me.  Linus never admits it, but I am hoping that he is\nhaving a bit easier time applying e-mailed patches ever since\nrudimentally MIME attachment handling was added.\n\nHowever, please note that git-mailinfo which splits a piece of\ne-mail into metainformation and patch part takes commit log\nmaterial only from the main message part, so having this\none-line explanation inside attachment is like having it under\nthe three-dash line.\n\n>>    ls-files needs default config to ignore filemode on cygwin\n\nI think this case you meant to do that; your main message part\nwas almost fine as is, as a commit log message (except perhaps\nthe initial \"Hi,\" part ;-).\n\n>>diff --git a/ls-files.c b/ls-files.c\n>>--- a/ls-files.c\n>>+++ b/ls-files.c\n>>@@ -569,10 +569,11 @@ int main(int argc, const char **argv)\n>> \targv0 = *argv;\n\nI wonder what this thing is, though.  I sense that usage()\ncleanup patch that makes programs state their names\nsemi-automatically is coming...\n"},{"id":"11310","messageId":"81b0412b0511080139k19bb0e0ep408d936cad9ac4b8@mail.gmail.com","threadId":"2396","inReplyTo":"7vacgfldry.fsf@assigned-by-dhcp.cox.net","subject":"Re: ls-files and read-tree need core.filemode","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2005-11-08T09:39:58Z","receivedAt":"2005-11-08T09:39:58Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 11/8/05, Junio C Hamano <junkio@cox.net> wrote:\n> However, please note that git-mailinfo which splits a piece of\n> e-mail into metainformation and patch part takes commit log\n> material only from the main message part, so having this\n> one-line explanation inside attachment is like having it under\n> the three-dash line.\n\nNoted, thanks!\n\n> >>diff --git a/ls-files.c b/ls-files.c\n> >>--- a/ls-files.c\n> >>+++ b/ls-files.c\n> >>@@ -569,10 +569,11 @@ int main(int argc, const char **argv)\n> >>      argv0 = *argv;\n>\n> I wonder what this thing is, though.  I sense that usage()\n> cleanup patch that makes programs state their names\n> semi-automatically is coming...\n>\n\nThat's just me, trying to figure out were all the errors were coming from.\nPromise to try to base patches properly in the future.\n"},{"id":"11337","messageId":"Pine.LNX.4.64.0511081010510.3247@g5.osdl.org","threadId":"2396","inReplyTo":"7vacgfldry.fsf@assigned-by-dhcp.cox.net","subject":"Re: ls-files and read-tree need core.filemode","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-11-08T18:15:27Z","receivedAt":"2005-11-08T18:15:27Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Tue, 8 Nov 2005, Junio C Hamano wrote:\n> \n> Attachments are a bit cumbersome to quote but otherwise OK, at\n> least for me.  Linus never admits it, but I am hoping that he is\n> having a bit easier time applying e-mailed patches ever since\n> rudimentally MIME attachment handling was added.\n\nActually, the MIME attachment support in git means that I have to remove \nthe \"Content-Type: .. boundary: \" line too when editing emails. \n\nI do all my patch validation in mbox format (which is why when you look at \ncommit dates, you'll generally see a second or less between commits when I \nactually apply a mbox series), and the MIME format makes emails totally \nunreadable.\n\nSo I refuse to have anything to do with attachments and MIME types not \nbecause my tools couldn't apply the patches, but because I can't go \nthrough the patches manually sanely with them.\n\nSo I can do plain/text attachments, but they inevitably mean that I just \nhave to edit the damn mailbox to make sense of it. Anything else (like \nbase64-encoding or similar) I just refuse to touch.\n\n\t\t\tLinus\n"}]}