{"thread":{"id":"23948","subject":"[PATCH] Makefile: remove redundant munging of @@INSTLIBDIR@@","startedAt":"2010-05-30T17:12:41Z","lastAt":"2010-05-30T17:12:41Z","messageCount":1,"participants":["Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"142579","messageId":"1275239561-31437-1-git-send-email-avarab@gmail.com","threadId":"23948","inReplyTo":null,"subject":"[PATCH] Makefile: remove redundant munging of @@INSTLIBDIR@@","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-05-30T17:12:41Z","receivedAt":"2010-05-30T17:12:41Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Junio originally added this in f6276fe159 for use in `unshift @INC,\n'@@INSTLIBDIR@@'' in git-fmt-merge-msg.perl. That program was since\nthen rewritten in C in 00449f992b. And since 6fcca938b0 all Perl\nprograms use `use lib' to set their @INC path.\n\nThere's been no @@INSTLIBDIR@@ in any Perl script to replace since\nthen. So there's no reason to keep it around.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n\nI saw this when doing Perl/Gettext support. @@INSTLIBDIR@@ hasn't been\nused for anything but the 'use lib' line there since mid-2006.\n\n Makefile |    3 +--\n 1 files changed, 1 insertions(+), 2 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex d5d6565..64e30db 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1562,11 +1562,10 @@ $(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl\n \tsed -e '1{' \\\n \t    -e '\ts|#!.*perl|#!$(PERL_PATH_SQ)|' \\\n \t    -e '\th' \\\n-\t    -e '\ts=.*=use lib (split(/$(pathsep)/, $$ENV{GITPERLLIB} || \"@@INSTLIBDIR@@\"));=' \\\n+\t    -e '\ts=.*=use lib (split(/$(pathsep)/, $$ENV{GITPERLLIB} || \"'\"$$INSTLIBDIR\"'\"));=' \\\n \t    -e '\tH' \\\n \t    -e '\tx' \\\n \t    -e '}' \\\n-\t    -e 's|@@INSTLIBDIR@@|'\"$$INSTLIBDIR\"'|g' \\\n \t    -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' \\\n \t    $@.perl >$@+ && \\\n \tchmod +x $@+ && \\\n-- \n1.7.1.237.gf48e9\n"}]}