{"thread":{"id":"23753","subject":"[PATCH 1/2] Makefile: fix header dependency checker to allow NO_CURL builds","startedAt":"2010-05-09T03:55:36Z","lastAt":"2010-05-09T04:00:10Z","messageCount":3,"participants":["Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"141289","messageId":"20100509035536.GA8118@progeny.tock","threadId":"23753","inReplyTo":null,"subject":"[PATCH 0/2] Makefile: header dependency checker fixes","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-05-09T03:55:36Z","receivedAt":"2010-05-09T03:55:36Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Two fixes to make the CHECK_HEADER_DEPENDENCIES facility more\nusable.  Now you can\n\n echo >>config.mak NO_CURL = YesPlease\n echo >>config.mak COMPUTE_HEADER_DEPENDENCIES = YesPlease\n make -j16\n make -j16 CHECK_HEADER_DEPENDENCIES=Yep\n\non some super-fast machine without libcurl-dev installed and\nit will check the header dependencies for the rest of the makefile.\n\nPreviously it would error out for two reasons:\n\n - COMPUTE_HEADER_DEPENDENCIES and CHECK_HEADER_DEPENDENCIES\n   are incompatible\n\n - the safety to make sure the automatically computed header\n   dependencies were present did not understand that HTTP support\n   is missing\n\nThis is nothing urgent, just nice to have.  I’d be glad to carry\nthem locally if that’s more convenient.\n\nJonathan Nieder (2):\n  Makefile: fix header dependency checker to allow NO_CURL builds\n  Makefile: let header dependency checker override\n    COMPUTE_HEADER_DEPENDENCIES\n\n Makefile |    6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n"},{"id":"141288","messageId":"20100509035728.GA8198@progeny.tock","threadId":"23753","inReplyTo":"20100509035536.GA8118@progeny.tock","subject":"[PATCH 1/2] Makefile: fix header dependency checker to allow NO_CURL builds","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-05-09T03:57:28Z","receivedAt":"2010-05-09T03:57:28Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Do not expect to find http-related dependency fragments after a build\nwith HTTP support disabled.\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\n Makefile |    5 ++++-\n 1 files changed, 4 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 910f471..567b859 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1656,7 +1656,10 @@ git.o git.spec \\\n \n TEST_OBJS := $(patsubst test-%$X,test-%.o,$(TEST_PROGRAMS))\n GIT_OBJS := $(LIB_OBJS) $(BUILTIN_OBJS) $(PROGRAM_OBJS) $(TEST_OBJS) \\\n-\tgit.o http.o http-walker.o remote-curl.o\n+\tgit.o\n+ifndef NO_CURL\n+\tGIT_OBJS += http.o http-walker.o remote-curl.o\n+endif\n XDIFF_OBJS = xdiff/xdiffi.o xdiff/xprepare.o xdiff/xutils.o xdiff/xemit.o \\\n \txdiff/xmerge.o xdiff/xpatience.o\n OBJECTS := $(GIT_OBJS) $(XDIFF_OBJS)\n-- \n1.7.1\n"},{"id":"141290","messageId":"20100509040010.GB8198@progeny.tock","threadId":"23753","inReplyTo":"20100509035536.GA8118@progeny.tock","subject":"[PATCH 2/2] Makefile: let header dependency checker override COMPUTE_HEADER_DEPENDENCIES","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-05-09T04:00:10Z","receivedAt":"2010-05-09T04:00:10Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"This way, if you have “COMPUTE_HEADER_DEPENDENCIES = YesPlease” in your\nconfig.mak, you can still “make CHECK_HEADER_DEPENDENCIES=Yes” to check\nthe makefile after a successful build.\n\nThis change does not affect the result of the command\n“make CHECK_HEADER_DEPENDENCIES=Yes COMPUTE_HEADER_DEPENDENCIES=Yes”.\nThat will still die with an error message:\n\n\tcannot compute header dependencies outside a normal build\n\nThe message is appropriate because still true.\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\n Makefile |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 567b859..0025b98 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1063,6 +1063,7 @@ endif\n -include config.mak\n \n ifdef CHECK_HEADER_DEPENDENCIES\n+COMPUTE_HEADER_DEPENDENCIES =\n USE_COMPUTED_HEADER_DEPENDENCIES =\n endif\n \n-- \n1.7.1\n"}]}