{"thread":{"id":"23707","subject":"[PATCH] Documentation/config.txt: Move GIT_NOTES_REWRITE_REF to notes.rewriteRef","startedAt":"2010-05-05T13:35:16Z","lastAt":"2010-05-05T14:16:25Z","messageCount":4,"participants":["Leif Arne Storset","Thomas Rast"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"140983","messageId":"1273066516-24469-1-git-send-email-lstorset@opera.com","threadId":"23707","inReplyTo":null,"subject":"[PATCH] Documentation/config.txt: Move GIT_NOTES_REWRITE_REF to notes.rewriteRef","fromName":"Leif Arne Storset","fromEmail":"lstorset@opera.com","sentAt":"2010-05-05T13:35:16Z","receivedAt":"2010-05-05T13:35:16Z","isPatch":true,"sender":{"key":"lstorset@opera.com","avatar":"https://gravatar.com/avatar/ae01feeb1a39b6e835d6b665cabde208a7dda6e45727f7de5b40d89a63d59de4?d=mp&s=160"},"body":"Was notes.rewrite. The environment variable refers to globs and refs, which are only mentioned by notes.rewriteRef; notes.rewrite is boolean.\n\nSigned-off-by: Leif Arne Storset \n---\nThis should be a trivial fix.\n\n Documentation/config.txt | 8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 92f851e..8f86050 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1359,10 +1359,6 @@ notes.rewrite.::\n \tautomatically copies your notes from the original to the\n \trewritten commit. Defaults to `true`, but see\n \t\"notes.rewriteRef\" below.\n-+\n-This setting can be overridden with the `GIT_NOTES_REWRITE_REF`\n-environment variable, which must be a colon separated list of refs or\n-globs.\n \n notes.rewriteMode::\n \tWhen copying notes during a rewrite (see the\n@@ -1382,6 +1378,10 @@ notes.rewriteRef::\n +\n Does not have a default value; you must configure this variable to\n enable note rewriting.\n++\n+This setting can be overridden with the `GIT_NOTES_REWRITE_REF`\n+environment variable, which must be a colon separated list of refs or\n+globs.\n \n pack.window::\n \tThe size of the window used by linkgit:git-pack-objects[1] when no\n-- \n1.7.1\n"},{"id":"140984","messageId":"201005051600.03446.trast@student.ethz.ch","threadId":"23707","inReplyTo":"1273066516-24469-1-git-send-email-lstorset@opera.com","subject":"Re: [PATCH] Documentation/config.txt: Move GIT_NOTES_REWRITE_REF to notes.rewriteRef","fromName":"Thomas Rast","fromEmail":"trast@student.ethz.ch","sentAt":"2010-05-05T14:00:03Z","receivedAt":"2010-05-05T14:00:03Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Leif Arne Storset wrote:\n> Was notes.rewrite. The environment variable refers to globs and refs, which are only mentioned by notes.rewriteRef; notes.rewrite is boolean.\n> \n> Signed-off-by: Leif Arne Storset \n> ---\n> This should be a trivial fix.\n\nACK and thanks for spotting this. Putting it in the wrong place was\nmy fault.\n\nI found the commit message confusing, though (my first thought was \"we\nhave a notes.rewrite configuration variable?\"), and you also have a\nway too long line there. How about\n\n Documentation/config.txt: GIT_NOTES_REWRITE_REF overrides notes.rewriteRef\n\n The documentation erroneously mentions the GIT_NOTES_REWRITE_REF\n override in the description of notes.rewrite.. Move it\n under notes.rewriteRef where it belongs.\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"140987","messageId":"op.vb8kjmmktmo5g6@nynorsk","threadId":"23707","inReplyTo":"201005051600.03446.trast@student.ethz.ch","subject":"Re: [PATCH] Documentation/config.txt: Move GIT_NOTES_REWRITE_REF to notes.rewriteRef","fromName":"Leif Arne Storset","fromEmail":"lstorset@opera.com","sentAt":"2010-05-05T14:15:12Z","receivedAt":"2010-05-05T14:15:12Z","isPatch":true,"sender":{"key":"lstorset@opera.com","avatar":"https://gravatar.com/avatar/ae01feeb1a39b6e835d6b665cabde208a7dda6e45727f7de5b40d89a63d59de4?d=mp&s=160"},"body":"Thomas Rast skreiv Wed, 05 May 2010 16:00:03 +0200\n\n> Leif Arne Storset wrote:\n>> Was notes.rewrite. The environment variable refers to globs and refs, \n>> which are only mentioned by notes.rewriteRef; notes.rewrite is boolean.\n>>\n>> Signed-off-by: Leif Arne Storset \n>> ---\n>> This should be a trivial fix.\n>\n> ACK and thanks for spotting this. Putting it in the wrong place was\n> my fault.\n>\n> I found the commit message confusing, though (my first thought was \"we\n> have a notes.rewrite configuration variable?\"), and you also have a\n\nYeah, I misread it as notes.rewrite.\n\n> way too long line there. How about\n>\n> Documentation/config.txt: GIT_NOTES_REWRITE_REF overrides \n> notes.rewriteRef\n>\n> The documentation erroneously mentions the GIT_NOTES_REWRITE_REF\n> override in the description of notes.rewrite.. Move it\n> under notes.rewriteRef where it belongs.\n\nThanks, looks good. I suppose I should file a PATCH v2 now, it'll be along \nin a minute.\n\n-- \nLeif Arne Storset\nCore Technology Developer, Opera Software\nOslo, Norway\n"},{"id":"140988","messageId":"1273068985-25380-1-git-send-email-lstorset@opera.com","threadId":"23707","inReplyTo":"201005051600.03446.trast@student.ethz.ch","subject":"[PATCH] Documentation/config.txt: GIT_NOTES_REWRITE_REF overrides notes.rewriteRef","fromName":"Leif Arne Storset","fromEmail":"lstorset@opera.com","sentAt":"2010-05-05T14:16:25Z","receivedAt":"2010-05-05T14:16:25Z","isPatch":true,"sender":{"key":"lstorset@opera.com","avatar":"https://gravatar.com/avatar/ae01feeb1a39b6e835d6b665cabde208a7dda6e45727f7de5b40d89a63d59de4?d=mp&s=160"},"body":"The documentation erroneously mentions the GIT_NOTES_REWRITE_REF\noverride in the description of notes.rewrite.. Move it\nunder notes.rewriteRef where it belongs.\n\nSigned-off-by: Leif Arne Storset \nAcked-by: Thomas Rast \n---\n Documentation/config.txt | 8 ++++----\n 1 files changed, 4 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/config.txt b/Documentation/config.txt\nindex 92f851e..8f86050 100644\n--- a/Documentation/config.txt\n+++ b/Documentation/config.txt\n@@ -1359,10 +1359,6 @@ notes.rewrite.::\n \tautomatically copies your notes from the original to the\n \trewritten commit. Defaults to `true`, but see\n \t\"notes.rewriteRef\" below.\n-+\n-This setting can be overridden with the `GIT_NOTES_REWRITE_REF`\n-environment variable, which must be a colon separated list of refs or\n-globs.\n \n notes.rewriteMode::\n \tWhen copying notes during a rewrite (see the\n@@ -1382,6 +1378,10 @@ notes.rewriteRef::\n +\n Does not have a default value; you must configure this variable to\n enable note rewriting.\n++\n+This setting can be overridden with the `GIT_NOTES_REWRITE_REF`\n+environment variable, which must be a colon separated list of refs or\n+globs.\n \n pack.window::\n \tThe size of the window used by linkgit:git-pack-objects[1] when no\n-- \n1.7.1\n"}]}