{"thread":{"id":"237","subject":"[ANNOUNCE] git-pasky-0.6.3 && request for testing","startedAt":"2005-04-22T03:09:31Z","lastAt":"2005-04-23T05:12:35Z","messageCount":10,"participants":["Petr Baudis","Steven Cole","Greg KH","Barry K. Nathan","Linus Torvalds"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"1234","messageId":"20050422030931.GA14565@pasky.ji.cz","threadId":"237","inReplyTo":null,"subject":"[ANNOUNCE] git-pasky-0.6.3 && request for testing","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2005-04-22T03:09:31Z","receivedAt":"2005-04-22T03:09:31Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"  Hello,\n\n  FYI, I've released git-pasky-0.6.3 earlier in the night. It brings\nespecially plenty of bugfixes, but also some tiny enhancements, like\ncolored log and ability to pick branch in the remote repository. git log\nand git patch now also accept range of commits, so e.g. if you do\n\n\tgit patch linus:this\n\nyou should get a sequence of patches (commit message + patch, with\ndelimiters between patches) which will bring you from linus to your\ncurrent HEAD. Of course the package is in sync with Linus' branch.\n\n  Get it at\n\n\thttp://pasky.or.cz/~pasky/dev/git/\n\nor pull (it should work fine, no format changes).\n\n\n  Not released stay changes I made later tonight, which change\ngit-pasky's usage of directory cache - it will record adds/removals to\nit and use diff-cache instead of show-diff to check any differences. The\ncode is much simpler, but likely some small bugs were introduced in the\nprocess - please report any problems you'll hit, and test heavily. What\nis known is that you cannot diff specific files now.\n\n  Thanks,\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nC++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor\n"},{"id":"1237","messageId":"200504212158.14898.elenstev@mesatop.com","threadId":"237","inReplyTo":"20050422030931.GA14565@pasky.ji.cz","subject":"Re: [ANNOUNCE] git-pasky-0.6.3 && request for testing","fromName":"Steven Cole","fromEmail":"elenstev@mesatop.com","sentAt":"2005-04-22T03:58:14Z","receivedAt":"2005-04-22T03:58:14Z","isPatch":false,"sender":{"key":"elenstev@mesatop.com","avatar":null},"body":"On Thursday 21 April 2005 09:09 pm, Petr Baudis wrote:\n>   Hello,\n> \n>   FYI, I've released git-pasky-0.6.3 earlier in the night. It brings\n> especially plenty of bugfixes, but also some tiny enhancements, like\n> colored log and ability to pick branch in the remote repository. git log\n> and git patch now also accept range of commits, so e.g. if you do\n\nHere's a patch to let people know about the nice color feature.\n\nSigned-off-by: Steven Cole <elenstev@mesatop.com>\n\nIndex: git\n===================================================================\n--- 0a9ee5a4d947b998a7ce489242800b39f98eeee5/git  (mode:100755 sha1:39969debd59ed51c57973c819cdcc3ca8a7da819)\n+++ uncommitted/git  (mode:100755)\n@@ -35,7 +35,7 @@\n \tfork\t\tBNAME BRANCH_DIR [COMMIT_ID]\n \thelp\n \tinit\t\tRSYNC_URL\n-\tlog\t\t[COMMIT_ID | COMMIT_ID:COMMIT_ID]\n+\tlog\t\t[-c] [COMMIT_ID | COMMIT_ID:COMMIT_ID]\n \tls\t\t[TREE_ID]\n \tlsobj\t\t[OBJTYPE]\n \tlsremote\nIndex: gitlog.sh\n===================================================================\n--- 0a9ee5a4d947b998a7ce489242800b39f98eeee5/gitlog.sh  (mode:100755 sha1:50eab642cdf5e695cf15be4ce3a7469dd68637e7)\n+++ uncommitted/gitlog.sh  (mode:100755)\n@@ -7,6 +7,14 @@\n # Major optimizations by (c) Phillip Lougher.\n # Rendered trivial by Linus Torvalds.\n #\n+# Takes a -c option to add color to the output.\n+# Currently, the colors are:\n+#\n+#\theader\t\tGreen\t\n+#\tauthor \t\tCyan\n+#\tcommitter\tMagenta\n+#\tsignoff\t\tYellow\n+#\n # Takes an id resolving to a commit to start from (HEAD by default),\n # or id1:id2 representing an (id1;id2] range of commits to show.\n \n"},{"id":"1242","messageId":"20050422064936.GA10854@kroah.com","threadId":"237","inReplyTo":"20050422030931.GA14565@pasky.ji.cz","subject":"Re: [ANNOUNCE] git-pasky-0.6.3 && request for testing","fromName":"Greg KH","fromEmail":"greg@kroah.com","sentAt":"2005-04-22T06:49:37Z","receivedAt":"2005-04-22T06:49:37Z","isPatch":false,"sender":{"key":"greg@kroah.com","avatar":"https://gravatar.com/avatar/5bb5aa0cc2e01c00ec899d11130c07796bc186e465bae57bc34873b13b72c7c8?d=mp&s=160"},"body":"On Fri, Apr 22, 2005 at 05:09:31AM +0200, Petr Baudis wrote:\n>   Hello,\n> \n>   FYI, I've released git-pasky-0.6.3 earlier in the night.\n\nHm, fun thing to try:\n\tgo into a kernel git tree.\n\trm Makefile\n\tgit diff\n\nWatch it as it thinks that every Makefile in the kernel tree is now\ngone...\n\nthanks,\n\ngreg k-h\n"},{"id":"1243","messageId":"20050422071626.GB8467@ip68-225-251-162.oc.oc.cox.net","threadId":"237","inReplyTo":"20050422030931.GA14565@pasky.ji.cz","subject":"Re: [ANNOUNCE] git-pasky-0.6.3 && request for testing","fromName":"Barry K. Nathan","fromEmail":"barryn@pobox.com","sentAt":"2005-04-22T07:16:26Z","receivedAt":"2005-04-22T07:16:26Z","isPatch":false,"sender":{"key":"barryn@pobox.com","avatar":"https://gravatar.com/avatar/abde2df26228cb903d88f90d0a1e375aa9143c1370af9952c90ff2bed9772394?d=mp&s=160"},"body":"With git-pasky 0.6.3, \"git log\" is unusable on my Mandrake 10.1 system.\nBasically I get a neverending flood of these until I press 'q' to quit\nless:\n\n/home/barryn/softbag/git-pasky-0.6.3/gitlog.sh: line 73:  7598 Segmentation faul\nt      sed -re '\n                                        / *Signed-off-by.*/Is//'$colsignoff'&'$c\noldefault'/\n                                        s/^/    /\n                                '\n/home/barryn/softbag/git-pasky-0.6.3/gitlog.sh: line 73:  7609 Segmentation faul\nt      sed -re '\n                                        / *Signed-off-by.*/Is//'$colsignoff'&'$c\noldefault'/\n                                        s/^/    /\n                                '\n/home/barryn/softbag/git-pasky-0.6.3/gitlog.sh: line 73:  7620 Segmentation faul\nt      sed -re '\n                                        / *Signed-off-by.*/Is//'$colsignoff'&'$c\noldefault'/\n                                        s/^/    /\n                                '\n\ngit-pasky-0.6.2 works fine.\n\nI'm not sure if I have time tonight (or tomorrow) to troubleshoot this\nfurther, but I'll see if I can.\n\n-Barry K. Nathan <barryn@pobox.com>\n\n"},{"id":"1244","messageId":"20050422072437.GC8467@ip68-225-251-162.oc.oc.cox.net","threadId":"237","inReplyTo":"20050422071626.GB8467@ip68-225-251-162.oc.oc.cox.net","subject":"Re: [ANNOUNCE] git-pasky-0.6.3 && request for testing","fromName":"Barry K. Nathan","fromEmail":"barryn@pobox.com","sentAt":"2005-04-22T07:24:37Z","receivedAt":"2005-04-22T07:24:37Z","isPatch":false,"sender":{"key":"barryn@pobox.com","avatar":"https://gravatar.com/avatar/abde2df26228cb903d88f90d0a1e375aa9143c1370af9952c90ff2bed9772394?d=mp&s=160"},"body":"On Fri, Apr 22, 2005 at 12:16:26AM -0700, Barry K. Nathan wrote:\n> With git-pasky 0.6.3, \"git log\" is unusable on my Mandrake 10.1 system.\n> Basically I get a neverending flood of these until I press 'q' to quit\n> less:\n[snip sed segmentation faults which happen with 0.6.3 but not 0.6.2]\n> I'm not sure if I have time tonight (or tomorrow) to troubleshoot this\n> further, but I'll see if I can.\n\nI had sed-4.1.1-2mdk. I downloaded sed-4.1.4-2mdk (from Mandriva 2005\nLimited Edition) and updated to that, and the problem went away.\n\nFWIW this is the second package I've had to update to the Mandriva 2005\nLE level (the first was mktemp). I don't mind however.\n\n-Barry K. Nathan <barryn@pobox.com>\n\n"},{"id":"1256","messageId":"20050422103737.GC14565@pasky.ji.cz","threadId":"237","inReplyTo":"20050422072437.GC8467@ip68-225-251-162.oc.oc.cox.net","subject":"Re: [ANNOUNCE] git-pasky-0.6.3 && request for testing","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2005-04-22T10:37:37Z","receivedAt":"2005-04-22T10:37:37Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Fri, Apr 22, 2005 at 09:24:37AM CEST, I got a letter\nwhere \"Barry K. Nathan\" <barryn@pobox.com> told me that...\n> On Fri, Apr 22, 2005 at 12:16:26AM -0700, Barry K. Nathan wrote:\n> > With git-pasky 0.6.3, \"git log\" is unusable on my Mandrake 10.1 system.\n> > Basically I get a neverending flood of these until I press 'q' to quit\n> > less:\n> [snip sed segmentation faults which happen with 0.6.3 but not 0.6.2]\n> > I'm not sure if I have time tonight (or tomorrow) to troubleshoot this\n> > further, but I'll see if I can.\n> \n> I had sed-4.1.1-2mdk. I downloaded sed-4.1.4-2mdk (from Mandriva 2005\n> Limited Edition) and updated to that, and the problem went away.\n> \n> FWIW this is the second package I've had to update to the Mandriva 2005\n> LE level (the first was mktemp). I don't mind however.\n\nDuh, segfaulting sed! Could you please check which of the sed\ninvocations actually segfault for you?\n\nThanks,\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nC++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor\n"},{"id":"1349","messageId":"20050422230551.GI21204@pasky.ji.cz","threadId":"237","inReplyTo":"20050422064936.GA10854@kroah.com","subject":"Re: [ANNOUNCE] git-pasky-0.6.3 && request for testing","fromName":"Petr Baudis","fromEmail":"pasky@ucw.cz","sentAt":"2005-04-22T23:05:51Z","receivedAt":"2005-04-22T23:05:51Z","isPatch":false,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Fri, Apr 22, 2005 at 08:49:37AM CEST, I got a letter\nwhere Greg KH <greg@kroah.com> told me that...\n> On Fri, Apr 22, 2005 at 05:09:31AM +0200, Petr Baudis wrote:\n> >   Hello,\n> > \n> >   FYI, I've released git-pasky-0.6.3 earlier in the night.\n> \n> Hm, fun thing to try:\n> \tgo into a kernel git tree.\n> \trm Makefile\n> \tgit diff\n> \n> Watch it as it thinks that every Makefile in the kernel tree is now\n> gone...\n\nJust FYI, this is bug in core git's diff-cache; also, when you update\nthe cache properly (either do\n\n\tgit rm Makefile\n\nor\n\n\tupdate-cache --remove Makefile\n\n), it works fine. diff-cache should still not fail so horribly, though.\n\nUnfortunately, I don't have time to debug it now. I will look at it\ntomorrow if noone will fix it before. ;-)\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\nC++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor\n"},{"id":"1354","messageId":"Pine.LNX.4.58.0504221621280.2344@ppc970.osdl.org","threadId":"237","inReplyTo":"20050422230551.GI21204@pasky.ji.cz","subject":"Re: [ANNOUNCE] git-pasky-0.6.3 && request for testing","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-04-22T23:27:08Z","receivedAt":"2005-04-22T23:27:08Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Sat, 23 Apr 2005, Petr Baudis wrote:\n> \n> Just FYI, this is bug in core git's diff-cache;\n\nNice find. \n\nYes, I told you guys I hadn't tested it well ;)\n\n\"diff-cache\" does the same \"diff trees in lockstep\" thing that \"diff-tree\" \ndoes, but it's actually more complex, since the _tree_ part always needs \nto be recursively followed, while the _cache_ part is this linear list \nthat is already expanded.\n\nWhich just made the whole algorithm very messy.\n\nOnce I found out how nasty it was to do that compare, I was actually\nplanning to re-write the thing using the same approach that \"read-tree -m\n<tree>\" does - ie move the tree information _into_ the in-memory cache, at\nwhich point it should be absolutely trivial to compare the two. But since \nthe horrid algorithm seemed to end up working, I never did.\n\nI'm not even going to debug this bug. I'm just going to rewrite diff-cache \nto do what I should have done originally, ie use the power of the \nin-memory cache. That's also automatically going to properly warn about \nunmerged files.\n\nGive me five minutes ;)\n\n\t\tLinus\n"},{"id":"1360","messageId":"Pine.LNX.4.58.0504221717350.2344@ppc970.osdl.org","threadId":"237","inReplyTo":"Pine.LNX.4.58.0504221621280.2344@ppc970.osdl.org","subject":"Re: [ANNOUNCE] git-pasky-0.6.3 && request for testing","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2005-04-23T00:18:03Z","receivedAt":"2005-04-23T00:18:03Z","isPatch":false,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Fri, 22 Apr 2005, Linus Torvalds wrote:\n> \n> I'm not even going to debug this bug. I'm just going to rewrite diff-cache \n> to do what I should have done originally, ie use the power of the \n> in-memory cache.\n\nDone, and pushed out. It should hopefully work now.\n\n\t\tLinus\n\n"},{"id":"1364","messageId":"20050423051235.GB9430@ip68-225-251-162.oc.oc.cox.net","threadId":"237","inReplyTo":"20050422103737.GC14565@pasky.ji.cz","subject":"Re: [ANNOUNCE] git-pasky-0.6.3 && request for testing","fromName":"Barry K. Nathan","fromEmail":"barryn@pobox.com","sentAt":"2005-04-23T05:12:35Z","receivedAt":"2005-04-23T05:12:35Z","isPatch":false,"sender":{"key":"barryn@pobox.com","avatar":"https://gravatar.com/avatar/abde2df26228cb903d88f90d0a1e375aa9143c1370af9952c90ff2bed9772394?d=mp&s=160"},"body":"On Fri, Apr 22, 2005 at 12:37:37PM +0200, Petr Baudis wrote:\n> Duh, segfaulting sed! Could you please check which of the sed\n> invocations actually segfault for you?\n\n                        \"\")\n                                echo; sed -re '\n                                        /\n*Signed-off-by.*/Is//'$colsignoff'&'$coldefault'/\n                                        s/^/    /\n                                '\n                                ;;\n\nThis only happens with an old sed from Mandrake 10.1; as I previously\nmentioned, if I install the Mandriva 2005 LE sed package, then the\nproblem goes away. (And as I previously mentioned, I also need to have\nthe Mandriva mktemp package installed for git-pasky to work.)\n\n> Thanks,\n\nYou're welcome.\n\n-Barry K. Nathan <barryn@pobox.com>\n"}]}