{"thread":{"id":"23653","subject":"git fast-import crashes importing commits with more than one author","startedAt":"2010-05-01T15:43:56Z","lastAt":"2010-05-03T08:59:17Z","messageCount":6,"participants":["Giedrius Slavinskas","Andreas Schwab","Dmitrijs Ledkovs","Junio C Hamano","Andreas Ericsson"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"140680","messageId":"1272728636.27562.12.camel@localhost.localdomain","threadId":"23653","inReplyTo":null,"subject":"git fast-import crashes importing commits with more than one author","fromName":"Giedrius Slavinskas","fromEmail":"giedrius.slavinskas@gmail.com","sentAt":"2010-05-01T15:43:56Z","receivedAt":"2010-05-01T15:43:56Z","isPatch":false,"sender":{"key":"giedrius.slavinskas@gmail.com","avatar":null},"body":"git fast-import does not support commits with more than one author. I\ntry to import bzr repository and it crashes.\n\nHere is info how to make bzr commit that couldn't be imported to git\nhttp://doc.bazaar.canonical.com/latest/en/user-guide/recording_changes.html#giving-credit-for-a-change\n\n\n"},{"id":"140682","messageId":"m2ocgztw7z.fsf@igel.home","threadId":"23653","inReplyTo":"1272728636.27562.12.camel@localhost.localdomain","subject":"Re: git fast-import crashes importing commits with more than one author","fromName":"Andreas Schwab","fromEmail":"schwab@linux-m68k.org","sentAt":"2010-05-01T16:36:48Z","receivedAt":"2010-05-01T16:36:48Z","isPatch":false,"sender":{"key":"schwab@linux-m68k.org","avatar":"https://avatars.githubusercontent.com/u/2175493?v=4"},"body":"Giedrius Slavinskas writes:\n\n> git fast-import does not support commits with more than one author. I\n> try to import bzr repository and it crashes.\n\nYou can find a patch here:\n\n\nAndreas.\n\n-- \nAndreas Schwab, schwab@linux-m68k.org\nGPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5\n\"And now for something completely different.\"\n"},{"id":"140683","messageId":"g2x86ecb3c71005010947x662aad8bn1fc2950d741b07e7@mail.gmail.com","threadId":"23653","inReplyTo":"m2ocgztw7z.fsf@igel.home","subject":"Re: git fast-import crashes importing commits with more than one author","fromName":"Dmitrijs Ledkovs","fromEmail":"dmitrij.ledkov@ubuntu.com","sentAt":"2010-05-01T16:47:30Z","receivedAt":"2010-05-01T16:47:30Z","isPatch":false,"sender":{"key":"dmitrij.ledkov@ubuntu.com","avatar":"https://gravatar.com/avatar/79b618c6eb391ddb486c2ee0d3b429014e0e9ba579fd55f2e035f482fc8c24f4?d=mp&s=160"},"body":"On 1 May 2010 17:36, Andreas Schwab wrote:\n> Giedrius Slavinskas writes:\n>\n>> git fast-import does not support commits with more than one author. I\n>> try to import bzr repository and it crashes.\n>\n> You can find a patch here:\n> \n>\n> Andreas.\n\nAlthough this is fine shouldn't we put the additional authors to the\nsigned-off: lines in the git commit message?\n\n--Dima.\n"},{"id":"140693","messageId":"7vbpcz5ylz.fsf@alter.siamese.dyndns.org","threadId":"23653","inReplyTo":"g2x86ecb3c71005010947x662aad8bn1fc2950d741b07e7@mail.gmail.com","subject":"Re: git fast-import crashes importing commits with more than one author","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-05-01T17:19:04Z","receivedAt":"2010-05-01T17:19:04Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Dmitrijs Ledkovs writes:\n\n> On 1 May 2010 17:36, Andreas Schwab wrote:\n>> Giedrius Slavinskas writes:\n>>\n>>> git fast-import does not support commits with more than one author. I\n>>> try to import bzr repository and it crashes.\n>>\n>> You can find a patch here:\n>> \n>>\n>> Andreas.\n>\n> Although this is fine shouldn't we put the additional authors to the\n> signed-off: lines in the git commit message?\n\nIf an author didn't sign-off in the log message, a tool shouldn't add it\nautomatically. Doing so makes S-o-b meaningless.\n"},{"id":"140696","messageId":"y2m86ecb3c71005011028t7f581ce7t98256aa8f8bbb0bf@mail.gmail.com","threadId":"23653","inReplyTo":"7vbpcz5ylz.fsf@alter.siamese.dyndns.org","subject":"Re: git fast-import crashes importing commits with more than one author","fromName":"Dmitrijs Ledkovs","fromEmail":"dmitrij.ledkov@ubuntu.com","sentAt":"2010-05-01T17:28:44Z","receivedAt":"2010-05-01T17:28:44Z","isPatch":false,"sender":{"key":"dmitrij.ledkov@ubuntu.com","avatar":"https://gravatar.com/avatar/79b618c6eb391ddb486c2ee0d3b429014e0e9ba579fd55f2e035f482fc8c24f4?d=mp&s=160"},"body":"On 1 May 2010 18:19, Junio C Hamano wrote:\n> Dmitrijs Ledkovs writes:\n>\n>> On 1 May 2010 17:36, Andreas Schwab wrote:\n>>> Giedrius Slavinskas writes:\n>>>\n>>>> git fast-import does not support commits with more than one author. I\n>>>> try to import bzr repository and it crashes.\n>>>\n>>> You can find a patch here:\n>>> \n>>>\n>>> Andreas.\n>>\n>> Although this is fine shouldn't we put the additional authors to the\n>> signed-off: lines in the git commit message?\n>\n> If an author didn't sign-off in the log message, a tool shouldn't add it\n> automatically.  Doing so makes S-o-b meaningless.\n>\n\nFair enough. I'm justing thinking on how to support round-tripping to\nbzr with import/export cause there are a few other properties bzr\nneeds to recreate identical repository. Is it more appropriate for the\nmarks format revision (bzr side of it)?\n"},{"id":"140817","messageId":"4BDE9065.5030500@op5.se","threadId":"23653","inReplyTo":"y2m86ecb3c71005011028t7f581ce7t98256aa8f8bbb0bf@mail.gmail.com","subject":"Re: git fast-import crashes importing commits with more than one author","fromName":"Andreas Ericsson","fromEmail":"ae@op5.se","sentAt":"2010-05-03T08:59:17Z","receivedAt":"2010-05-03T08:59:17Z","isPatch":false,"sender":{"key":"ae@op5.se","avatar":"https://gravatar.com/avatar/426e89595c75a8f5252dd0c989e5fabe5bcac616e68557427ad9aef6b0ca342a?d=mp&s=160"},"body":"On 05/01/2010 07:28 PM, Dmitrijs Ledkovs wrote:\n> On 1 May 2010 18:19, Junio C Hamano wrote:\n>> Dmitrijs Ledkovs writes:\n>>\n>>> On 1 May 2010 17:36, Andreas Schwab wrote:\n>>>> Giedrius Slavinskas writes:\n>>>>\n>>>>> git fast-import does not support commits with more than one author. I\n>>>>> try to import bzr repository and it crashes.\n>>>>\n>>>> You can find a patch here:\n>>>> \n>>>>\n>>>> Andreas.\n>>>\n>>> Although this is fine shouldn't we put the additional authors to the\n>>> signed-off: lines in the git commit message?\n>>\n>> If an author didn't sign-off in the log message, a tool shouldn't add it\n>> automatically. Doing so makes S-o-b meaningless.\n>>\n> \n> Fair enough. I'm justing thinking on how to support round-tripping to\n> bzr with import/export cause there are a few other properties bzr\n> needs to recreate identical repository. Is it more appropriate for the\n> marks format revision (bzr side of it)?\n\nAdd\n\nCo-authored-by: Some One \n\nand parse that when sending back to bzr. That way you get attribution\nproperly in both tools, in a way.\n\n-- \nAndreas Ericsson andreas.ericsson@op5.se\nOP5 AB www.op5.se\nTel: +46 8-230225 Fax: +46 8-230231\n\nConsidering the successes of the wars on alcohol, poverty, drugs and\nterror, I think we should give some serious thought to declaring war\non peace.\n"}]}