{"thread":{"id":"23621","subject":"[PATCH] gitweb: Improve installation instructions in gitweb/INSTALL","startedAt":"2010-04-27T20:33:42Z","lastAt":"2010-04-27T22:27:39Z","messageCount":5,"participants":["Jakub Narebski","Mark Rada"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"140544","messageId":"20100427203341.31445.82930.stgit@localhost.localdomain","threadId":"23621","inReplyTo":null,"subject":"[PATCH] gitweb: Improve installation instructions in gitweb/INSTALL","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-04-27T20:33:42Z","receivedAt":"2010-04-27T20:33:42Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n\n gitweb/INSTALL |   20 +++++++++++++++-----\n 1 files changed, 15 insertions(+), 5 deletions(-)\n\n\ndiff --git a/gitweb/INSTALL b/gitweb/INSTALL\nindex cbdc136..be965d2 100644\n--- a/gitweb/INSTALL\n+++ b/gitweb/INSTALL\n@@ -7,7 +7,9 @@ gitweb.css, git-logo.png and git-favicon.png) to their destination.\n For example if git was (or is) installed with /usr prefix, you can do\n \n \t$ make prefix=/usr gitweb             ;# as yourself\n-\t# cp gitweb/git* /var/www/cgi-bin/    ;# as root\n+\t# cp gitweb/*.cgi gitweb/*.css \\\n+       gitweb/*.js  gitweb/*.png \\\n+       /var/www/cgi-bin/                ;# as root\n \n Alternatively you can use autoconf generated ./configure script to\n set up path to git binaries (via config.mak.autogen), so you can write\n@@ -16,7 +18,9 @@ instead\n \t$ make configure                     ;# as yourself\n \t$ ./configure --prefix=/usr          ;# as yourself\n \t$ make gitweb                        ;# as yourself\n-\t# cp gitweb/git* /var/www/cgi-bin/   ;# as root\n+\t# cp gitweb/*.cgi gitweb/*.css \\\n+       gitweb/*.js  gitweb/*.png \\\n+       /var/www/cgi-bin/               ;# as root\n \n The above example assumes that your web server is configured to run\n [executable] files in /var/www/cgi-bin/ as server scripts (as CGI\n@@ -74,7 +78,7 @@ file for gitweb (in gitweb/README).\n Build example\n ~~~~~~~~~~~~~\n \n-- To install gitweb to /var/www/cgi-bin/gitweb/ when git wrapper\n+- To install gitweb to /var/www/cgi-bin/gitweb/, when git wrapper\n   is installed at /usr/local/bin/git and the repositories (projects)\n   we want to display are under /home/local/scm, you can do\n \n@@ -86,10 +90,16 @@ Build example\n \t     bindir=/usr/local/bin \\\n \t     gitweb\n \n-\tcp -fv ~/git/gitweb/gitweb.{cgi,js,css} \\\n-\t       ~/git/gitweb/git-{favicon,logo}.png \\\n+\tcp -fv gitweb/gitweb.{cgi,js,css} \\\n+\t       gitweb/git-{favicon,logo}.png \\\n \t     /var/www/cgi-bin/gitweb/\n \n+  The above instruction assumes that you didn't use JavaScript\n+  minimizer or CSS minimizer.  If you use minimizers you need\n+  to modify above instructions accordingly, which means pointing\n+  GITWEB_CSS and GITWEB_JS to minified versions, and copying \n+  minified files.\n+\n \n Gitweb config file\n ------------------\n"},{"id":"140546","messageId":"4BD74BAB.1040401@mailservices.uwaterloo.ca","threadId":"23621","inReplyTo":"20100427203341.31445.82930.stgit@localhost.localdomain","subject":"Re: [PATCH] gitweb: Improve installation instructions in gitweb/INSTALL","fromName":"Mark Rada","fromEmail":"marada@uwaterloo.ca","sentAt":"2010-04-27T20:40:11Z","receivedAt":"2010-04-27T20:40:11Z","isPatch":true,"sender":{"key":"marada@uwaterloo.ca","avatar":"https://avatars.githubusercontent.com/u/38430?v=4"},"body":"On 10-04-27 4:33 PM, Jakub Narebski wrote:\n> +  The above instruction assumes that you didn't use JavaScript\n> +  minimizer or CSS minimizer.  If you use minimizers you need\n> +  to modify above instructions accordingly, which means pointing\n> +  GITWEB_CSS and GITWEB_JS to minified versions, and copying \n> +  minified files.\n> +\n>  \n\nHmm, I believe I already put a message like this in the INSTALL\nfile. Perhaps that message should be updated, too, or removed in\nplace of your patch.\n\nLooks like:\n 67 \n 68 - You can optionally generate minified versions of gitweb.js and gitweb.css\n 69   by defining the JSMIN and CSSMIN build configuration variables. By default\n 70   the non-minified versions will be used. NOTE: if you enable this option,\n 71   substitute gitweb.min.js and gitweb.min.css for all uses of gitweb.js and\n 72   gitweb.css in the help files.\n\n\n\n-- \nMark Rada\nmarada@uwaterloo.ca\n"},{"id":"140547","messageId":"20100427203915.31579.6316.stgit@localhost.localdomain","threadId":"23621","inReplyTo":"20100427203341.31445.82930.stgit@localhost.localdomain","subject":"[PATCH (amend)] gitweb: Improve installation instructions in gitweb/INSTALL","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-04-27T20:40:18Z","receivedAt":"2010-04-27T20:40:18Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Signed-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nFixed spaces instead of tab in one place.\n\n gitweb/INSTALL |   20 +++++++++++++++-----\n 1 files changed, 15 insertions(+), 5 deletions(-)\n\ndiff --git a/gitweb/INSTALL b/gitweb/INSTALL\nindex cbdc136..94ec05f 100644\n--- a/gitweb/INSTALL\n+++ b/gitweb/INSTALL\n@@ -7,7 +7,9 @@ gitweb.css, git-logo.png and git-favicon.png) to their destination.\n For example if git was (or is) installed with /usr prefix, you can do\n \n \t$ make prefix=/usr gitweb             ;# as yourself\n-\t# cp gitweb/git* /var/www/cgi-bin/    ;# as root\n+\t# cp gitweb/*.cgi gitweb/*.css \\\n+\t     gitweb/*.js  gitweb/*.png \\\n+\t     /var/www/cgi-bin/                ;# as root\n \n Alternatively you can use autoconf generated ./configure script to\n set up path to git binaries (via config.mak.autogen), so you can write\n@@ -16,7 +18,9 @@ instead\n \t$ make configure                     ;# as yourself\n \t$ ./configure --prefix=/usr          ;# as yourself\n \t$ make gitweb                        ;# as yourself\n-\t# cp gitweb/git* /var/www/cgi-bin/   ;# as root\n+\t# cp gitweb/*.cgi gitweb/*.css \\\n+\t     gitweb/*.js  gitweb/*.png \\\n+\t     /var/www/cgi-bin/               ;# as root\n \n The above example assumes that your web server is configured to run\n [executable] files in /var/www/cgi-bin/ as server scripts (as CGI\n@@ -74,7 +78,7 @@ file for gitweb (in gitweb/README).\n Build example\n ~~~~~~~~~~~~~\n \n-- To install gitweb to /var/www/cgi-bin/gitweb/ when git wrapper\n+- To install gitweb to /var/www/cgi-bin/gitweb/, when git wrapper\n   is installed at /usr/local/bin/git and the repositories (projects)\n   we want to display are under /home/local/scm, you can do\n \n@@ -86,10 +90,16 @@ Build example\n \t     bindir=/usr/local/bin \\\n \t     gitweb\n \n-\tcp -fv ~/git/gitweb/gitweb.{cgi,js,css} \\\n-\t       ~/git/gitweb/git-{favicon,logo}.png \\\n+\tcp -fv gitweb/gitweb.{cgi,js,css} \\\n+\t       gitweb/git-{favicon,logo}.png \\\n \t     /var/www/cgi-bin/gitweb/\n \n+  The above instruction assumes that you didn't use JavaScript\n+  minimizer or CSS minimizer.  If you use minimizers you need\n+  to modify above instructions accordingly, which means pointing\n+  GITWEB_CSS and GITWEB_JS to minified versions, and copying \n+  minified files.\n+\n \n Gitweb config file\n ------------------\n"},{"id":"140548","messageId":"201004272247.27566.jnareb@gmail.com","threadId":"23621","inReplyTo":"4BD74BAB.1040401@mailservices.uwaterloo.ca","subject":"[PATCHv2] gitweb: Improve installation instructions in gitweb/INSTALL","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-04-27T20:47:24Z","receivedAt":"2010-04-27T20:47:24Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Dnia wtorek 27. kwietnia 2010 22:40, Mark Rada napisał:\n> On 10-04-27 4:33 PM, Jakub Narebski wrote:\n> > +  The above instruction assumes that you didn't use JavaScript\n> > +  minimizer or CSS minimizer.  If you use minimizers you need\n> > +  to modify above instructions accordingly, which means pointing\n> > +  GITWEB_CSS and GITWEB_JS to minified versions, and copying \n> > +  minified files.\n> > +\n> >  \n> \n> Hmm, I believe I already put a message like this in the INSTALL\n> file. Perhaps that message should be updated, too, or removed in\n> place of your patch.\n> \n> Looks like:\n>  67 \n>  68 - You can optionally generate minified versions of gitweb.js and gitweb.css\n>  69   by defining the JSMIN and CSSMIN build configuration variables. By default\n>  70   the non-minified versions will be used. NOTE: if you enable this option,\n>  71   substitute gitweb.min.js and gitweb.min.css for all uses of gitweb.js and\n>  72   gitweb.css in the help files.\n\nHow about this then:\n\n-- >8 --\nFrom: Jakub Narebski <jnareb@gmail.com>\nDate: Tue, 27 Apr 2010 22:45:19 +0200\nSubject: [PATCHv2] gitweb: Improve installation instructions in gitweb/INSTALL\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n gitweb/INSTALL |   19 ++++++++++++-------\n 1 files changed, 12 insertions(+), 7 deletions(-)\n\ndiff --git a/gitweb/INSTALL b/gitweb/INSTALL\nindex cbdc136..1bfd9aa 100644\n--- a/gitweb/INSTALL\n+++ b/gitweb/INSTALL\n@@ -7,7 +7,9 @@ gitweb.css, git-logo.png and git-favicon.png) to their destination.\n For example if git was (or is) installed with /usr prefix, you can do\n \n \t$ make prefix=/usr gitweb             ;# as yourself\n-\t# cp gitweb/git* /var/www/cgi-bin/    ;# as root\n+\t# cp gitweb/*.cgi gitweb/*.css \\\n+\t     gitweb/*.js  gitweb/*.png \\\n+\t     /var/www/cgi-bin/                ;# as root\n \n Alternatively you can use autoconf generated ./configure script to\n set up path to git binaries (via config.mak.autogen), so you can write\n@@ -16,7 +18,9 @@ instead\n \t$ make configure                     ;# as yourself\n \t$ ./configure --prefix=/usr          ;# as yourself\n \t$ make gitweb                        ;# as yourself\n-\t# cp gitweb/git* /var/www/cgi-bin/   ;# as root\n+\t# cp gitweb/*.cgi gitweb/*.css \\\n+\t     gitweb/*.js  gitweb/*.png \\\n+\t     /var/www/cgi-bin/               ;# as root\n \n The above example assumes that your web server is configured to run\n [executable] files in /var/www/cgi-bin/ as server scripts (as CGI\n@@ -74,9 +78,10 @@ file for gitweb (in gitweb/README).\n Build example\n ~~~~~~~~~~~~~\n \n-- To install gitweb to /var/www/cgi-bin/gitweb/ when git wrapper\n-  is installed at /usr/local/bin/git and the repositories (projects)\n-  we want to display are under /home/local/scm, you can do\n+- To install gitweb to /var/www/cgi-bin/gitweb/, when git wrapper\n+  is installed at /usr/local/bin/git, the repositories (projects)\n+  we want to display are under /home/local/scm, and you do not use\n+  minifiers, you can do\n \n \tmake GITWEB_PROJECTROOT=\"/home/local/scm\" \\\n \t     GITWEB_JS=\"/gitweb/gitweb.js\" \\\n@@ -86,8 +91,8 @@ Build example\n \t     bindir=/usr/local/bin \\\n \t     gitweb\n \n-\tcp -fv ~/git/gitweb/gitweb.{cgi,js,css} \\\n-\t       ~/git/gitweb/git-{favicon,logo}.png \\\n+\tcp -fv gitweb/gitweb.{cgi,js,css} \\\n+\t       gitweb/git-{favicon,logo}.png \\\n \t     /var/www/cgi-bin/gitweb/\n \n \n-- \n1.7.0.1\n"},{"id":"140556","messageId":"4BD764DB.2020706@mailservices.uwaterloo.ca","threadId":"23621","inReplyTo":"201004272247.27566.jnareb@gmail.com","subject":"Re: [PATCHv2] gitweb: Improve installation instructions in gitweb/INSTALL","fromName":"Mark Rada","fromEmail":"marada@uwaterloo.ca","sentAt":"2010-04-27T22:27:39Z","receivedAt":"2010-04-27T22:27:39Z","isPatch":false,"sender":{"key":"marada@uwaterloo.ca","avatar":"https://avatars.githubusercontent.com/u/38430?v=4"},"body":"On 10-04-27 4:47 PM, Jakub Narebski wrote:\n> -- To install gitweb to /var/www/cgi-bin/gitweb/ when git wrapper\n> -  is installed at /usr/local/bin/git and the repositories (projects)\n> -  we want to display are under /home/local/scm, you can do\n> +- To install gitweb to /var/www/cgi-bin/gitweb/, when git wrapper\n> +  is installed at /usr/local/bin/git, the repositories (projects)\n> +  we want to display are under /home/local/scm, and you do not use\n> +  minifiers, you can do\n>  \n\nTo me it looks like a run on sentence, but it doesn't provide redundant\ninformation and leaves a keyword to help jump to the relevant section.\n\nFWIW:\n\nAcked-by: Mark Rada <marada@uwaterloo.ca>\n\n\n\n-- \nMark Rada\nmarada@uwaterloo.ca\n"}]}