{"thread":{"id":"23602","subject":"[PATCH] git-submodule.sh: properly initialize shell variables","startedAt":"2010-04-26T09:50:39Z","lastAt":"2010-04-26T09:50:39Z","messageCount":1,"participants":["Gerrit Pape"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"140398","messageId":"20100426095039.20264.qmail@7cdeaa1bd53836.315fe32.mid.smarden.org","threadId":"23602","inReplyTo":null,"subject":"[PATCH] git-submodule.sh: properly initialize shell variables","fromName":"Gerrit Pape","fromEmail":"pape@smarden.org","sentAt":"2010-04-26T09:50:39Z","receivedAt":"2010-04-26T09:50:39Z","isPatch":true,"sender":{"key":"pape@smarden.org","avatar":"https://avatars.githubusercontent.com/u/143170252?v=4"},"body":"git-submodule inherits variables from the environment it is started in,\nexpects the internal variables init= and recursive= to have an empty\nvalue, but doesn't initialize them appropriately.  Thanks to the\nselftests, this can be reproduced through\n\n init=1 make test\n recursive=1 make test\n\nWith this commit the variables are initialized, and the selftests\nsucceed even if these variables have some values in the environment.\n\nThe bug was discovered through the Debian autobuilders\n http://bugs.debian.org/569594\n\nSigned-off-by: Gerrit Pape <pape@smarden.org>\n---\n git-submodule.sh |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/git-submodule.sh b/git-submodule.sh\nindex 2dd372a..3319b83 100755\n--- a/git-submodule.sh\n+++ b/git-submodule.sh\n@@ -21,6 +21,8 @@ command=\n branch=\n reference=\n cached=\n+recursive=\n+init=\n files=\n nofetch=\n update=\n-- \n1.7.0.3\n"}]}