{"thread":{"id":"23473","subject":"[PATCH v2] tag -v: use RUN_GIT_CMD to run verify-tag","startedAt":"2010-04-15T09:36:25Z","lastAt":"2010-04-15T09:36:25Z","messageCount":1,"participants":["Jonathan Nieder"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"139569","messageId":"20100415093625.GA18612@progeny.tock","threadId":"23473","inReplyTo":null,"subject":"[PATCH v2] tag -v: use RUN_GIT_CMD to run verify-tag","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2010-04-15T09:36:25Z","receivedAt":"2010-04-15T09:36:25Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"This is the preferred way to run a git command.\n\nThe only obvious observable effects I can think of are that the exec\nis properly reported in GIT_TRACE output and that verifying signed\ntags will still work if the git-verify-tag hard link in gitexecdir\ngoes missing.\n\nHelped-by: Johannes Sixt <j6t@kdbg.org>\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\nv1 was part of a longer series that replaced the run_command with a\nfunction call [1].\n\nThanks to Hannes for the pointer.\n\n[1] http://thread.gmane.org/gmane.comp.version-control.git/142681/focus=142682\nWhat about the rest of the series?  Without some facility [2] to\nverify tags without going out of the way to do it, it is hard to end\nup using tag -v often enough to notice the speed difference.\n[2] maybe a fetch-update hook.\nhttp://thread.gmane.org/gmane.comp.version-control.git/101585/focus=101590\n\n builtin/tag.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/tag.c b/builtin/tag.c\nindex 4ef1c4f..d311491 100644\n--- a/builtin/tag.c\n+++ b/builtin/tag.c\n@@ -147,11 +147,11 @@ static int delete_tag(const char *name, const char *ref,\n static int verify_tag(const char *name, const char *ref,\n \t\t\t\tconst unsigned char *sha1)\n {\n-\tconst char *argv_verify_tag[] = {\"git-verify-tag\",\n+\tconst char *argv_verify_tag[] = {\"verify-tag\",\n \t\t\t\t\t\"-v\", \"SHA1_HEX\", NULL};\n \targv_verify_tag[2] = sha1_to_hex(sha1);\n \n-\tif (run_command_v_opt(argv_verify_tag, 0))\n+\tif (run_command_v_opt(argv_verify_tag, RUN_GIT_CMD))\n \t\treturn error(\"could not verify the tag '%s'\", name);\n \treturn 0;\n }\n-- \n1.7.1.rc1\n"}]}