{"thread":{"id":"23418","subject":"[ANNOUNCE] Git 1.7.1.rc1","startedAt":"2010-04-11T04:13:56Z","lastAt":"2010-04-11T21:51:13Z","messageCount":8,"participants":["Junio C Hamano","ZoltánFüzesi","Ævar Arnfjörð Bjarmason","Andreas Schwab","Johannes Sixt","Jens Lehmann"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"139233","messageId":"7vmxxar5h7.fsf@alter.siamese.dyndns.org","threadId":"23418","inReplyTo":null,"subject":"[ANNOUNCE] Git 1.7.1.rc1","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-04-11T04:13:56Z","receivedAt":"2010-04-11T04:13:56Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"A release candidate Git 1.7.1.rc1 is available at the usual places\nfor testing:\n\n http://www.kernel.org/pub/software/scm/git/\n\n git-1.7.1.rc1.tar.{gz,bz2}\t\t\t(source tarball)\n git-htmldocs-1.7.1.rc1.tar.{gz,bz2}\t\t(preformatted docs)\n git-manpages-1.7.1.rc1.tar.{gz,bz2}\t\t(preformatted docs)\n\nThe RPM binary packages for a few architectures are found in:\n\n testing/git-*-1.7.1.rc1-1.fc11.$arch.rpm\t(RPM)\n\nPlease test 'master', report & fix regressions. Hopefully we can do\nanother rc during the next week and release the final one next weekend.\n\n----------------------------------------------------------------\n\nChanges since v1.7.1-rc0 are as follows:\n\nBrandon Casey (1):\n notes.h: declare bit field as unsigned to silence compiler complaints\n\nJeff King (4):\n fix const-correctness of write_sha1_file\n fix textconv leak in emit_rewrite_diff\n fix typos and grammar in 1.7.1 draft release notes\n docs: clarify \"branch -l\"\n\nJens Lehmann (2):\n Let check_preimage() use memset() to initialize \"struct checkout\"\n Teach diff --submodule and status to handle .git files in submodules\n\nJonathan Nieder (1):\n Teach mailinfo %< as an alternative scissors mark\n\nJunio C Hamano (2):\n diff.c: work around pointer constness warnings\n Git 1.7.1-rc1\n\nMark Rada (6):\n Gitweb: add ignore and clean rules for minified files\n Gitweb: add support for minifying gitweb.css\n Gitweb: add autoconfigure support for minifiers\n instaweb: add minification awareness\n gitweb: add documentation to INSTALL regarding gitweb.js\n gitweb: update INSTALL to use shorter make target\n\nMichael J Gruber (2):\n t3301-notes: Test the creation of reflog entries\n refs.c: Write reflogs for notes just like for branch heads\n\nTay Ray Chuan (2):\n branch: say \"Reset to\" in reflog entries for 'git branch -f' operations\n fetch/push: fix usage strings\n"},{"id":"139257","messageId":"loom.20100411T174751-103@post.gmane.org","threadId":"23418","inReplyTo":"7vmxxar5h7.fsf@alter.siamese.dyndns.org","subject":"Re: [ANNOUNCE] Git 1.7.1.rc1","fromName":"ZoltánFüzesi","fromEmail":"zfuzesi@eaglet.hu","sentAt":"2010-04-11T15:57:28Z","receivedAt":"2010-04-11T15:57:28Z","isPatch":false,"sender":{"key":"zfuzesi@eaglet.hu","avatar":null},"body":"Hi,\n\nJunio C Hamano pobox.com> writes:\n> \n> Jens Lehmann (2):\n> Let check_preimage() use memset() to initialize \"struct checkout\"\n> Teach diff --submodule and status to handle .git files in submodules\n> \n\nThis breaks git-status on Windows, if repository has submodule(s).\n\"fatal: chdir in start_command() not implemented\"\n\nIt comes from run-command.c line 345:\nif (cmd->dir)\n die(\"chdir in start_command() not implemented\");\n\nCommit (eee49b6ce4b7b3fed28794676c67ad3609f658ac) message says:\n\"While at it, is_submodule_modified() was cleaned up\nto use the \"dir\" member of \"struct child_process\" instead of setting the\nGIT_WORK_TREE and GIT_DIR environment variables.\"\n\nZ.\n"},{"id":"139258","messageId":"y2i51dd1af81004110908mcf6ce8cahf04225d7c261a85b@mail.gmail.com","threadId":"23418","inReplyTo":"7vmxxar5h7.fsf@alter.siamese.dyndns.org","subject":"Re: [ANNOUNCE] Git 1.7.1.rc1","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-04-11T16:08:27Z","receivedAt":"2010-04-11T16:08:27Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Sun, Apr 11, 2010 at 04:13, Junio C Hamano wrote:\n> A release candidate Git 1.7.1.rc1 is available at the usual places\n> for testing:\n\nThis is a minor nit but when I generate the info docs from master I\nget this at the top of user-manual.texi:\n\n @menu\n * : id2860714.\n * Repositories and Branches::\n * Exploring git history::\n * Developing with git::\n\nI can't find what produces that token but here are all occurrences of it:\n\n 4 matches for \"id2860714\" in buffer: user-manual.texi\n 10:@node Top, id2860714, , (dir)\n 15:* : id2860714.\n 130:@node id2860714, Repositories and Branches, Top, Top\n 171:@node Repositories and Branches, Exploring git history, id2860714, Top\n\nThis bug results in an empty list item when viewing the Git User’s\nManual with info.\n"},{"id":"139260","messageId":"m2pr26c4jt.fsf@igel.home","threadId":"23418","inReplyTo":"y2i51dd1af81004110908mcf6ce8cahf04225d7c261a85b@mail.gmail.com","subject":"Re: [ANNOUNCE] Git 1.7.1.rc1","fromName":"Andreas Schwab","fromEmail":"schwab@linux-m68k.org","sentAt":"2010-04-11T16:55:18Z","receivedAt":"2010-04-11T16:55:18Z","isPatch":false,"sender":{"key":"schwab@linux-m68k.org","avatar":"https://avatars.githubusercontent.com/u/2175493?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> On Sun, Apr 11, 2010 at 04:13, Junio C Hamano wrote:\n>> A release candidate Git 1.7.1.rc1 is available at the usual places\n>> for testing:\n>\n> This is a minor nit but when I generate the info docs from master I\n> get this at the top of user-manual.texi:\n>\n> @menu\n> * : id2860714.\n> * Repositories and Branches::\n> * Exploring git history::\n> * Developing with git::\n>\n> I can't find what produces that token but here are all occurrences of it:\n\nThat appears to be because the first title is empty:\n\n$ head -n 9 user-manual.xml\n\n\n\n\n\n Git User’s Manual (for version 1.5.3 or newer)\n\n\n\n\nAndreas.\n\n-- \nAndreas Schwab, schwab@linux-m68k.org\nGPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5\n\"And now for something completely different.\"\n"},{"id":"139263","messageId":"s2s51dd1af81004111014za26552e9vba2dd629675d1c1d@mail.gmail.com","threadId":"23418","inReplyTo":"m2pr26c4jt.fsf@igel.home","subject":"Re: [ANNOUNCE] Git 1.7.1.rc1","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-04-11T17:14:30Z","receivedAt":"2010-04-11T17:14:30Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"On Sun, Apr 11, 2010 at 16:55, Andreas Schwab wrote:\n> Ævar Arnfjörð Bjarmason writes:\n>\n>> On Sun, Apr 11, 2010 at 04:13, Junio C Hamano wrote:\n>>> A release candidate Git 1.7.1.rc1 is available at the usual places\n>>> for testing:\n>>\n>> This is a minor nit but when I generate the info docs from master I\n>> get this at the top of user-manual.texi:\n>>\n>>     @menu\n>>     * : id2860714.\n>>     * Repositories and Branches::\n>>     * Exploring git history::\n>>     * Developing with git::\n>>\n>> I can't find what produces that token but here are all occurrences of it:\n>\n> That appears to be because the first title is empty:\n>\n> $ head -n 9 user-manual.xml\n> \n> \n>\n> \n> \n>    Git User’s Manual (for version 1.5.3 or newer)\n> \n> \n> \n\nThe original error is going to be in user-manual.txt. That's where I\ncouldn't track down the error. The XML and TexInfo files are\nautomatically generated from the .txt source.\n"},{"id":"139285","messageId":"4BC233AC.3090603@kdbg.org","threadId":"23418","inReplyTo":"loom.20100411T174751-103@post.gmane.org","subject":"[PATCH jl/maint-submodule-gitfile-awareness] Windows: start_command: Support non-NULL dir in struct child_process","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2010-04-11T20:40:12Z","receivedAt":"2010-04-11T20:40:12Z","isPatch":true,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"A caller of start_command can set the member 'dir' to a directory to\nrequest that the child process starts with that directory as CWD. The first\nuser of this feature was added recently in eee49b6 (Teach diff --submodule\nand status to handle .git files in submodules).\n\nOn Windows, we have been lazy and had not implemented support for this\nfeature, yet. This fixes the shortcoming.\n\nSigned-off-by: Johannes Sixt \n---\nAm 11.04.2010 17:57, schrieb ZoltánFüzesi:\n> Junio C Hamano pobox.com> writes:\n>> Jens Lehmann (2):\n>> Let check_preimage() use memset() to initialize \"struct checkout\"\n>> Teach diff --submodule and status to handle .git files in submodules\n> \n> This breaks git-status on Windows, if repository has submodule(s).\n> \"fatal: chdir in start_command() not implemented\"\n\nThis fixes it. Hope this gets through without whitespace damage.\n\n-- Hannes\n\n compat/mingw.c | 10 ++++++----\n compat/mingw.h | 1 +\n run-command.c | 4 +---\n 3 files changed, 8 insertions(+), 7 deletions(-)\n\ndiff --git a/compat/mingw.c b/compat/mingw.c\nindex ab65f77..754b534 100644\n--- a/compat/mingw.c\n+++ b/compat/mingw.c\n@@ -618,6 +618,7 @@ static int env_compare(const void *a, const void *b)\n }\n \n static pid_t mingw_spawnve_fd(const char *cmd, const char **argv, char **env,\n+\t\t\t const char *dir,\n \t\t\t int prepend_cmd, int fhin, int fhout, int fherr)\n {\n \tSTARTUPINFO si;\n@@ -697,7 +698,7 @@ static pid_t mingw_spawnve_fd(const char *cmd, const char **argv, char **env,\n \n \tmemset(&pi, 0, sizeof(pi));\n \tret = CreateProcess(cmd, args.buf, NULL, NULL, TRUE, flags,\n-\t\tenv ? envblk.buf : NULL, NULL, &si, &pi);\n+\t\tenv ? envblk.buf : NULL, dir, &si, &pi);\n \n \tif (env)\n \t\tstrbuf_release(&envblk);\n@@ -714,10 +715,11 @@ static pid_t mingw_spawnve_fd(const char *cmd, const char **argv, char **env,\n static pid_t mingw_spawnve(const char *cmd, const char **argv, char **env,\n \t\t\t int prepend_cmd)\n {\n-\treturn mingw_spawnve_fd(cmd, argv, env, prepend_cmd, 0, 1, 2);\n+\treturn mingw_spawnve_fd(cmd, argv, env, NULL, prepend_cmd, 0, 1, 2);\n }\n \n pid_t mingw_spawnvpe(const char *cmd, const char **argv, char **env,\n+\t\t const char *dir,\n \t\t int fhin, int fhout, int fherr)\n {\n \tpid_t pid;\n@@ -740,14 +742,14 @@ pid_t mingw_spawnvpe(const char *cmd, const char **argv, char **env,\n \t\t\t\tpid = -1;\n \t\t\t}\n \t\t\telse {\n-\t\t\t\tpid = mingw_spawnve_fd(iprog, argv, env, 1,\n+\t\t\t\tpid = mingw_spawnve_fd(iprog, argv, env, dir, 1,\n \t\t\t\t\t\t fhin, fhout, fherr);\n \t\t\t\tfree(iprog);\n \t\t\t}\n \t\t\targv[0] = argv0;\n \t\t}\n \t\telse\n-\t\t\tpid = mingw_spawnve_fd(prog, argv, env, 0,\n+\t\t\tpid = mingw_spawnve_fd(prog, argv, env, dir, 0,\n \t\t\t\t\t fhin, fhout, fherr);\n \t\tfree(prog);\n \t}\ndiff --git a/compat/mingw.h b/compat/mingw.h\nindex e254fb4..e0a6aba 100644\n--- a/compat/mingw.h\n+++ b/compat/mingw.h\n@@ -223,6 +223,7 @@ int mingw_utime(const char *file_name, const struct utimbuf *times);\n #define utime mingw_utime\n \n pid_t mingw_spawnvpe(const char *cmd, const char **argv, char **env,\n+\t\t const char *dir,\n \t\t int fhin, int fhout, int fherr);\n void mingw_execvp(const char *cmd, char *const *argv);\n #define execvp mingw_execvp\ndiff --git a/run-command.c b/run-command.c\nindex 2feb493..db30cd5 100644\n--- a/run-command.c\n+++ b/run-command.c\n@@ -335,8 +335,6 @@ fail_pipe:\n \telse if (cmd->out > 1)\n \t\tfhout = dup(cmd->out);\n \n-\tif (cmd->dir)\n-\t\tdie(\"chdir in start_command() not implemented\");\n \tif (cmd->env)\n \t\tenv = make_augmented_environ(cmd->env);\n \n@@ -346,7 +344,7 @@ fail_pipe:\n \t\tcmd->argv = prepare_shell_cmd(cmd->argv);\n \t}\n \n-\tcmd->pid = mingw_spawnvpe(cmd->argv[0], cmd->argv, env,\n+\tcmd->pid = mingw_spawnvpe(cmd->argv[0], cmd->argv, env, cmd->dir,\n \t\t\t\t fhin, fhout, fherr);\n \tfailed_errno = errno;\n \tif (cmd->pid < 0 && (!cmd->silent_exec_failure || errno != ENOENT))\n-- \n1.7.0.12.ga3b9\n"},{"id":"139291","messageId":"m2vdbxveuw.fsf@igel.home","threadId":"23418","inReplyTo":"s2s51dd1af81004111014za26552e9vba2dd629675d1c1d@mail.gmail.com","subject":"Re: [ANNOUNCE] Git 1.7.1.rc1","fromName":"Andreas Schwab","fromEmail":"schwab@linux-m68k.org","sentAt":"2010-04-11T21:49:59Z","receivedAt":"2010-04-11T21:49:59Z","isPatch":false,"sender":{"key":"schwab@linux-m68k.org","avatar":"https://avatars.githubusercontent.com/u/2175493?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> The original error is going to be in user-manual.txt.\n\nOr the way asciidoc works.\n\nAndreas.\n\n-- \nAndreas Schwab, schwab@linux-m68k.org\nGPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5\n\"And now for something completely different.\"\n"},{"id":"139292","messageId":"4BC24451.8010304@web.de","threadId":"23418","inReplyTo":"4BC233AC.3090603@kdbg.org","subject":"Re: [PATCH jl/maint-submodule-gitfile-awareness] Windows: start_command: Support non-NULL dir in struct child_process","fromName":"Jens Lehmann","fromEmail":"jens.lehmann@web.de","sentAt":"2010-04-11T21:51:13Z","receivedAt":"2010-04-11T21:51:13Z","isPatch":true,"sender":{"key":"jens.lehmann@web.de","avatar":"https://avatars.githubusercontent.com/u/135220?v=4"},"body":"Am 11.04.2010 22:40, schrieb Johannes Sixt:\n> A caller of start_command can set the member 'dir' to a directory to\n> request that the child process starts with that directory as CWD. The first\n> user of this feature was added recently in eee49b6 (Teach diff --submodule\n> and status to handle .git files in submodules).\n> \n> On Windows, we have been lazy and had not implemented support for this\n> feature, yet. This fixes the shortcoming.\n\nThanks, I didn't know this was missing from the Windows port.\n"}]}