{"thread":{"id":"23331","subject":"Tests with broken && chains in pu","startedAt":"2010-04-04T20:08:58Z","lastAt":"2010-04-04T21:28:13Z","messageCount":5,"participants":["Johannes Sixt","Sverre Rabbelier","Chris Webb","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"138552","messageId":"201004042208.58939.j6t@kdbg.org","threadId":"23331","inReplyTo":null,"subject":"Tests with broken && chains in pu","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2010-04-04T20:08:58Z","receivedAt":"2010-04-04T20:08:58Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Junio,\n\ntwo commits in pu currently add tests with broken && chains:\n\nabbfd017 in cw/ws-indent-with-tab:\n\ndiff --git a/t/t4015-diff-whitespace.sh b/t/t4015-diff-whitespace.sh\nindex 9e57f80..e92eab0 100755\n--- a/t/t4015-diff-whitespace.sh\n+++ b/t/t4015-diff-whitespace.sh\n@@ -354,7 +354,7 @@ test_expect_success 'check tabs and spaces as indentation (indent-with-non-tab:\n \n test_expect_success 'check tabs as indentation (tab-in-indent: off)' '\n \n-\tgit config core.whitespace \"-tab-in-indent\"\n+\tgit config core.whitespace \"-tab-in-indent\" &&\n \techo \"\tfoo ();\" > x &&\n \tgit diff --check\n \n@@ -378,7 +378,7 @@ test_expect_success 'check tabs and spaces as indentation (tab-in-indent: on)' '\n \n test_expect_success 'check tab-in-indent and indent-with-non-tab conflict' '\n \n-\tgit config core.whitespace \"tab-in-indent,indent-with-non-tab\"\n+\tgit config core.whitespace \"tab-in-indent,indent-with-non-tab\" &&\n \techo \"foo ();\" > x &&\n \ttest_must_fail git diff --check\n \n@@ -386,7 +386,7 @@ test_expect_success 'check tab-in-indent and indent-with-non-tab conflict' '\n \n test_expect_success 'check tab-in-indent excluded from wildcard whitespace attribute' '\n \n-\tgit config --unset core.whitespace\n+\tgit config --unset core.whitespace &&\n \techo \"x whitespace\" > .gitattributes &&\n \techo \"\t  foo ();\" > x &&\n \tgit diff --check &&\n\n\n\nc8eeb6301 in sr/remote-helper-export\n\ndiff --git a/t/t5800-remote-helpers.sh b/t/t5800-remote-helpers.sh\nindex 33f546b..eb31709 100755\n--- a/t/t5800-remote-helpers.sh\n+++ b/t/t5800-remote-helpers.sh\n@@ -9,7 +9,7 @@ test_description='Test remote-helper import and export commands'\n \n test_expect_success 'setup repository' '\n \tgit init --bare server/.git &&\n-\tgit clone server public\n+\tgit clone server public &&\n \t(cd public &&\n \t echo content >file &&\n \t git add file &&\n@@ -18,7 +18,7 @@ test_expect_success 'setup repository' '\n '\n \n test_expect_success 'cloning from local repo' '\n-\tgit clone \"testgit::${PWD}/server\" localclone\n+\tgit clone \"testgit::${PWD}/server\" localclone &&\n \ttest_cmp public/file localclone/file\n '\n \n"},{"id":"138553","messageId":"v2yfabb9a1e1004041315x999376f6m7dd689b529ce33d8@mail.gmail.com","threadId":"23331","inReplyTo":"201004042208.58939.j6t@kdbg.org","subject":"Re: Tests with broken && chains in pu","fromName":"Sverre Rabbelier","fromEmail":"srabbelier@gmail.com","sentAt":"2010-04-04T20:15:27Z","receivedAt":"2010-04-04T20:15:27Z","isPatch":false,"sender":{"key":"srabbelier@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3098?v=4"},"body":"Heya,\n\nOn Sun, Apr 4, 2010 at 15:08, Johannes Sixt <j6t@kdbg.org> wrote:\n> two commits in pu currently add tests with broken && chains:\n\n> diff --git a/t/t5800-remote-helpers.sh b/t/t5800-remote-helpers.sh\n> index 33f546b..eb31709 100755\n> --- a/t/t5800-remote-helpers.sh\n> +++ b/t/t5800-remote-helpers.sh\n> @@ -9,7 +9,7 @@ test_description='Test remote-helper import and export commands'\n>\n>  test_expect_success 'setup repository' '\n>        git init --bare server/.git &&\n> -       git clone server public\n> +       git clone server public &&\n>        (cd public &&\n>         echo content >file &&\n>         git add file &&\n> @@ -18,7 +18,7 @@ test_expect_success 'setup repository' '\n>  '\n>\n>  test_expect_success 'cloning from local repo' '\n> -       git clone \"testgit::${PWD}/server\" localclone\n> +       git clone \"testgit::${PWD}/server\" localclone &&\n>        test_cmp public/file localclone/file\n>  '\n\nThanks for noticing, may I ask how you noticed? Do you have a script\nor was it manual review?\n\n-- \nCheers,\n\nSverre Rabbelier\n"},{"id":"138555","messageId":"201004042241.17655.j6t@kdbg.org","threadId":"23331","inReplyTo":"v2yfabb9a1e1004041315x999376f6m7dd689b529ce33d8@mail.gmail.com","subject":"Re: Tests with broken && chains in pu","fromName":"Johannes Sixt","fromEmail":"j6t@kdbg.org","sentAt":"2010-04-04T20:41:17Z","receivedAt":"2010-04-04T20:41:17Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"On Sonntag, 4. April 2010, Sverre Rabbelier wrote:\n> Thanks for noticing, may I ask how you noticed? Do you have a script\n> or was it manual review?\n\nIt was manual review. I reviewed the patches in pu because I noticed a broken \n&& chain in a recently submitted patch, but I didn't remember which one it \nwas. So I took the time to look at all new test cases in pu after Junio's \nrecent What's in git message.\n\n-- Hannes\n"},{"id":"138556","messageId":"20100404204509.GA31315@arachsys.com","threadId":"23331","inReplyTo":"201004042208.58939.j6t@kdbg.org","subject":"Re: Tests with broken && chains in pu","fromName":"Chris Webb","fromEmail":"chris@arachsys.com","sentAt":"2010-04-04T20:45:09Z","receivedAt":"2010-04-04T20:45:09Z","isPatch":false,"sender":{"key":"chris@arachsys.com","avatar":"https://avatars.githubusercontent.com/u/299056?v=4"},"body":"Johannes Sixt <j6t@kdbg.org> writes:\n\n> two commits in pu currently add tests with broken && chains:\n> abbfd017 in cw/ws-indent-with-tab:\n\nThanks for spotting this mistake Johannes. Should I resubmit a corrected\nversion of the patch, Junio, or do you prefer to squash fixups directly into\nthe pu branch?\n\nBest wishes,\n\nChris.\n"},{"id":"138558","messageId":"7vochy7vrm.fsf@alter.siamese.dyndns.org","threadId":"23331","inReplyTo":"201004042208.58939.j6t@kdbg.org","subject":"Re: Tests with broken && chains in pu","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-04-04T21:28:13Z","receivedAt":"2010-04-04T21:28:13Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks; will squash these in and rebuild the topics.\n"}]}