{"thread":{"id":"23289","subject":"[PATCH] fix some resource leaks discovered by cppcheck","startedAt":"2010-04-01T20:01:09Z","lastAt":"2010-04-01T20:01:09Z","messageCount":1,"participants":["Igor Murzov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"138356","messageId":"1270152069-28816-1-git-send-email-igor@gplsoft.org","threadId":"23289","inReplyTo":null,"subject":"[PATCH] fix some resource leaks discovered by cppcheck","fromName":"Igor Murzov","fromEmail":"igor@gplsoft.org","sentAt":"2010-04-01T20:01:09Z","receivedAt":"2010-04-01T20:01:09Z","isPatch":true,"sender":{"key":"igor@gplsoft.org","avatar":null},"body":"---\n builtin/fmt-merge-msg.c |    2 ++\n builtin/rerere.c        |    1 +\n transport.c             |    1 +\n 3 files changed, 4 insertions(+), 0 deletions(-)\n\ndiff --git a/builtin/fmt-merge-msg.c b/builtin/fmt-merge-msg.c\nindex 9d52400..7c9ee96 100644\n--- a/builtin/fmt-merge-msg.c\n+++ b/builtin/fmt-merge-msg.c\n@@ -373,6 +373,8 @@ int cmd_fmt_merge_msg(int argc, const char **argv, const char *prefix)\n \n \tif (strbuf_read(&input, fileno(in), 0) < 0)\n \t\tdie_errno(\"could not read input file\");\n+\tif(in != stdin)\n+\t\tfclose(in);\n \tret = fmt_merge_msg(merge_summary, &input, &output);\n \tif (ret)\n \t\treturn ret;\ndiff --git a/builtin/rerere.c b/builtin/rerere.c\nindex 34f9ace..de76d48 100644\n--- a/builtin/rerere.c\n+++ b/builtin/rerere.c\n@@ -64,6 +64,7 @@ static void garbage_collect(struct string_list *rr)\n \tfor (i = 0; i < to_remove.nr; i++)\n \t\tunlink_rr_item(to_remove.items[i].string);\n \tstring_list_clear(&to_remove, 0);\n+\tclosedir(dir);\n }\n \n static int outf(void *dummy, mmbuffer_t *ptr, int nbuf)\ndiff --git a/transport.c b/transport.c\nindex 8ce3936..1c61145 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -134,6 +134,7 @@ static void insert_packed_refs(const char *packed_refs, struct ref **list)\n \t\t\tlist = &(*list)->next;\n \t\t}\n \t}\n+\tfclose(f);\n }\n \n static void set_upstreams(struct transport *transport, struct ref *refs,\n-- \n1.7.0.3.313.g87b3c.dirty\n"}]}