{"thread":{"id":"23284","subject":"[PATCHv5 5/6] gitweb: add documentation to INSTALL regarding gitweb.js","startedAt":"2010-04-01T05:37:01Z","lastAt":"2010-04-01T11:46:53Z","messageCount":2,"participants":["Mark Rada","Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"138326","messageId":"4BB430FD.3050306@mailservices.uwaterloo.ca","threadId":"23284","inReplyTo":null,"subject":"[PATCHv5 5/6] gitweb: add documentation to INSTALL regarding gitweb.js","fromName":"Mark Rada","fromEmail":"marada@uwaterloo.ca","sentAt":"2010-04-01T05:37:01Z","receivedAt":"2010-04-01T05:37:01Z","isPatch":false,"sender":{"key":"marada@uwaterloo.ca","avatar":"https://avatars.githubusercontent.com/u/38430?v=4"},"body":"This patch updates gitweb/INSTALL to mention gitweb.js, including\nJavaScript minification support.\n\nSigned-off-by: Mark Rada <marada@uwaterloo.ca>\n\n---\n\nChanges since v4:\n\t- Compacted the point about minification into CSS\n\t  point about minification\n\n gitweb/INSTALL |   23 +++++++++++++----------\n 1 files changed, 13 insertions(+), 10 deletions(-)\n\ndiff --git a/gitweb/INSTALL b/gitweb/INSTALL\nindex b75a90b..a79a183 100644\n--- a/gitweb/INSTALL\n+++ b/gitweb/INSTALL\n@@ -3,8 +3,9 @@ GIT web Interface (gitweb) Installation\n \n First you have to generate gitweb.cgi from gitweb.perl using\n \"make gitweb/gitweb.cgi\", then copy appropriate files (gitweb.cgi,\n-gitweb.css, git-logo.png and git-favicon.png) to their destination.\n-For example if git was (or is) installed with /usr prefix, you can do\n+gitweb.js, gitweb.css, git-logo.png and git-favicon.png) to their\n+destination. For example if git was (or is) installed with /usr prefix,\n+you can do\n \n \t$ make prefix=/usr gitweb/gitweb.cgi  ;# as yourself\n \t# cp gitweb/git* /var/www/cgi-bin/    ;# as root\n@@ -62,14 +63,15 @@ file for gitweb (in gitweb/README).\n   a suggestion).\n \n - You can control where gitweb tries to find its main CSS style file,\n-  its favicon and logo with the GITWEB_CSS, GITWEB_FAVICON and GITWEB_LOGO\n-  build configuration variables. By default gitweb tries to find them\n-  in the same directory as gitweb.cgi script.\n+  its JavaScript file, its favicon and logo with the GITWEB_CSS, GITWEB_JS\n+  GITWEB_FAVICON and GITWEB_LOGO build configuration variables. By default\n+  gitweb tries to find them in the same directory as gitweb.cgi script.\n \n-- You can optionally generate a minified version of gitweb.css by defining\n-  the CSSMIN build configuration variable. By default the non-minified\n-  version of gitweb.css will be used. NOTE: if you enable this option,\n-  substitute gitweb.min.css for all uses of gitweb.css in the help files.\n+- You can optionally generate minified versions of gitweb.js and gitweb.css\n+  by defining the JSMIN and CSSMIN build configuration variables. By default\n+  the non-minified versions will be used. NOTE: if you enable this option,\n+  substitute gitweb.min.js and gitweb.min.css for all uses of gitweb.js and\n+  gitweb.css in the help files.\n \n Build example\n ~~~~~~~~~~~~~\n@@ -79,13 +81,14 @@ Build example\n   we want to display are under /home/local/scm, you can do\n \n \tmake GITWEB_PROJECTROOT=\"/home/local/scm\" \\\n+             GITWEB_JS=\"/gitweb/gitweb.js\" \\\n \t     GITWEB_CSS=\"/gitweb/gitweb.css\" \\\n \t     GITWEB_LOGO=\"/gitweb/git-logo.png\" \\\n \t     GITWEB_FAVICON=\"/gitweb/git-favicon.png\" \\\n \t     bindir=/usr/local/bin \\\n \t     gitweb/gitweb.cgi\n \n-\tcp -fv ~/git/gitweb/gitweb.{cgi,css} \\\n+\tcp -fv ~/git/gitweb/gitweb.{cgi,js,css} \\\n \t       ~/git/gitweb/git-{favicon,logo}.png \\\n \t     /var/www/cgi-bin/gitweb/\n \n-- \n1.7.0.3.436.g45b2d\n"},{"id":"138337","messageId":"201004011346.54530.jnareb@gmail.com","threadId":"23284","inReplyTo":"4BB430FD.3050306@mailservices.uwaterloo.ca","subject":"Re: [PATCHv5 5/6] gitweb: add documentation to INSTALL regarding gitweb.js","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-04-01T11:46:53Z","receivedAt":"2010-04-01T11:46:53Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Thu, 1 Apr 2010, Mark Rada wrote:\n\n> This patch updates gitweb/INSTALL to mention gitweb.js, including\n> JavaScript minification support.\n> \n> Signed-off-by: Mark Rada <marada@uwaterloo.ca>\n\nThanks for this writeup.\n\nFor what it is worth:\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n \n> ---\n> \n> Changes since v4:\n> \t- Compacted the point about minification into CSS\n> \t  point about minification\n\nNice to have differences from previous version described in \ncomments...\n\n> \n>  gitweb/INSTALL |   23 +++++++++++++----------\n>  1 files changed, 13 insertions(+), 10 deletions(-)\n\nThis change migh have been a bit smaller without accompanying\nrewrapping of affected paragraphs, but on the other hand it would\nleave gitweb/INSTALL less readable.\n \n\n> @@ -79,13 +81,14 @@ Build example\n>    we want to display are under /home/local/scm, you can do\n>  \n>  \tmake GITWEB_PROJECTROOT=\"/home/local/scm\" \\\n> +             GITWEB_JS=\"/gitweb/gitweb.js\" \\\n\nMinor nit: other lines use TAB + 5 x SPACE, so it should read:\n\n  +\t     GITWEB_JS=\"/gitweb/gitweb.js\" \\\n\n   -----^^^^^\n\n>  \t     GITWEB_CSS=\"/gitweb/gitweb.css\" \\\n>  \t     GITWEB_LOGO=\"/gitweb/git-logo.png\" \\\n>  \t     GITWEB_FAVICON=\"/gitweb/git-favicon.png\" \\\n>  \t     bindir=/usr/local/bin \\\n>  \t     gitweb/gitweb.cgi\n\n-- \nJakub Narebski\nPoland\n"}]}