{"thread":{"id":"23278","subject":"[PATCHv5 1/6] Gitweb: add ignore and clean rules for minified files","startedAt":"2010-04-01T05:35:28Z","lastAt":"2010-04-01T21:26:20Z","messageCount":3,"participants":["Mark Rada","Jakub Narebski","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"138320","messageId":"4BB430A0.7040700@mailservices.uwaterloo.ca","threadId":"23278","inReplyTo":null,"subject":"[PATCHv5 1/6] Gitweb: add ignore and clean rules for minified files","fromName":"Mark Rada","fromEmail":"marada@uwaterloo.ca","sentAt":"2010-04-01T05:35:28Z","receivedAt":"2010-04-01T05:35:28Z","isPatch":false,"sender":{"key":"marada@uwaterloo.ca","avatar":"https://avatars.githubusercontent.com/u/38430?v=4"},"body":"Signed-off-by: Mark Rada <marada@uwaterloo.ca>\n\n---\n\n\tNo changes since the previous version.\n\n .gitignore |    1 +\n Makefile   |    2 +-\n 2 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/.gitignore b/.gitignore\nindex 7b3acb7..4c24152 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -156,6 +156,7 @@\n /git-core-*/?*\n /gitk-git/gitk-wish\n /gitweb/gitweb.cgi\n+/gitweb/gitweb.min.*\n /test-chmtime\n /test-ctype\n /test-date\ndiff --git a/Makefile b/Makefile\nindex 6d73a8c..5384d33 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2089,7 +2089,7 @@ clean:\n \t$(RM) $(htmldocs).tar.gz $(manpages).tar.gz\n \t$(MAKE) -C Documentation/ clean\n ifndef NO_PERL\n-\t$(RM) gitweb/gitweb.cgi\n+\t$(RM) gitweb/gitweb.{cgi,min.*}\n \t$(MAKE) -C perl clean\n endif\n ifndef NO_PYTHON\n-- \n1.7.0.3.436.g45b2d\n"},{"id":"138333","messageId":"201004011024.50615.jnareb@gmail.com","threadId":"23278","inReplyTo":"4BB430A0.7040700@mailservices.uwaterloo.ca","subject":"Re: [PATCHv5 1/6] Gitweb: add ignore and clean rules for minified files","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2010-04-01T08:24:48Z","receivedAt":"2010-04-01T08:24:48Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Thu, 1 April 2010, Mark Rada wrote:\n\n> Signed-off-by: Mark Rada <marada@uwaterloo.ca>\n\nFor what it's worth:\nAcked-by: Jakub Narebski <jnareb@gmail.com> \n\n> diff --git a/Makefile b/Makefile\n> index 6d73a8c..5384d33 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -2089,7 +2089,7 @@ clean:\n>  \t$(RM) $(htmldocs).tar.gz $(manpages).tar.gz\n>  \t$(MAKE) -C Documentation/ clean\n>  ifndef NO_PERL\n> -\t$(RM) gitweb/gitweb.cgi\n> +\t$(RM) gitweb/gitweb.{cgi,min.*}\n>  \t$(MAKE) -C perl clean\n>  endif\n\nMinor nit: this would be first line that uses {a,b} shell glob \nconstruct.  Why not write it as:\n\n  -\t$(RM) gitweb/gitweb.cgi\n  +\t$(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*\n\n-- \nJakub Narebski\nPoland\n"},{"id":"138362","messageId":"7vaatmooeb.fsf@alter.siamese.dyndns.org","threadId":"23278","inReplyTo":"201004011024.50615.jnareb@gmail.com","subject":"Re: [PATCHv5 1/6] Gitweb: add ignore and clean rules for minified files","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-04-01T21:26:20Z","receivedAt":"2010-04-01T21:26:20Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jakub Narebski <jnareb@gmail.com> writes:\n\n>>  ifndef NO_PERL\n>> -\t$(RM) gitweb/gitweb.cgi\n>> +\t$(RM) gitweb/gitweb.{cgi,min.*}\n>>  \t$(MAKE) -C perl clean\n>>  endif\n>\n> Minor nit: this would be first line that uses {a,b} shell glob \n> construct.  Why not write it as:\n>\n>   -\t$(RM) gitweb/gitweb.cgi\n>   +\t$(RM) gitweb/gitweb.cgi gitweb/gitweb.min.*\n\nVery good point and it is not a \"minor nit\"; I cannot apply the patch\nwithout your fix.\n\nMy understanding is that you Ack 1 (with this fix), 2 (with another\nparagraph in the log message), and 5.  Eric Acked 4 and 6 needs to be\nreworked.  I wonder if anybody has comments on 3; I didn't look very\nclosely at it, but it looked sane to me.\n\nWith that understanding, I'll queue the whole thing to 'pu', so that they\ncan be reworked and replaced before hitting 'next'.\n\nThanks, all.\n"}]}