{"thread":{"id":"2318","subject":"[PATCH] Clean up the SunOS Makefile rule","startedAt":"2005-11-02T19:27:31Z","lastAt":"2005-11-02T20:56:12Z","messageCount":3,"participants":["Peter Eriksen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"11022","messageId":"20051102192730.GA17706@ebar091.ebar.dtu.dk","threadId":"2318","inReplyTo":null,"subject":"[PATCH] Clean up the SunOS Makefile rule","fromName":"Peter Eriksen","fromEmail":"s022018@student.dtu.dk","sentAt":"2005-11-02T19:27:31Z","receivedAt":"2005-11-02T19:27:31Z","isPatch":true,"sender":{"key":"s022018@student.dtu.dk","avatar":null},"body":"Don't set a non-standard CURLDIR as default, and fix an error\nin Solaris 10 by setting NEEDS_LIBICONV.\n\n---\n\nI hope this is ok, since I was the one suggesting the\nstupid non-standard /opt/sfw path in the first place.\nFurther more Solaris 10 seems to need NEEDS_LIBICONV.\n\nI hope other people who know more about Solaris \nthan me could point out, what will work on any \nSolaris system and not just the specific one I'm using.\n\nRegards,\n\nPeter\n \n Makefile |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\napplies-to: b774cd64105bda561bba3c528a7fea19b87755a1\n5f5bb71e10f8f3e92df2475a456d73d5ee7ca55a\ndiff --git a/Makefile b/Makefile\nindex 357cb3e..cdd19c3 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -189,9 +189,9 @@ endif\n ifeq ($(uname_S),SunOS)\n \tNEEDS_SOCKET = YesPlease\n \tNEEDS_NSL = YesPlease\n+\tNEEDS_LIBICONV = YesPlease\n \tSHELL_PATH = /bin/bash\n \tNO_STRCASESTR = YesPlease\n-\tCURLDIR = /opt/sfw\n \tINSTALL = ginstall\n \tTAR = gtar\n \tPLATFORM_DEFINES += -D__EXTENSIONS__\n---\n0.99.9.GIT\n"},{"id":"11024","messageId":"20051102194947.GB17706@ebar091.ebar.dtu.dk","threadId":"2318","inReplyTo":"20051102192730.GA17706@ebar091.ebar.dtu.dk","subject":"Re: [PATCH] Clean up the SunOS Makefile rule","fromName":"Peter Eriksen","fromEmail":"s022018@student.dtu.dk","sentAt":"2005-11-02T19:49:48Z","receivedAt":"2005-11-02T19:49:48Z","isPatch":true,"sender":{"key":"s022018@student.dtu.dk","avatar":null},"body":"On Wed, Nov 02, 2005 at 08:27:31PM +0100, Peter Eriksen wrote:\n> Don't set a non-standard CURLDIR as default, and fix an error\n> in Solaris 10 by setting NEEDS_LIBICONV.\n\nUps, I forgot to say, that this is\n\nSigned-off-by: Peter Eriksen <s022018@student.dtu.dk>\n\nRegards,\n\nPeter\n"},{"id":"11033","messageId":"7voe52py4z.fsf@assigned-by-dhcp.cox.net","threadId":"2318","inReplyTo":"20051102192730.GA17706@ebar091.ebar.dtu.dk","subject":"Re: [PATCH] Clean up the SunOS Makefile rule","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-11-02T20:56:12Z","receivedAt":"2005-11-02T20:56:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Peter Eriksen\" <s022018@student.dtu.dk> writes:\n\n> Don't set a non-standard CURLDIR as default, and fix an error\n> in Solaris 10 by setting NEEDS_LIBICONV.\n\nJust to make it clear to everybody, these platform defines are\njust to give default that is intended to help majority of the\nusers.  You do not have to cover everybody on that platform.\nGiving *one* default CURLDIR, as long as it helps major portion\nof the user base, would be helpful.  In other words, it is OK as\nlong as the user can say:\n\n\tsolaris$ gmake CURLDIR=/I/have/my/curl/here\n\nto override what you chose, and /opt/sfw/ is where *many* (if\nnot most) of the Solaris installations have curl.  I do not have\naccess to many different flavours of Solaris boxes, but one\nmachine I have at work (5.9) seems to have it installed there.\n\nCould Solaris users on the list help us out, as Peter asks?  How\nmany of you have curl in /opt/sfw?  How many others have curl in\nsomewhere else and think that somewhere else would be more\nappropriate default?  If this user poll results in either a\ndefault location better than /opt/sfw, or diverse locations with\nno clear majority, then it would make sense to remove the\ncurrent default, but otherwise I would say we do not need to\ndrop it.\n\nPeople who built curl library and installed at random places\nthemselves do not count -- they know what they are doing and are\nperfectly capable of overriding whatever we say in our Makefile\nfrom the comand line.\n\nAlthough I think always requiring LIBICONV is OK there, and it\nprobably is needed on *all* Solaris boxes, but in principle,\nNEEDS_LIBICONV is similar.  If the user cannot say:\n\n\tsolaris$ gmake NEEDS_LIBICONV= ;# No thanks, on my Solaris\n\nto disable -liconv, and if some Solaris installations do not\nwant -liconv, then that is a problem.  But GNU make seems to do\nthe right thing; ifdef NEEDS_LIBICONV seems to evaluate to false\nif your user overrides it to be empty from the command line.\n"}]}