{"thread":{"id":"23156","subject":"GIT_ONE_FILESYSTEM inclusion?","startedAt":"2010-03-23T23:20:55Z","lastAt":"2010-03-28T09:24:07Z","messageCount":14,"participants":["Lars Damerow","Alex Riesen","Johannes Sixt","Matthieu Moy","Junio C Hamano","David Aguilar","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"137676","messageId":"20100323232055.GV7038@pixar.com","threadId":"23156","inReplyTo":null,"subject":"GIT_ONE_FILESYSTEM inclusion?","fromName":"Lars Damerow","fromEmail":"lars@pixar.com","sentAt":"2010-03-23T23:20:55Z","receivedAt":"2010-03-23T23:20:55Z","isPatch":false,"sender":{"key":"lars@pixar.com","avatar":"https://avatars.githubusercontent.com/u/318366?v=4"},"body":"Hi all,\n\nJust wondering if anyone has any further comments or suggestions for the\nGIT_ONE_FILESYSTEM patches I posted. See here for context:\n\n http://thread.gmane.org/gmane.comp.version-control.git/142436\n\nIf it looks good I'd love to have it considered for inclusion.\n\nThanks!\n-lars\n\n--\nlars r. damerow :: button pusher :: pixar animation studios\n"},{"id":"137696","messageId":"81b0412b1003240229l6f7eaa18l563c3d7ba0cf6cc5@mail.gmail.com","threadId":"23156","inReplyTo":"20100323232055.GV7038@pixar.com","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2010-03-24T09:29:59Z","receivedAt":"2010-03-24T09:29:59Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On Wed, Mar 24, 2010 at 00:20, Lars Damerow wrote:\n> Just wondering if anyone has any further comments or suggestions for the\n> GIT_ONE_FILESYSTEM patches I posted. See here for context:\n>\n>    http://thread.gmane.org/gmane.comp.version-control.git/142436\n>\n> If it looks good I'd love to have it considered for inclusion.\n\nHave considered making it an option to git wrapper as suggested\n(-x/--one-filesystem)?\nAnd while at it, how about making it a config option? (i.e. core.oneFilesystem?)\n"},{"id":"137697","messageId":"4BA9DCDD.6060109@viscovery.net","threadId":"23156","inReplyTo":"81b0412b1003240229l6f7eaa18l563c3d7ba0cf6cc5@mail.gmail.com","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"Johannes Sixt","fromEmail":"j.sixt@viscovery.net","sentAt":"2010-03-24T09:35:25Z","receivedAt":"2010-03-24T09:35:25Z","isPatch":false,"sender":{"key":"j6t@kdbg.org","avatar":"https://avatars.githubusercontent.com/u/14810926?v=4"},"body":"Am 3/24/2010 10:29, schrieb Alex Riesen:\n> And while at it, how about making it a config option? (i.e. core.oneFilesystem?)\n\nIt's difficult to have this as a config option when you are looking for a\nrepository... ;)\n\n-- Hannes\n"},{"id":"137699","messageId":"81b0412b1003240437n799bac07sb74db749d647817d@mail.gmail.com","threadId":"23156","inReplyTo":"4BA9DCDD.6060109@viscovery.net","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2010-03-24T11:37:39Z","receivedAt":"2010-03-24T11:37:39Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On Wed, Mar 24, 2010 at 10:35, Johannes Sixt wrote:\n> Am 3/24/2010 10:29, schrieb Alex Riesen:\n>> And while at it, how about making it a config option? (i.e. core.oneFilesystem?)\n>\n> It's difficult to have this as a config option when you are looking for a\n> repository... ;)\n>\n\nIsn't it a little pointless to look for repository when you can't\naccess its config?\n"},{"id":"137702","messageId":"20100324134048.GB10190@pixar.com","threadId":"23156","inReplyTo":"81b0412b1003240437n799bac07sb74db749d647817d@mail.gmail.com","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"Lars Damerow","fromEmail":"lars@pixar.com","sentAt":"2010-03-24T13:40:49Z","receivedAt":"2010-03-24T13:40:49Z","isPatch":false,"sender":{"key":"lars@pixar.com","avatar":"https://avatars.githubusercontent.com/u/318366?v=4"},"body":">From Alex Riesen , Wed, Mar 24, 2010 at 12:37:39PM +0100:\n> \n> Isn't it a little pointless to look for repository when you can't\n> access its config?\n\nIf you're doing the trendy thing of putting repository information in\nyour shell prompt, then your prompt is looking for a repository every\ntime you change a directory.\n\nAs for making this a command-line option: that's certainly doable, but\nit makes it harder to enforce the option's use across an organization.\nIt's far easier for me to set an environment variable centrally on a\nthousand workstations than to convince a potentially large number of\nusers to set a new shell alias for git.\n\nthanks,\n-lars\n\n--\nlars r. damerow :: button pusher :: pixar animation studios\n"},{"id":"137701","messageId":"vpqd3yt4yyp.fsf@bauges.imag.fr","threadId":"23156","inReplyTo":"81b0412b1003240437n799bac07sb74db749d647817d@mail.gmail.com","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@grenoble-inp.fr","sentAt":"2010-03-24T13:43:26Z","receivedAt":"2010-03-24T13:43:26Z","isPatch":false,"sender":{"key":"matthieu.moy@grenoble-inp.fr","avatar":"https://gravatar.com/avatar/72c8a2705971a25dfaff23cece15130d405685845d911aedd5667ace277f3fc5?d=mp&s=160"},"body":"Alex Riesen writes:\n\n> On Wed, Mar 24, 2010 at 10:35, Johannes Sixt wrote:\n>> Am 3/24/2010 10:29, schrieb Alex Riesen:\n>>> And while at it, how about making it a config option? (i.e. core.oneFilesystem?)\n>>\n>> It's difficult to have this as a config option when you are looking for a\n>> repository... ;)\n>>\n>\n> Isn't it a little pointless to look for repository when you can't\n> access its config?\n\nI guess Johannes's point is that the config option can be in\n$GIT_DIR/config, which you can't access when looking for $GIT_DIR.\nOTOH, looking at ~/.gitconfig to find a core.oneFilesystem makes sense\n(but is probably painfull to implement since the current code to parse\nconfig file will look for $GIT_DIR first).\n\n-- \nMatthieu Moy\nhttp://www-verimag.imag.fr/~moy/\n"},{"id":"137703","messageId":"81b0412b1003240659u4e6de405t7750b66ca9292cdc@mail.gmail.com","threadId":"23156","inReplyTo":"20100324134048.GB10190@pixar.com","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2010-03-24T13:59:00Z","receivedAt":"2010-03-24T13:59:00Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On Wed, Mar 24, 2010 at 14:40, Lars Damerow wrote:\n> From Alex Riesen , Wed, Mar 24, 2010 at 12:37:39PM +0100:\n>>\n>> Isn't it a little pointless to look for repository when you can't\n>> access its config?\n>\n> If you're doing the trendy thing of putting repository information in\n> your shell prompt, then your prompt is looking for a repository every\n> time you change a directory.\n\nRight. OTOH, if you know that your .git is accessible (on the right\nfilesystem), but want to avoid scans in the directories below the top-\nlevel working directory (submodules?), you may want to have it\nconfigurable per-repository. The environment variable will affect\nscan in all your repositories you visit in this session, which maybe\nwhat you want, and maybe not.\nAnd yes, the config option is also in addition to, not instead of\nthe environment variable.\n\n> As for making this a command-line option: that's certainly doable, but\n> it makes it harder to enforce the option's use across an organization.\n> It's far easier for me to set an environment variable centrally on a\n> thousand workstations than to convince a potentially large number of\n> users to set a new shell alias for git.\n\nOh, I wasn't clear. I didn't mean \"instead of\". A command-line option\n_in_addition_ to the environment variable. For one-off uses.\n"},{"id":"137710","messageId":"7vpr2tu1bd.fsf@alter.siamese.dyndns.org","threadId":"23156","inReplyTo":"81b0412b1003240659u4e6de405t7750b66ca9292cdc@mail.gmail.com","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-03-24T16:33:26Z","receivedAt":"2010-03-24T16:33:26Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alex Riesen writes:\n\n> Oh, I wasn't clear. I didn't mean \"instead of\". A command-line option\n> _in_addition_ to the environment variable. For one-off uses.\n\nI may have been the one who mentioned \"-x to git potty\" as a possibility,\nbut I agree with Lars---I think it would be too cumbersome to use in\npractice.\n\nWhen would you invoke this feature as \"one-off\"?\n"},{"id":"137723","messageId":"81b0412b1003241207s4951b32cpbe105e7b3623f61a@mail.gmail.com","threadId":"23156","inReplyTo":"7vpr2tu1bd.fsf@alter.siamese.dyndns.org","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2010-03-24T19:07:03Z","receivedAt":"2010-03-24T19:07:03Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On Wed, Mar 24, 2010 at 17:33, Junio C Hamano wrote:\n> Alex Riesen writes:\n>\n>> Oh, I wasn't clear. I didn't mean \"instead of\". A command-line option\n>> _in_addition_ to the environment variable. For one-off uses.\n>\n> I may have been the one who mentioned \"-x to git potty\" as a possibility,\n> but I agree with Lars---I think it would be too cumbersome to use in\n> practice.\n>\n> When would you invoke this feature as \"one-off\"?\n>\n\nMaybe when I want to make sure git status does not go all over an\nNFS mounted submodule.\n\nBut frankly, I think it will be the most obscure feature of Git ever,\nwith a command-line option or without. I just wanted to suggest\n(and actually, just should have, stupid me) to keep it in line with\nother similar configurations, which are present in all three forms\n(work tree comes to mind... Come to think of it, only the work tree).\n"},{"id":"137730","messageId":"7vwrx1fpv9.fsf@alter.siamese.dyndns.org","threadId":"23156","inReplyTo":"81b0412b1003241207s4951b32cpbe105e7b3623f61a@mail.gmail.com","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-03-24T20:04:26Z","receivedAt":"2010-03-24T20:04:26Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alex Riesen writes:\n\n>> When would you invoke this feature as \"one-off\"?\n>\n> Maybe when I want to make sure git status does not go all over an\n> NFS mounted submodule.\n\nBut then what would you do after finding it out that it might? You stop\nworking on that project? Doesn't --ignore-submodules do the same thing?\n"},{"id":"137732","messageId":"20100324200733.GG7038@pixar.com","threadId":"23156","inReplyTo":"81b0412b1003241207s4951b32cpbe105e7b3623f61a@mail.gmail.com","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"Lars Damerow","fromEmail":"lars@pixar.com","sentAt":"2010-03-24T20:07:34Z","receivedAt":"2010-03-24T20:07:34Z","isPatch":false,"sender":{"key":"lars@pixar.com","avatar":"https://avatars.githubusercontent.com/u/318366?v=4"},"body":">From Alex Riesen , Wed, Mar 24, 2010 at 08:07:03PM +0100:\n> But frankly, I think it will be the most obscure feature of Git ever,\n\nWow. Would I win a prize or something? :)\n\n--\nlars r. damerow :: button pusher :: pixar animation studios\n"},{"id":"137741","messageId":"81b0412b1003241336n71b4f5ael7ecbb72236a245db@mail.gmail.com","threadId":"23156","inReplyTo":"7vwrx1fpv9.fsf@alter.siamese.dyndns.org","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2010-03-24T20:36:14Z","receivedAt":"2010-03-24T20:36:14Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On Wed, Mar 24, 2010 at 21:04, Junio C Hamano wrote:\n> Alex Riesen writes:\n>\n>>> When would you invoke this feature as \"one-off\"?\n>>\n>> Maybe when I want to make sure git status does not go all over an\n>> NFS mounted submodule.\n>\n> But then what would you do after finding it out that it might?  You stop\n\nPostpone whatever you were about to do, maybe.\n\n> working on that project?  Doesn't --ignore-submodules do the same thing?\n\nIt does. I said it is obscure.\n"},{"id":"137977","messageId":"20100327222730.GA10922@gmail.com","threadId":"23156","inReplyTo":"vpqd3yt4yyp.fsf@bauges.imag.fr","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"David Aguilar","fromEmail":"davvid@gmail.com","sentAt":"2010-03-27T22:27:32Z","receivedAt":"2010-03-27T22:27:32Z","isPatch":false,"sender":{"key":"davvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13196?v=4"},"body":"On Wed, Mar 24, 2010 at 02:43:26PM +0100, Matthieu Moy wrote:\n> Alex Riesen writes:\n> \n> > On Wed, Mar 24, 2010 at 10:35, Johannes Sixt wrote:\n> >> Am 3/24/2010 10:29, schrieb Alex Riesen:\n> >>> And while at it, how about making it a config option? (i.e. core.oneFilesystem?)\n> >>\n> >> It's difficult to have this as a config option when you are looking for a\n> >> repository... ;)\n> >>\n> >\n> > Isn't it a little pointless to look for repository when you can't\n> > access its config?\n> \n> I guess Johannes's point is that the config option can be in\n> $GIT_DIR/config, which you can't access when looking for $GIT_DIR.\n> OTOH, looking at ~/.gitconfig to find a core.oneFilesystem makes sense\n> (but is probably painfull to implement since the current code to parse\n> config file will look for $GIT_DIR first).\n> \n> -- \n> Matthieu Moy\n> http://www-verimag.imag.fr/~moy/\n\nRight.\n\nAs this thread showed, we can't have a config option for this\nfeature. Were there any other objections to the patch?\nIt looks good to me.\n\nPeff also agreed that it was an overall improvement.\nhttp://thread.gmane.org/gmane.comp.version-control.git/142262\n\nThread with the latest (v3) version of the patch:\nhttp://thread.gmane.org/gmane.comp.version-control.git/142436\n\nWe could use this feature at Disney Animation as well.\nWe maintain a list of $GIT_CEILING_DIRECTORIES and could do\nwithout having to maintain it if we had this feature.\n\n\nPlus, Lars is one of the git users that doesn't even flinch when\nthe Perforce servers at Pixar get a hiccup, so we should try and\nhelp our fellow \"renegade\" git users ;-)\n\n-- \n\t\tDavid\n"},{"id":"137999","messageId":"20100328092407.GA17406@coredump.intra.peff.net","threadId":"23156","inReplyTo":"20100327222730.GA10922@gmail.com","subject":"Re: GIT_ONE_FILESYSTEM inclusion?","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2010-03-28T09:24:07Z","receivedAt":"2010-03-28T09:24:07Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Mar 27, 2010 at 03:27:32PM -0700, David Aguilar wrote:\n\n> Peff also agreed that it was an overall improvement.\n> http://thread.gmane.org/gmane.comp.version-control.git/142262\n> \n> Thread with the latest (v3) version of the patch:\n> http://thread.gmane.org/gmane.comp.version-control.git/142436\n\nYep. I had been meaning to review v3, and I just did. With the\nexception of a few minor nits (which I posted in that thread), I think\nit looks good.\n\n-Peff\n"}]}