{"thread":{"id":"23087","subject":"[PATCH] Add ignore and clean rules for gitweb.min.js","startedAt":"2010-03-19T20:09:06Z","lastAt":"2010-03-19T21:06:20Z","messageCount":2,"participants":["Mark Rada","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"137264","messageId":"4BA3D9E2.5070401@mailservices.uwaterloo.ca","threadId":"23087","inReplyTo":null,"subject":"[PATCH] Add ignore and clean rules for gitweb.min.js","fromName":"Mark Rada","fromEmail":"marada@uwaterloo.ca","sentAt":"2010-03-19T20:09:06Z","receivedAt":"2010-03-19T20:09:06Z","isPatch":true,"sender":{"key":"marada@uwaterloo.ca","avatar":"https://avatars.githubusercontent.com/u/38430?v=4"},"body":"\nSigned-off-by: Mark Rada <marada@uwaterloo.ca>\n\n---\n .gitignore |    1 +\n Makefile   |    3 +++\n 2 files changed, 4 insertions(+), 0 deletions(-)\n\ndiff --git a/.gitignore b/.gitignore\nindex 7b3acb7..3558dd2 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -156,6 +156,7 @@\n /git-core-*/?*\n /gitk-git/gitk-wish\n /gitweb/gitweb.cgi\n+/gitweb/gitweb.min.js\n /test-chmtime\n /test-ctype\n /test-date\ndiff --git a/Makefile b/Makefile\nindex f80b25e..cdf16c2 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2078,6 +2078,9 @@ clean:\n \t$(MAKE) -C Documentation/ clean\n ifndef NO_PERL\n \t$(RM) gitweb/gitweb.cgi\n+ifdef JSMIN\n+\t$(RM) gitweb/gitweb.min.js\n+endif #JSMIN\n \t$(MAKE) -C perl clean\n endif\n ifndef NO_PYTHON\n-- \n1.7.0.2.279.gf1ba1c\n"},{"id":"137270","messageId":"7vbpekf2cz.fsf@alter.siamese.dyndns.org","threadId":"23087","inReplyTo":"4BA3D9E2.5070401@mailservices.uwaterloo.ca","subject":"Re: [PATCH] Add ignore and clean rules for gitweb.min.js","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-03-19T21:06:20Z","receivedAt":"2010-03-19T21:06:20Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Mark Rada <marada@uwaterloo.ca> writes:\n\n> Signed-off-by: Mark Rada <marada@uwaterloo.ca>\n\nThanks; one question and a comment.\n\n> ---\n>  .gitignore |    1 +\n>  Makefile   |    3 +++\n>  2 files changed, 4 insertions(+), 0 deletions(-)\n>\n> diff --git a/.gitignore b/.gitignore\n> index 7b3acb7..3558dd2 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -156,6 +156,7 @@\n>  /git-core-*/?*\n>  /gitk-git/gitk-wish\n>  /gitweb/gitweb.cgi\n> +/gitweb/gitweb.min.js\n>  /test-chmtime\n>  /test-ctype\n>  /test-date\n\nQuestion: should this be part of your earlier \"instaweb\" patch, or are\nthey independent?\n\n> diff --git a/Makefile b/Makefile\n> index f80b25e..cdf16c2 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -2078,6 +2078,9 @@ clean:\n>  \t$(MAKE) -C Documentation/ clean\n>  ifndef NO_PERL\n>  \t$(RM) gitweb/gitweb.cgi\n> +ifdef JSMIN\n> +\t$(RM) gitweb/gitweb.min.js\n> +endif #JSMIN\n>  \t$(MAKE) -C perl clean\n>  endif\n\nRunning \"make clean\" in perl/ should stay in \"ifndef NO_PERL\", but I think\nremoval of both gitweb/{gitweb.cgi,gitweb.min.js} should be unconditional;\nit does not hurt as $(RM) is \"rm -f\" (i.e. don't complain to ENOENT).\n"}]}