{"thread":{"id":"23064","subject":"[PATCH] notes.c: don't call 'return' in a void function","startedAt":"2010-03-18T14:50:37Z","lastAt":"2010-03-18T15:37:34Z","messageCount":3,"participants":["Brandon Casey","Johan Herland"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"137097","messageId":"m6P-Qdljqt7xCgOUC581DdkndLOwc9aVqzGi_vEsC8UeEeGnpREXOnx-fSQIkTfaqsh9HzzlXIM@cipher.nrlssc.navy.mil","threadId":"23064","inReplyTo":null,"subject":"[PATCH] notes.c: don't call 'return' in a void function","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2010-03-18T14:50:37Z","receivedAt":"2010-03-18T14:50:37Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey <drafnel@gmail.com>\n\n\nSigned-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n---\n notes.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/notes.c b/notes.c\nindex a4f9926..07941b7 100644\n--- a/notes.c\n+++ b/notes.c\n@@ -893,7 +893,7 @@ void remove_note(struct notes_tree *t, const unsigned char *object_sha1)\n \tassert(t->initialized);\n \thashcpy(l.key_sha1, object_sha1);\n \thashclr(l.val_sha1);\n-\treturn note_tree_remove(t, t->root, 0, &l);\n+\tnote_tree_remove(t, t->root, 0, &l);\n }\n \n const unsigned char *get_note(struct notes_tree *t,\n-- \n1.6.6.2\n"},{"id":"137098","messageId":"FMCfttz0yXy1PiW0rQs7llBXL-J_qvqMmKHhFzRD_pqpDVu1DBh0TUAi68oer0RcT3kMvGDNHiQ@cipher.nrlssc.navy.mil","threadId":"23064","inReplyTo":"m6P-Qdljqt7xCgOUC581DdkndLOwc9aVqzGi_vEsC8UeEeGnpREXOnx-fSQIkTfaqsh9HzzlXIM@cipher.nrlssc.navy.mil","subject":"[PATCH] notes.c: remove inappropriate call to return","fromName":"Brandon Casey","fromEmail":"casey@nrlssc.navy.mil","sentAt":"2010-03-18T15:03:43Z","receivedAt":"2010-03-18T15:03:43Z","isPatch":true,"sender":{"key":"drafnel@gmail.com","avatar":"https://avatars.githubusercontent.com/u/921167?v=4"},"body":"From: Brandon Casey <drafnel@gmail.com>\n\n\nSigned-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n---\n\n\nHeh, I guess it's ok to call 'return' in a function returning\nvoid, but it shouldn't be passed an argument. :)\n\n-brandon\n\n\n notes.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/notes.c b/notes.c\nindex a4f9926..07941b7 100644\n--- a/notes.c\n+++ b/notes.c\n@@ -893,7 +893,7 @@ void remove_note(struct notes_tree *t, const unsigned char *object_sha1)\n \tassert(t->initialized);\n \thashcpy(l.key_sha1, object_sha1);\n \thashclr(l.val_sha1);\n-\treturn note_tree_remove(t, t->root, 0, &l);\n+\tnote_tree_remove(t, t->root, 0, &l);\n }\n \n const unsigned char *get_note(struct notes_tree *t,\n-- \n1.6.6.2\n"},{"id":"137101","messageId":"201003181637.35168.johan@herland.net","threadId":"23064","inReplyTo":"FMCfttz0yXy1PiW0rQs7llBXL-J_qvqMmKHhFzRD_pqpDVu1DBh0TUAi68oer0RcT3kMvGDNHiQ@cipher.nrlssc.navy.mil","subject":"Re: [PATCH] notes.c: remove inappropriate call to return","fromName":"Johan Herland","fromEmail":"johan@herland.net","sentAt":"2010-03-18T15:37:34Z","receivedAt":"2010-03-18T15:37:34Z","isPatch":true,"sender":{"key":"johan@herland.net","avatar":"https://avatars.githubusercontent.com/u/547031?v=4"},"body":"On Thursday 18 March 2010, Brandon Casey wrote:\n> From: Brandon Casey <drafnel@gmail.com>\n>\n>\n> Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>\n> ---\n>\n>\n> Heh, I guess it's ok to call 'return' in a function returning\n> void, but it shouldn't be passed an argument. :)\n>\n> -brandon\n>\n>\n>  notes.c |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n>\n> diff --git a/notes.c b/notes.c\n> index a4f9926..07941b7 100644\n> --- a/notes.c\n> +++ b/notes.c\n> @@ -893,7 +893,7 @@ void remove_note(struct notes_tree *t, const\n> unsigned char *object_sha1) assert(t->initialized);\n>  \thashcpy(l.key_sha1, object_sha1);\n>  \thashclr(l.val_sha1);\n> -\treturn note_tree_remove(t, t->root, 0, &l);\n> +\tnote_tree_remove(t, t->root, 0, &l);\n>  }\n>\n>  const unsigned char *get_note(struct notes_tree *t,\n\nYes, I noticed this during a recent code review in some related code, \nbut I haven't yet got around to posting a cleanup patch.\n\nAcked-by: Johan Herland <johan@herland.net>\n\n\n...Johan\n\n-- \nJohan Herland, <johan@herland.net>\nwww.herland.net\n"}]}